Change in coreboot[master]: ec/kontron: Use `read_config_X` helpers`

[Angel Pons (Code Review)]

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47113 )

Change subject: ec/kontron: Use `read_config_X` helpers`
......................................................................

ec/kontron: Use `read_config_X` helpers`

Change-Id: Ibca7660ed03525903a1146a1fb2937550406bee8
Signed-off-by: Angel Pons 
---
M src/ec/kontron/it8516e/ec.c
1 file changed, 1 insertion(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/47113/1

diff --git a/src/ec/kontron/it8516e/ec.c b/src/ec/kontron/it8516e/ec.c
index 9af670a..f852c5e 100644
--- a/src/ec/kontron/it8516e/ec.c
+++ b/src/ec/kontron/it8516e/ec.c
@@ -202,8 +202,7 @@
    ec_set_ports(find_resource(dev, PNP_IDX_IO1)->base,
    	     find_resource(dev, PNP_IDX_IO0)->base);

-	u8 systemp_type = config->default_systemp;
-	get_option(&systemp_type, "systemp_type");
+	u8 systemp_type = read_option_u8("systemp_type", config->default_systemp);
    if (systemp_type >= IT8516E_SYSTEMP_LASTPLUSONE)
    	systemp_type = IT8516E_SYSTEMP_NONE;
    it8516e_set_systemp_type(systemp_type);

Change in coreboot[master]: ec/kontron: Use get_int_option()

[Angel Pons (Code Review)]

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/47113

to look at the new patch set (#4).

Change subject: ec/kontron: Use get_int_option()
......................................................................

ec/kontron: Use get_int_option()

Change-Id: Ibca7660ed03525903a1146a1fb2937550406bee8
Signed-off-by: Angel Pons 
---
M src/ec/kontron/it8516e/ec.c
1 file changed, 5 insertions(+), 6 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/47113/4

Change in coreboot[master]: ec/kontron: Use get_int_option()

[Patrick Rudolph (Code Review)]

Attention is currently required from: Angel Pons.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47113 )

Change subject: ec/kontron: Use get_int_option()
......................................................................

Patch Set 6: Code-Review+2

Change in coreboot[master]: ec/kontron: Use get_int_option()

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47113 )

Change subject: ec/kontron: Use get_int_option()
......................................................................

ec/kontron: Use get_int_option()

Change-Id: Ibca7660ed03525903a1146a1fb2937550406bee8
Signed-off-by: Angel Pons 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/47113
Tested-by: build bot (Jenkins) 
Reviewed-by: Patrick Rudolph 
---
M src/ec/kontron/it8516e/ec.c
1 file changed, 5 insertions(+), 6 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Patrick Rudolph: Looks good to me, approved

diff --git a/src/ec/kontron/it8516e/ec.c b/src/ec/kontron/it8516e/ec.c
index 9af670a..0b0e3ac 100644
--- a/src/ec/kontron/it8516e/ec.c
+++ b/src/ec/kontron/it8516e/ec.c
@@ -133,13 +133,13 @@
    u8 fan_max	= config->default_fan_max[fan_idx];

fanX_mode[3] = '1' + fan_idx;
-	get_option(&fan_mode, fanX_mode);
+	fan_mode = get_int_option(fanX_mode, fan_mode);
    if (!fan_mode)
    	fan_mode = IT8516E_MODE_AUTO;
    it8516e_set_fan_mode(fan_idx, fan_mode);

fanX_target[3] = '1' + fan_idx;
-	get_option(&fan_target, fanX_target);
+	fan_target = get_int_option(fanX_target, fan_target);
    switch (fan_mode) {
    case IT8516E_MODE_AUTO:
    	printk(BIOS_DEBUG,
@@ -173,8 +173,8 @@

fanX_min[3] = '1' + fan_idx;
    	fanX_max[3] = '1' + fan_idx;
-		get_option(&fan_min, fanX_min);
-		get_option(&fan_max, fanX_max);
+		fan_min = get_int_option(fanX_min, fan_min);
+		fan_max = get_int_option(fanX_max, fan_max);

if (!fan_max || fan_max > 100)	/* Constrain fan_max to 100% */
    		fan_max = 100;
@@ -202,8 +202,7 @@
    ec_set_ports(find_resource(dev, PNP_IDX_IO1)->base,
    	     find_resource(dev, PNP_IDX_IO0)->base);

-	u8 systemp_type = config->default_systemp;
-	get_option(&systemp_type, "systemp_type");
+	u8 systemp_type = get_int_option("systemp_type", config->default_systemp);
    if (systemp_type >= IT8516E_SYSTEMP_LASTPLUSONE)
    	systemp_type = IT8516E_SYSTEMP_NONE;
    it8516e_set_systemp_type(systemp_type);