James has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37146 )
Change subject: mb/lenovo/x131e: remove non-applicable options from CMOS ......................................................................
mb/lenovo/x131e: remove non-applicable options from CMOS
These options do not work in the same way as on the Lenovo H8 EC. Since they don't work correctly, drop them from the CMOS settings.
Change-Id: Iebc55afd5cc621df562fd7aa9557207147a8199b Signed-off-by: James Ye jye836@gmail.com --- M src/mainboard/lenovo/x131e/cmos.default M src/mainboard/lenovo/x131e/cmos.layout 2 files changed, 2 insertions(+), 10 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/37146/1
diff --git a/src/mainboard/lenovo/x131e/cmos.default b/src/mainboard/lenovo/x131e/cmos.default index b01978a..ca10a85 100644 --- a/src/mainboard/lenovo/x131e/cmos.default +++ b/src/mainboard/lenovo/x131e/cmos.default @@ -3,12 +3,7 @@ power_on_after_fail=Disable nmi=Enable volume=0x3 -bluetooth=Enable wwan=Enable -wlan=Enable -touchpad=Enable sata_mode=AHCI -fn_ctrl_swap=Disable sticky_fn=Disable -trackpoint=Enable usb_always_on=Disable diff --git a/src/mainboard/lenovo/x131e/cmos.layout b/src/mainboard/lenovo/x131e/cmos.layout index 93c74fb..7696046 100644 --- a/src/mainboard/lenovo/x131e/cmos.layout +++ b/src/mainboard/lenovo/x131e/cmos.layout @@ -60,12 +60,9 @@ 411 1 e 8 sata_mode
# coreboot config options: EC -412 1 e 1 bluetooth +#412 1 r 0 unused 413 1 e 1 wwan -414 1 e 1 touchpad -415 1 e 1 wlan -416 1 e 1 trackpoint -417 1 e 1 fn_ctrl_swap +#414 4 r 0 unused 418 1 e 1 sticky_fn 419 2 e 12 usb_always_on #421 3 r 0 unused
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37146 )
Change subject: mb/lenovo/x131e: remove non-applicable options from CMOS ......................................................................
Patch Set 2: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/37146/2/src/mainboard/lenovo/x131e/... File src/mainboard/lenovo/x131e/cmos.layout:
https://review.coreboot.org/c/coreboot/+/37146/2/src/mainboard/lenovo/x131e/... PS2, Line 63: #412 1 r 0 unused I guess these "unused" entries are not really needed
Hello Alexander Couzens, Patrick Rudolph, Angel Pons, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37146
to look at the new patch set (#3).
Change subject: mb/lenovo/x131e: remove non-applicable options from CMOS ......................................................................
mb/lenovo/x131e: remove non-applicable options from CMOS
These options do not work in the same way as on the Lenovo H8 EC. Since they don't work correctly, drop them from the CMOS settings.
Change-Id: Iebc55afd5cc621df562fd7aa9557207147a8199b Signed-off-by: James Ye jye836@gmail.com --- M src/mainboard/lenovo/x131e/cmos.default M src/mainboard/lenovo/x131e/cmos.layout 2 files changed, 2 insertions(+), 10 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/37146/3
Martin L Roth has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/37146?usp=email )
Change subject: mb/lenovo/x131e: remove non-applicable options from CMOS ......................................................................
Abandoned
This patch has not been touched in over 12 months. Anyone who wants to take over work on this patch, please feel free to restore it and do any work needed to get it merged. If you create a new patch based on this work, please credit the original author.
-
Angel Pons (Code Review) -
James (Code Review)
-
Martin L Roth (Code Review)