Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34475 )
Change subject: Add Razer Blade Stealth (2016) H2U ......................................................................
Patch Set 35: Code-Review+2
(6 comments)
Juuust minor nits.
https://review.coreboot.org/c/coreboot/+/34475/35//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34475/35//COMMIT_MSG@18 PS35, Line 18: tho though
https://review.coreboot.org/c/coreboot/+/34475/35//COMMIT_MSG@18 PS35, Line 18: Even tho it has a 16MB chip equipped (W25Q128.V) only the first 8MB are used and mapped. The rest should be left empty (0xFF) These lines are still too long
https://review.coreboot.org/c/coreboot/+/34475/35/src/mainboard/razer/blade_... File src/mainboard/razer/blade_stealth_kbl/acpi/battery.asl:
https://review.coreboot.org/c/coreboot/+/34475/35/src/mainboard/razer/blade_... PS35, Line 62: St
The indentation looks broken here (8 spaces here vs. […]
Should be tabs everywhere btw
https://review.coreboot.org/c/coreboot/+/34475/33/src/mainboard/razer/blade_... File src/mainboard/razer/blade_stealth_kbl/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/34475/33/src/mainboard/razer/blade_... PS33, Line 216: d
Without it the display is not found. […]
Weird... If it works, I wouldn't bother
Ack
https://review.coreboot.org/c/coreboot/+/34475/35/src/mainboard/razer/blade_... File src/mainboard/razer/blade_stealth_kbl/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/34475/35/src/mainboard/razer/blade_... PS35, Line 24: // The empty comment lines on this file could be removed
https://review.coreboot.org/c/coreboot/+/34475/35/src/mainboard/razer/blade_... File src/mainboard/razer/blade_stealth_kbl/mainboard.c:
https://review.coreboot.org/c/coreboot/+/34475/35/src/mainboard/razer/blade_... PS35, Line 38: if (rdev_readat(&cbfs_region, serial_number, 0, serial_len) [bikeshedding-grade] seeing this line being split makes me suffer. maybe rename "serial_len" to "len", if you want?
-
Angel Pons (Code Review)