Juuust minor nits.

Patch set 35:Code-Review +2

View Change

6 comments:

• Commit Message:

  • Patch Set #35, Line 18: tho

    though

  • Patch Set #35, Line 18: Even tho it has a 16MB chip equipped (W25Q128.V) only the first 8MB are used and mapped. The rest should be left empty (0xFF)

    These lines are still too long

• File src/mainboard/razer/blade_stealth_kbl/acpi/battery.asl:

  • Patch Set #35, Line 62: St

    The indentation looks broken here (8 spaces here vs. […]

    Should be tabs everywhere btw

• File src/mainboard/razer/blade_stealth_kbl/devicetree.cb:

  • Patch Set #33, Line 216: d

    Without it the display is not found. […]

    Weird... If it works, I wouldn't bother

    Ack

• File src/mainboard/razer/blade_stealth_kbl/hda_verb.c:

  • Patch Set #35, Line 24: //

    The empty comment lines on this file could be removed

• File src/mainboard/razer/blade_stealth_kbl/mainboard.c:

  • Patch Set #35, Line 38: if (rdev_readat(&cbfs_region, serial_number, 0, serial_len)

    [bikeshedding-grade] seeing this line being split makes me suffer. maybe rename "serial_len" to "len", if you want?

To view, visit change 34475. To unsubscribe, or for help writing mail filters, visit settings.