Attention is currently required from: Chen, Gang C, Felix Held, Fred Reitberger, Jason Glenesk, Jérémy Compostella, Martin L Roth, Matt DeVillier, Nico Huber.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78328?usp=email )
Change subject: device/device.h: Drop multiple links ......................................................................
Patch Set 10: -Code-Review
Copied votes on follow-up patch sets have been updated: * Copied Code-Review vote has been removed from patch set 11 (was Code-Review-2), 12 (was Code-Review-2) since the new Code-Review=0 vote is not copyable (copy condition: "changekind:NO_CHANGE OR changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN").
(10 comments)
Patchset:
PS10: Fixed my board.
File src/device/device.c:
https://review.coreboot.org/c/coreboot/+/78328/comment/aeef8946_00777154 : PS10, Line 362: if (link && link->reset_needed) {
Or `continue;` if not.
Done.
File src/device/device_util.c:
https://review.coreboot.org/c/coreboot/+/78328/comment/66a6f489_28360b09 : PS10, Line 550: search_bus_resources(curdev->link_list, type_mask, type,
Missing NULL-check.
Done
File src/device/root_device.c:
https://review.coreboot.org/c/coreboot/+/78328/comment/05a153c3_d88a72a8 : PS10, Line 41:
Missing NULL-check.
Done
https://review.coreboot.org/c/coreboot/+/78328/comment/95b160c1_fdf0f7a7 : PS10, Line 78: Then, link_list buses
Was this on purpose? Looks a bit like something went wrong undoing the renaming?
Done.
File src/southbridge/amd/pi/hudson/lpc.c:
https://review.coreboot.org/c/coreboot/+/78328/comment/2dabe6a5_b2484e52 : PS8, Line 187: dev_path(child), base, end);
i'd strongly prefer to not also have some unrelated whitespace changes in this patch. […]
Done
File util/sconfig/main.c:
https://review.coreboot.org/c/coreboot/+/78328/comment/e46ac051_5f4ac128 : PS10, Line 1178: if (bus->children)
Or `assert(ptr->bus && ptr->bus->children);`. It seems to be checked before the call.
Done.
https://review.coreboot.org/c/coreboot/+/78328/comment/e210202d_c1898f16 : PS10, Line 1330: bus && bus->children
Or dev_has_children(). We should either use it everywhere or could also drop it.
Done
https://review.coreboot.org/c/coreboot/+/78328/comment/0a69bde8_aabb5232 : PS10, Line 1789: buses
*bus
Done
File util/sconfig/sconfig.h:
https://review.coreboot.org/c/coreboot/+/78328/comment/87198e68_4affa093 : PS10, Line 157: struct bus *last_bus;
Drop
Done