Attention is currently required from: Chen, Gang C, Felix Held, Fred Reitberger, Jason Glenesk, Jérémy Compostella, Martin L Roth, Matt DeVillier, Nico Huber.
Patch set 10:-Code-Review
10 comments:
Patchset:
Fixed my board.
File src/device/device.c:
Patch Set #10, Line 362: if (link && link->reset_needed) {
Or `continue;` if not.
Done.
File src/device/device_util.c:
Patch Set #10, Line 550: search_bus_resources(curdev->link_list, type_mask, type,
Missing NULL-check.
Done
File src/device/root_device.c:
Missing NULL-check.
Done
Patch Set #10, Line 78: Then, link_list buses
Was this on purpose? Looks a bit like something went wrong undoing the renaming?
Done.
File src/southbridge/amd/pi/hudson/lpc.c:
Patch Set #8, Line 187: dev_path(child), base, end);
i'd strongly prefer to not also have some unrelated whitespace changes in this patch. […]
Done
File util/sconfig/main.c:
Patch Set #10, Line 1178: if (bus->children)
Or `assert(ptr->bus && ptr->bus->children);`. It seems to be checked before
the call.
Done.
Patch Set #10, Line 1330: bus && bus->children
Or dev_has_children(). We should either use it everywhere or could also drop it.
Done
Patch Set #10, Line 1789: buses
*bus
Done
File util/sconfig/sconfig.h:
Patch Set #10, Line 157: struct bus *last_bus;
Drop
Done
To view, visit change 78328. To unsubscribe, or for help writing mail filters, visit settings.