Marc Jones has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46057 )
Change subject: soc/intel/xeon_sp: Use generic config_t ......................................................................
soc/intel/xeon_sp: Use generic config_t
Don't use the silicon specific typedef to get common config options. Use the generic config_t pointer. This allows the function to be moved to common code in upcoming patches.
Change-Id: If80b678037b4d79387e0a0f722c540df4aae2416 Signed-off-by: Marc Jones marcjones@sysproconsulting.com --- M src/soc/intel/xeon_sp/cpx/soc_acpi.c M src/soc/intel/xeon_sp/skx/soc_acpi.c 2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/46057/1
diff --git a/src/soc/intel/xeon_sp/cpx/soc_acpi.c b/src/soc/intel/xeon_sp/cpx/soc_acpi.c index b711727..1ae51d2 100644 --- a/src/soc/intel/xeon_sp/cpx/soc_acpi.c +++ b/src/soc/intel/xeon_sp/cpx/soc_acpi.c @@ -684,7 +684,7 @@ acpi_slit_t *slit; acpi_dmar_t *dmar;
- const struct soc_intel_xeon_sp_cpx_config *const config = config_of(device); + const config_t *const config = config_of(device);
/* SRAT */ current = ALIGN(current, 8); diff --git a/src/soc/intel/xeon_sp/skx/soc_acpi.c b/src/soc/intel/xeon_sp/skx/soc_acpi.c index 2a3c04e..9c07ec7 100644 --- a/src/soc/intel/xeon_sp/skx/soc_acpi.c +++ b/src/soc/intel/xeon_sp/skx/soc_acpi.c @@ -586,7 +586,7 @@ acpi_slit_t *slit; acpi_dmar_t *dmar;
- const struct soc_intel_xeon_sp_skx_config *const config = config_of(device); + const config_t *const config = config_of(device);
/* SRAT */ current = ALIGN(current, 8);
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46057 )
Change subject: soc/intel/xeon_sp: Use generic config_t ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/46057/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46057/1//COMMIT_MSG@9 PS1, Line 9: Don't use the silicon specific typedef to get common config options. Technically, the only typedef here is config_t, which is not a pointer:
Don't use the silicon-specific struct type to get common config options. Instead, use the generic config_t typedef. This allows the function to be moved to common code in upcoming patches.
Jay Talbott has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46057 )
Change subject: soc/intel/xeon_sp: Use generic config_t ......................................................................
Patch Set 1: Code-Review+1
Hello build bot (Jenkins), Jonathan Zhang, Jay Talbott, Angel Pons, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46057
to look at the new patch set (#2).
Change subject: soc/intel/xeon_sp: Use generic config_t ......................................................................
soc/intel/xeon_sp: Use generic config_t
Don't use the silicon-specific struct type to get common config options. Instead, use the generic config_t typedef. This allows the function to be moved to common code in upcoming patches.
Change-Id: If80b678037b4d79387e0a0f722c540df4aae2416 Signed-off-by: Marc Jones marcjones@sysproconsulting.com --- M src/soc/intel/xeon_sp/cpx/soc_acpi.c M src/soc/intel/xeon_sp/skx/soc_acpi.c 2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/46057/2
Jay Talbott has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46057 )
Change subject: soc/intel/xeon_sp: Use generic config_t ......................................................................
Patch Set 2: Code-Review+1
Marc Jones has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46057 )
Change subject: soc/intel/xeon_sp: Use generic config_t ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46057/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46057/1//COMMIT_MSG@9 PS1, Line 9: Don't use the silicon specific typedef to get common config options.
Technically, the only typedef here is config_t, which is not a pointer: […]
Ack
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46057 )
Change subject: soc/intel/xeon_sp: Use generic config_t ......................................................................
Patch Set 2: Code-Review+2
Marc Jones has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46057 )
Change subject: soc/intel/xeon_sp: Use generic config_t ......................................................................
soc/intel/xeon_sp: Use generic config_t
Don't use the silicon-specific struct type to get common config options. Instead, use the generic config_t typedef. This allows the function to be moved to common code in upcoming patches.
Change-Id: If80b678037b4d79387e0a0f722c540df4aae2416 Signed-off-by: Marc Jones marcjones@sysproconsulting.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/46057 Reviewed-by: Jay Talbott JayTalbott@sysproconsulting.com Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/intel/xeon_sp/cpx/soc_acpi.c M src/soc/intel/xeon_sp/skx/soc_acpi.c 2 files changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved Jay Talbott: Looks good to me, but someone else must approve
diff --git a/src/soc/intel/xeon_sp/cpx/soc_acpi.c b/src/soc/intel/xeon_sp/cpx/soc_acpi.c index a9af4aa..db1d3d2 100644 --- a/src/soc/intel/xeon_sp/cpx/soc_acpi.c +++ b/src/soc/intel/xeon_sp/cpx/soc_acpi.c @@ -681,7 +681,7 @@ acpi_slit_t *slit; acpi_dmar_t *dmar;
- const struct soc_intel_xeon_sp_cpx_config *const config = config_of(device); + const config_t *const config = config_of(device);
/* SRAT */ current = ALIGN(current, 8); diff --git a/src/soc/intel/xeon_sp/skx/soc_acpi.c b/src/soc/intel/xeon_sp/skx/soc_acpi.c index 34ab428..c986214 100644 --- a/src/soc/intel/xeon_sp/skx/soc_acpi.c +++ b/src/soc/intel/xeon_sp/skx/soc_acpi.c @@ -588,7 +588,7 @@ acpi_slit_t *slit; acpi_dmar_t *dmar;
- const struct soc_intel_xeon_sp_skx_config *const config = config_of(device); + const config_t *const config = config_of(device);
/* SRAT */ current = ALIGN(current, 8);
-
Angel Pons (Code Review) -
Jay Talbott (Code Review)
-
Marc Jones (Code Review)