Patch set 1:Code-Review +1
View Change
1 comment:
Commit Message:
Patch Set #1, Line 9: Don't use the silicon specific typedef to get common config options.
Technically, the only typedef here is config_t, which is not a pointer:
Don't use the silicon-specific struct type to get common config options. Instead, use the generic config_t typedef. This allows the function to be moved to common code in upcoming patches.
To view, visit change 46057. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If80b678037b4d79387e0a0f722c540df4aae2416
Gerrit-Change-Number: 46057
Gerrit-PatchSet: 1
Gerrit-Owner: Marc Jones <marc@marcjonesconsulting.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Jonathan Zhang <jonzhang@fb.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-CC: Jay Talbott <JayTalbott@sysproconsulting.com>
Gerrit-CC: Stefan Reinauer <stefan.reinauer@coreboot.org>
Gerrit-Comment-Date: Mon, 05 Oct 2020 20:18:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment