Change in coreboot[master]: [TEST only]: mb/google/dedede/var/drawcia: Use TABLEMODE bit to load ...

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Chen Wisley (Code Review)

9 Sep 2020 9 Sep '20

9:08 a.m.

Chen Wisley has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45190 )

Change subject: [TEST only]: mb/google/dedede/var/drawcia: Use TABLEMODE bit to load LV or TFC module ......................................................................

[TEST only]: mb/google/dedede/var/drawcia: Use TABLEMODE bit to load LV or TFC module

BUG=none TEST=emerge-dedede coreboot, change tabletmode bit in CBI and dump ssdt table,

Change-Id: I35dcc7bb82ceb014fd40b794ccf190b226061281 --- M src/mainboard/google/dedede/Kconfig M src/mainboard/google/dedede/variants/baseboard/devicetree.cb M src/mainboard/google/dedede/variants/drawcia/overridetree.cb 3 files changed, 16 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/45190/1

diff --git a/src/mainboard/google/dedede/Kconfig b/src/mainboard/google/dedede/Kconfig index 2bb255f..c9c2803 100644 --- a/src/mainboard/google/dedede/Kconfig +++ b/src/mainboard/google/dedede/Kconfig @@ -11,6 +11,8 @@ select EC_GOOGLE_CHROMEEC_BOARDID select EC_GOOGLE_CHROMEEC_ESPI select EC_GOOGLE_CHROMEEC_SKUID + select FW_CONFIG + select FW_CONFIG_SOURCE_CHROMEEC_CBI select GOOGLE_SMBIOS_MAINBOARD_VERSION select HAVE_ACPI_RESUME select HAVE_ACPI_TABLES diff --git a/src/mainboard/google/dedede/variants/baseboard/devicetree.cb b/src/mainboard/google/dedede/variants/baseboard/devicetree.cb index 363307b..01fcad0 100644 --- a/src/mainboard/google/dedede/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/dedede/variants/baseboard/devicetree.cb @@ -1,3 +1,10 @@ +fw_config + field TABLETMODE 10 + option TABLETMODE_DISABLED 0 + option TABLETMODE_ENABLED 1 + end +end + chip soc/intel/jasperlake device cpu_cluster 0 on device lapic 0 on end diff --git a/src/mainboard/google/dedede/variants/drawcia/overridetree.cb b/src/mainboard/google/dedede/variants/drawcia/overridetree.cb index 0506cd4..2c78b21 100644 --- a/src/mainboard/google/dedede/variants/drawcia/overridetree.cb +++ b/src/mainboard/google/dedede/variants/drawcia/overridetree.cb @@ -242,7 +242,13 @@ register "off_seq.ops[2]" = "SEQ_OPS_GPIO_DISABLE(1, 0)" register "off_seq.ops[3]" = "SEQ_OPS_GPIO_DISABLE(0, 0)"

- device i2c 36 on end + device i2c 36 on + probe TABLETMODE TABLETMODE_DISABLED + end + device i2c 10 on + probe TABLETMODE TABLETMODE_ENABLED + end + end chip drivers/intel/mipi_camera register "acpi_hid" = "ACPI_DT_NAMESPACE_HID"

Attachments:

attachment.htm (text/html — 4.9 KB)

Show replies by date

Chen Wisley (Code Review)

9 Sep 9 Sep

9:10 a.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45190

to look at the new patch set (#2).

Change subject: [TEST only]: mb/google/dedede/var/drawcia: Use TABLEMODE bit to load LV or TFC module ......................................................................

[TEST only]: mb/google/dedede/var/drawcia: Use TABLEMODE bit to load LV or TFC module

BUG=none TEST=emerge-dedede coreboot, change tabletmode bit in CBI and dump ssdt table,

Change-Id: I35dcc7bb82ceb014fd40b794ccf190b226061281 Signed-off-by: Wisley Chen wisley.chen@quantatw.com --- M src/mainboard/google/dedede/Kconfig M src/mainboard/google/dedede/variants/baseboard/devicetree.cb M src/mainboard/google/dedede/variants/drawcia/overridetree.cb 3 files changed, 16 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/45190/2

Chen Wisley (Code Review)

9:12 a.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45190

to look at the new patch set (#3).

Change subject: [TEST only]: mb/google/dedede/var/drawcia: Use TABLEMODE bit to load LV or TFC module ......................................................................

[TEST only]: mb/google/dedede/var/drawcia: Use TABLEMODE bit to load LV or TFC module

Use tablet mode bit to load LV module/TFC module for test.

BUG=none TEST=emerge-dedede coreboot, change tabletmode bit in CBI and dump ssdt table,

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/45190/3

Chen Wisley (Code Review)

9:16 a.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45190

to look at the new patch set (#4).

Change subject: [TEST only]: mb/google/dedede/var/drawcia: Use TABLEMODE bit to load LV or TFC module ......................................................................

[TEST only]: mb/google/dedede/var/drawcia: Use TABLEMODE bit to load LV or TFC module

Use tablet mode bit (bit10) to load LV module/TFC module for test.

0: TFC module 1: LV module

BUG=none TEST=emerge-dedede coreboot, change tabletmode bit in CBI and dump ssdt table,

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/45190/4

Chen Wisley (Code Review)

10:06 a.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45190

to look at the new patch set (#5).

Change subject: [TEST only]: mb/google/dedede/var/drawcia: Use TABLEMODE bit to load LV or TFC module ......................................................................

[TEST only]: mb/google/dedede/var/drawcia: Use TABLEMODE bit to load LV or TFC module

Use tablet mode bit (bit10) to load LVI module/TFC module for test.

0: TFC module 1: LVI module

BUG=none TEST=emerge-dedede coreboot, change tabletmode bit in CBI and dump ssdt table,

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/45190/5

Chen Wisley (Code Review)

10:06 a.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45190

to look at the new patch set (#6).

Change subject: [TEST only]: mb/google/dedede/var/drawcia: Use TABLEMODE bit to load LVI or TFC module ......................................................................

[TEST only]: mb/google/dedede/var/drawcia: Use TABLEMODE bit to load LVI or TFC module

Use tablet mode bit (bit10) to load LVI module/TFC module for test.

0: TFC module 1: LVI module

BUG=none TEST=emerge-dedede coreboot, change tabletmode bit in CBI and dump ssdt table,

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/45190/6

Chen Wisley (Code Review)

14 Sep 14 Sep

8:14 a.m.

New subject: Change in coreboot[master]: mb/google/dedede/var/drawcia: Use TABLEMODE bit to probe mipi camera

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45190

to look at the new patch set (#7).

Change subject: mb/google/dedede/var/drawcia: Use TABLEMODE bit to probe mipi camera ......................................................................

mb/google/dedede/var/drawcia: Use TABLEMODE bit to probe mipi camera

Drawcia is convertible, drawman/drawlat is challshell and only drawcia support mipi camera.

Use tabletmode bit of fw_config to probe IPU/CAM1/NVM/VCM devices.

BUG=b:163879470 TEST=emerge-dedede coreboot, change tabletmode bit in CBI and dump ssdt table,

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/45190/7

build bot (Jenkins) (Code Review)

8:15 a.m.

New subject: Change in coreboot[master]: mb/google/dedede/var/drawcia: Use TABLEMODE bit to probe mipi camera

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45190 )

Change subject: mb/google/dedede/var/drawcia: Use TABLEMODE bit to probe mipi camera ......................................................................

Patch Set 7:

(3 comments)

https://review.coreboot.org/c/coreboot/+/45190/7/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/drawcia/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/45190/7/src/mainboard/google/dedede... PS7, Line 80: probe TABLETMODE TABLETMODE_ENABLED trailing whitespace

https://review.coreboot.org/c/coreboot/+/45190/7/src/mainboard/google/dedede... PS7, Line 262: device i2c 0C on trailing whitespace

https://review.coreboot.org/c/coreboot/+/45190/7/src/mainboard/google/dedede... PS7, Line 279: device i2c 50 on trailing whitespace

Chen Wisley (Code Review)

8:17 a.m.

New subject: Change in coreboot[master]: mb/google/dedede/var/drawcia: Use TABLEMODE bit to probe mipi camera

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45190

to look at the new patch set (#8).

Change subject: mb/google/dedede/var/drawcia: Use TABLEMODE bit to probe mipi camera ......................................................................

mb/google/dedede/var/drawcia: Use TABLEMODE bit to probe mipi camera

Drawcia is convertible, drawman/drawlat is challshell and only drawcia support mipi camera.

Use tabletmode bit of fw_config to probe IPU/CAM1/NVM/VCM devices.

BUG=b:163879470 TEST=emerge-dedede coreboot, change tabletmode bit in CBI and dump ssdt table,

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/45190/8

Chen Wisley (Code Review)

9:02 a.m.

New subject: Change in coreboot[master]: mb/google/dedede/var/drawcia: probe TABLEMODE bit to add mipi camera

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45190

to look at the new patch set (#9).

Change subject: mb/google/dedede/var/drawcia: probe TABLEMODE bit to add mipi camera ......................................................................

mb/google/dedede/var/drawcia: probe TABLEMODE bit to add mipi camera

Drawcia is convertible, drawman/drawlat is challshell and only drawcia support mipi camera.

Use tabletmode bit of fw_config to probe IPU/CAM1/NVM/VCM devices.

BUG=b:163879470 TEST=emerge-dedede coreboot, change tabletmode bit in CBI and dump ssdt table,

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/45190/9

Chen Wisley (Code Review)

9:08 a.m.

New subject: Change in coreboot[master]: mb/google/dedede/var/drawcia: probe TABLEMODE bit to add mipi camera

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45190

to look at the new patch set (#10).

Change subject: mb/google/dedede/var/drawcia: probe TABLEMODE bit to add mipi camera ......................................................................

mb/google/dedede/var/drawcia: probe TABLEMODE bit to add mipi camera

Drawcia is convertible, drawman/drawlat is challshell and only drawcia support mipi camera.

Probe tabletmode bit of fw_config to add IPU/CAM1/NVM/VCM devices.

BUG=b:163879470 TEST=emerge-dedede coreboot, change tabletmode bit in CBI and dump ssdt table,

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/45190/10

Chen Wisley (Code Review)

9:13 a.m.

New subject: Change in coreboot[master]: mb/google/dedede/var/drawcia: probe TABLEMODE bit to add mipi camera

Chen Wisley has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45190 )

Change subject: mb/google/dedede/var/drawcia: probe TABLEMODE bit to add mipi camera ......................................................................

Patch Set 10:

The patch needs to rebase because fw_config feature already enabled in cb:45185

-- To view, visit https://review.coreboot.org/c/coreboot/+/45190 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I35dcc7bb82ceb014fd40b794ccf190b226061281 Gerrit-Change-Number: 45190 Gerrit-PatchSet: 10 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Sugnan Prabhu S sugnan.prabhu.s@intel.com Gerrit-Reviewer: Varshit B Pandya varshit.b.pandya@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Aamir Bohra aamir.bohra@intel.com Gerrit-CC: Maulik V Vaghela maulik.v.vaghela@intel.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 14 Sep 2020 07:13:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Chen Wisley (Code Review)

9:28 a.m.

New subject: Change in coreboot[master]: mb/google/dedede/var/drawcia: probe TABLEMODE bit to add mipi camera

Hello Varshit B Pandya, build bot (Jenkins), Rizwan Qureshi, Sugnan Prabhu S,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45190

to look at the new patch set (#11).

Change subject: mb/google/dedede/var/drawcia: probe TABLEMODE bit to add mipi camera ......................................................................

mb/google/dedede/var/drawcia: probe TABLEMODE bit to add mipi camera

Drawcia is convertible, drawman/drawlat is challshell and only drawcia support mipi camera. Probe tabletmode bit of fw_config to add IPU/CAM1/NVM/VCM devices.

BUG=b:163879470 TEST=emerge-dedede coreboot, change tabletmode bit in CBI and dump ssdt table,

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/45190/11

-- To view, visit https://review.coreboot.org/c/coreboot/+/45190 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I35dcc7bb82ceb014fd40b794ccf190b226061281 Gerrit-Change-Number: 45190 Gerrit-PatchSet: 11 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Sugnan Prabhu S sugnan.prabhu.s@intel.com Gerrit-Reviewer: Varshit B Pandya varshit.b.pandya@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Aamir Bohra aamir.bohra@intel.com Gerrit-CC: Maulik V Vaghela maulik.v.vaghela@intel.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Karthik Ramasubramanian (Code Review)

18 Sep 18 Sep

11:41 p.m.

New subject: Change in coreboot[master]: mb/google/dedede/var/drawcia: probe TABLEMODE bit to add mipi camera

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45190 )

Change subject: mb/google/dedede/var/drawcia: probe TABLEMODE bit to add mipi camera ......................................................................

Patch Set 11: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/45190 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I35dcc7bb82ceb014fd40b794ccf190b226061281 Gerrit-Change-Number: 45190 Gerrit-PatchSet: 11 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Andy Yeh andy.yeh@intel.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Marco Chen marcochen@chromium.org Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Sugnan Prabhu S sugnan.prabhu.s@intel.com Gerrit-Reviewer: Varshit B Pandya varshit.b.pandya@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Aamir Bohra aamir.bohra@intel.com Gerrit-CC: Andy Yeh andy.yeh@intel.com Gerrit-CC: Henry Sun henrysun@google.com Gerrit-CC: Maulik V Vaghela maulik.v.vaghela@intel.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 18 Sep 2020 21:41:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Karthik Ramasubramanian (Code Review)

21 Oct 21 Oct

7:14 p.m.

New subject: Change in coreboot[master]: mb/google/dedede/var/drawcia: probe TABLEMODE bit to add mipi camera

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45190 )

Change subject: mb/google/dedede/var/drawcia: probe TABLEMODE bit to add mipi camera ......................................................................

Patch Set 11: -Code-Review

Thinking about it further, I don't think probing for TABLET mode is not the right approach to enable MIPI camera. You might want to consider provisioning the FW_CONFIG with camera information.

I am withdrawing my +2.

-- To view, visit https://review.coreboot.org/c/coreboot/+/45190 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I35dcc7bb82ceb014fd40b794ccf190b226061281 Gerrit-Change-Number: 45190 Gerrit-PatchSet: 11 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Andy Yeh andy.yeh@intel.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Marco Chen marcochen@chromium.org Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Sugnan Prabhu S sugnan.prabhu.s@intel.com Gerrit-Reviewer: Varshit B Pandya varshit.b.pandya@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Aamir Bohra aamir.bohra@intel.com Gerrit-CC: Andy Yeh andy.yeh@intel.com Gerrit-CC: Henry Sun henrysun@google.com Gerrit-CC: Maulik V Vaghela maulik.v.vaghela@intel.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 21 Oct 2020 17:14:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Martin L Roth (Code Review)

7 Aug 7 Aug

10:14 p.m.

New subject: [S] Change in coreboot[master]: mb/google/dedede/var/drawcia: probe TABLEMODE bit to add mipi camera

Martin L Roth has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/45190?usp=email )

Change subject: mb/google/dedede/var/drawcia: probe TABLEMODE bit to add mipi camera ......................................................................

Abandoned

This patch has not been touched in over 12 months. Anyone who wants to take over work on this patch, please feel free to restore it and do any work needed to get it merged. If you create a new patch based on this work, please credit the original author.

-- To view, visit https://review.coreboot.org/c/coreboot/+/45190?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I35dcc7bb82ceb014fd40b794ccf190b226061281 Gerrit-Change-Number: 45190 Gerrit-PatchSet: 11 Gerrit-Owner: Chen Wisley wisley.chen%quantatw.com@gtempaccount.com Gerrit-Reviewer: Andy Yeh andy.yeh@intel.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Marco Chen marcochen@chromium.org Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Sugnan Prabhu S sugnan.prabhu.s@intel.com Gerrit-Reviewer: Varshit Pandya pandyavarshit@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Aamir Bohra aamirbohra@google.com Gerrit-CC: Andy Yeh andy.yeh@intel.com Gerrit-CC: Henry Sun henrysun@google.com Gerrit-CC: Martin L Roth gaumless@gmail.com Gerrit-CC: Maulik Vaghela maulikvaghela@google.com Gerrit-CC: Paul Menzel paulepanter@mailbox.org Gerrit-MessageType: abandon

474

days inactive

1536

days old

coreboot-gerrit@coreboot.org

15 comments

4 participants

tags (0)

participants (4)

build bot (Jenkins) (Code Review)
Chen Wisley (Code Review)
Karthik Ramasubramanian (Code Review)
Martin L Roth (Code Review)