Change in coreboot[master]: mb/google/dedede/variants/drawcia: Reduce TCC offset from 20 to 5

List overview All Threads
Download

newer

older

Change in coreboot[master]: [TEST...

Change in coreboot[master]:...

Sumeet R Pawnikar (Code Review)

10 Sep 2020 10 Sep '20

3:32 p.m.

Sumeet R Pawnikar has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45267 )

Change subject: mb/google/dedede/variants/drawcia: Reduce TCC offset from 20 to 5 ......................................................................

mb/google/dedede/variants/drawcia: Reduce TCC offset from 20 to 5

Reduce TCC offset value from 20 to 5 for Thermal Control Circuit(TCC) activation.

Change-Id: I9222a922a55d27bc175f219c5bbb59b246abec9f Signed-off-by: Sumeet R Pawnikar sumeet.r.pawnikar@intel.com --- M src/mainboard/google/dedede/variants/drawcia/overridetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/45267/1

diff --git a/src/mainboard/google/dedede/variants/drawcia/overridetree.cb b/src/mainboard/google/dedede/variants/drawcia/overridetree.cb index 395dee3..adde5bc 100644 --- a/src/mainboard/google/dedede/variants/drawcia/overridetree.cb +++ b/src/mainboard/google/dedede/variants/drawcia/overridetree.cb @@ -62,7 +62,7 @@ .tdp_pl2_override = 15, }"

- register "tcc_offset" = "20" # TCC of 85C + register "tcc_offset" = "5" # TCC of 100C

device domain 0 on device pci 04.0 on

Attachments:

attachment.htm (text/html — 2.6 KB)

Show replies by date

Paul Menzel (Code Review)

10 Sep 10 Sep

3:41 p.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45267 )

Change subject: mb/google/dedede/variants/drawcia: Reduce TCC offset from 20 to 5 ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45267/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/45267/1//COMMIT_MSG@9 PS1, Line 9: Reduce TCC offset value from 20 to 5 for Thermal Control Circuit(TCC) Please add a space before the (.

-- To view, visit https://review.coreboot.org/c/coreboot/+/45267 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9222a922a55d27bc175f219c5bbb59b246abec9f Gerrit-Change-Number: 45267 Gerrit-PatchSet: 1 Gerrit-Owner: Sumeet R Pawnikar sumeet.r.pawnikar@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 10 Sep 2020 15:41:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Sumeet R Pawnikar (Code Review)

3:46 p.m.

Hello build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Tim Wawrzynczak, Karthik Ramasubramanian,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45267

to look at the new patch set (#2).

Change subject: mb/google/dedede/variants/drawcia: Reduce TCC offset from 20 to 5 ......................................................................

mb/google/dedede/variants/drawcia: Reduce TCC offset from 20 to 5

Reduce TCC offset value from 20 to 5 for Thermal Control Circuit (TCC) activation.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/45267/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/45267 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9222a922a55d27bc175f219c5bbb59b246abec9f Gerrit-Change-Number: 45267 Gerrit-PatchSet: 2 Gerrit-Owner: Sumeet R Pawnikar sumeet.r.pawnikar@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Sumeet R Pawnikar (Code Review)

3:48 p.m.

Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45267 )

Change subject: mb/google/dedede/variants/drawcia: Reduce TCC offset from 20 to 5 ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45267/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/45267/1//COMMIT_MSG@9 PS1, Line 9: Reduce TCC offset value from 20 to 5 for Thermal Control Circuit(TCC)

...

Please add a space before the (.

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/45267 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9222a922a55d27bc175f219c5bbb59b246abec9f Gerrit-Change-Number: 45267 Gerrit-PatchSet: 2 Gerrit-Owner: Sumeet R Pawnikar sumeet.r.pawnikar@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 10 Sep 2020 15:48:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

4:15 p.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45267 )

Change subject: mb/google/dedede/variants/drawcia: Reduce TCC offset from 20 to 5 ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45267/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/45267/2//COMMIT_MSG@10 PS2, Line 10: activation. I think it would be good to capture the reason behind the change. Also, does S0ix stress test look good with this change?

-- To view, visit https://review.coreboot.org/c/coreboot/+/45267 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9222a922a55d27bc175f219c5bbb59b246abec9f Gerrit-Change-Number: 45267 Gerrit-PatchSet: 2 Gerrit-Owner: Sumeet R Pawnikar sumeet.r.pawnikar@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 10 Sep 2020 16:15:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Martin L Roth (Code Review)

7 Aug 7 Aug

8:14 p.m.

New subject: [XS] Change in coreboot[master]: mb/google/dedede/variants/drawcia: Reduce TCC offset from 20 to 5

Martin L Roth has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/45267?usp=email )

Change subject: mb/google/dedede/variants/drawcia: Reduce TCC offset from 20 to 5 ......................................................................

Abandoned

This patch has not been touched in over 12 months. Anyone who wants to take over work on this patch, please feel free to restore it and do any work needed to get it merged. If you create a new patch based on this work, please credit the original author.

-- To view, visit https://review.coreboot.org/c/coreboot/+/45267?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9222a922a55d27bc175f219c5bbb59b246abec9f Gerrit-Change-Number: 45267 Gerrit-PatchSet: 2 Gerrit-Owner: Sumeet R Pawnikar sumeet.r.pawnikar@intel.com Gerrit-Reviewer: Furquan Shaikh furquan.m.shaikh@gmail.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Tim Wawrzynczak inforichland@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Martin L Roth gaumless@gmail.com Gerrit-CC: Paul Menzel paulepanter@mailbox.org Gerrit-MessageType: abandon

285

days inactive

1346

days old

coreboot-gerrit@coreboot.org

5 comments

4 participants

tags (0)

participants (4)

Furquan Shaikh (Code Review)
Martin L Roth (Code Review)
Paul Menzel (Code Review)
Sumeet R Pawnikar (Code Review)