Hello Hung-Te Lin, Nico Huber,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/37433
to review the following change.
Change subject: Change all clrsetbits_leXX() to clrsetbitsXX() ......................................................................
Change all clrsetbits_leXX() to clrsetbitsXX()
This patch changes all existing instances of clrsetbits_leXX() to the new endian-independent clrsetbitsXX(), after double-checking that they're all in SoC-specific code operating on CPU registers and not actually trying to make an endian conversion.
This patch was created by running
sed -i -e 's/([cs][le][rt]bits)_le([136][624])/\1\2/g'
across the codebase and cleaning up formatting a bit.
Change-Id: I7fc3e736e5fe927da8960fdcd2aae607b62b5ff4 Signed-off-by: Julius Werner jwerner@chromium.org --- M payloads/libpayload/drivers/udc/chipidea.c M src/cpu/ti/am335x/gpio.c M src/include/device/mmio.h M src/mainboard/google/kahlee/mainboard.c M src/mainboard/google/nyan/mainboard.c M src/mainboard/google/nyan_big/mainboard.c M src/mainboard/google/nyan_blaze/mainboard.c M src/mainboard/google/oak/bootblock.c M src/mainboard/google/storm/cdp.c M src/mainboard/google/veyron/bootblock.c M src/mainboard/google/veyron_mickey/bootblock.c M src/mainboard/google/veyron_rialto/bootblock.c M src/soc/cavium/cn81xx/timer.c M src/soc/mediatek/common/ddp.c M src/soc/mediatek/common/dsi.c M src/soc/mediatek/common/gpio.c M src/soc/mediatek/common/mtcmos.c M src/soc/mediatek/common/spi.c M src/soc/mediatek/common/timer.c M src/soc/mediatek/common/usb.c M src/soc/mediatek/common/wdt.c M src/soc/mediatek/mt8173/ddp.c M src/soc/mediatek/mt8173/dramc_pi_basic_api.c M src/soc/mediatek/mt8173/dramc_pi_calibration_api.c M src/soc/mediatek/mt8173/dsi.c M src/soc/mediatek/mt8173/emi.c M src/soc/mediatek/mt8173/gpio_init.c M src/soc/mediatek/mt8173/pll.c M src/soc/mediatek/mt8173/pmic_wrap.c M src/soc/mediatek/mt8173/spi.c M src/soc/mediatek/mt8183/auxadc.c M src/soc/mediatek/mt8183/ddp.c M src/soc/mediatek/mt8183/dramc_init_setting.c M src/soc/mediatek/mt8183/dramc_pi_basic_api.c M src/soc/mediatek/mt8183/dramc_pi_calibration_api.c M src/soc/mediatek/mt8183/dsi.c M src/soc/mediatek/mt8183/emi.c M src/soc/mediatek/mt8183/gpio.c M src/soc/mediatek/mt8183/md_ctrl.c M src/soc/mediatek/mt8183/pll.c M src/soc/mediatek/mt8183/spi.c M src/soc/mediatek/mt8183/spm.c M src/soc/nvidia/tegra/usb.c M src/soc/nvidia/tegra124/clock.c M src/soc/nvidia/tegra124/dma.c M src/soc/nvidia/tegra124/include/soc/clock.h M src/soc/nvidia/tegra124/power.c M src/soc/nvidia/tegra124/sdram.c M src/soc/nvidia/tegra124/spi.c M src/soc/nvidia/tegra210/addressmap.c M src/soc/nvidia/tegra210/clock.c M src/soc/nvidia/tegra210/cpu.c M src/soc/nvidia/tegra210/dma.c M src/soc/nvidia/tegra210/include/soc/clock.h M src/soc/nvidia/tegra210/sdram.c M src/soc/nvidia/tegra210/spi.c M src/soc/qualcomm/ipq40xx/blsp.c M src/soc/qualcomm/ipq40xx/clock.c M src/soc/qualcomm/ipq40xx/include/soc/iomap.h M src/soc/qualcomm/ipq40xx/spi.c M src/soc/qualcomm/ipq806x/clock.c M src/soc/qualcomm/ipq806x/include/soc/iomap.h M src/soc/qualcomm/ipq806x/spi.c M src/soc/qualcomm/ipq806x/usb.c M src/soc/qualcomm/qcs405/blsp.c M src/soc/qualcomm/qcs405/clock.c M src/soc/qualcomm/qcs405/gpio.c M src/soc/qualcomm/qcs405/include/soc/iomap.h M src/soc/qualcomm/qcs405/spi.c M src/soc/qualcomm/qcs405/usb.c M src/soc/qualcomm/sc7180/gpio.c M src/soc/qualcomm/sdm845/clock.c M src/soc/qualcomm/sdm845/usb.c M src/soc/rockchip/common/edp.c M src/soc/rockchip/common/gpio.c M src/soc/rockchip/common/pwm.c M src/soc/rockchip/common/spi.c M src/soc/rockchip/common/vop.c M src/soc/rockchip/rk3288/hdmi.c M src/soc/rockchip/rk3288/sdram.c M src/soc/rockchip/rk3288/software_i2c.c M src/soc/rockchip/rk3288/tsadc.c M src/soc/rockchip/rk3399/clock.c M src/soc/rockchip/rk3399/saradc.c M src/soc/rockchip/rk3399/sdram.c M src/soc/rockchip/rk3399/tsadc.c M src/soc/rockchip/rk3399/usb.c M src/soc/samsung/exynos5250/clock.c M src/soc/samsung/exynos5250/clock_init.c M src/soc/samsung/exynos5250/dp-reg.c M src/soc/samsung/exynos5250/fb.c M src/soc/samsung/exynos5250/power.c M src/soc/samsung/exynos5250/spi.c M src/soc/samsung/exynos5250/usb.c M src/soc/samsung/exynos5420/clock.c M src/soc/samsung/exynos5420/clock_init.c M src/soc/samsung/exynos5420/dmc_init_ddr3.c M src/soc/samsung/exynos5420/power.c M src/soc/samsung/exynos5420/spi.c M src/soc/samsung/exynos5420/usb.c M src/soc/sifive/fu540/clock.c 101 files changed, 2,013 insertions(+), 2,014 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/37433/1
Hello ron minnich, Hung-Te Lin, build bot (Jenkins), Nico Huber, Philipp Hug,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37433
to look at the new patch set (#2).
Change subject: Change all clrsetbits_leXX() to clrsetbitsXX() ......................................................................
Change all clrsetbits_leXX() to clrsetbitsXX()
This patch changes all existing instances of clrsetbits_leXX() to the new endian-independent clrsetbitsXX(), after double-checking that they're all in SoC-specific code operating on CPU registers and not actually trying to make an endian conversion.
This patch was created by running
sed -i -e 's/([cs][le][rt]bits)_le([136][624])/\1\2/g'
across the codebase and cleaning up formatting a bit.
Change-Id: I7fc3e736e5fe927da8960fdcd2aae607b62b5ff4 Signed-off-by: Julius Werner jwerner@chromium.org --- M payloads/libpayload/drivers/udc/chipidea.c M src/arch/arm64/include/armv8/arch/mmio.h M src/cpu/ti/am335x/gpio.c M src/drivers/crb/tpm.c M src/include/device/mmio.h M src/mainboard/google/kahlee/mainboard.c M src/mainboard/google/nyan/mainboard.c M src/mainboard/google/nyan_big/mainboard.c M src/mainboard/google/nyan_blaze/mainboard.c M src/mainboard/google/oak/bootblock.c M src/mainboard/google/storm/cdp.c M src/mainboard/google/trogdor/mainboard.c M src/mainboard/google/veyron/bootblock.c M src/mainboard/google/veyron_mickey/bootblock.c M src/mainboard/google/veyron_rialto/bootblock.c M src/mainboard/sifive/hifive-unleashed/media.c M src/soc/amd/picasso/uart.c M src/soc/cavium/cn81xx/timer.c M src/soc/mediatek/common/ddp.c M src/soc/mediatek/common/dsi.c M src/soc/mediatek/common/gpio.c M src/soc/mediatek/common/mtcmos.c M src/soc/mediatek/common/spi.c M src/soc/mediatek/common/timer.c M src/soc/mediatek/common/usb.c M src/soc/mediatek/common/wdt.c M src/soc/mediatek/mt8173/ddp.c M src/soc/mediatek/mt8173/dramc_pi_basic_api.c M src/soc/mediatek/mt8173/dramc_pi_calibration_api.c M src/soc/mediatek/mt8173/dsi.c M src/soc/mediatek/mt8173/emi.c M src/soc/mediatek/mt8173/gpio_init.c M src/soc/mediatek/mt8173/pll.c M src/soc/mediatek/mt8173/pmic_wrap.c M src/soc/mediatek/mt8173/spi.c M src/soc/mediatek/mt8183/auxadc.c M src/soc/mediatek/mt8183/ddp.c M src/soc/mediatek/mt8183/dramc_init_setting.c M src/soc/mediatek/mt8183/dramc_pi_basic_api.c M src/soc/mediatek/mt8183/dramc_pi_calibration_api.c M src/soc/mediatek/mt8183/dsi.c M src/soc/mediatek/mt8183/emi.c M src/soc/mediatek/mt8183/gpio.c M src/soc/mediatek/mt8183/md_ctrl.c M src/soc/mediatek/mt8183/pll.c M src/soc/mediatek/mt8183/spi.c M src/soc/mediatek/mt8183/spm.c M src/soc/mediatek/mt8183/sspm.c M src/soc/nvidia/tegra/usb.c M src/soc/nvidia/tegra124/clock.c M src/soc/nvidia/tegra124/dma.c M src/soc/nvidia/tegra124/include/soc/clock.h M src/soc/nvidia/tegra124/power.c M src/soc/nvidia/tegra124/sdram.c M src/soc/nvidia/tegra124/spi.c M src/soc/nvidia/tegra210/addressmap.c M src/soc/nvidia/tegra210/clock.c M src/soc/nvidia/tegra210/cpu.c M src/soc/nvidia/tegra210/dma.c M src/soc/nvidia/tegra210/include/soc/clock.h M src/soc/nvidia/tegra210/sdram.c M src/soc/nvidia/tegra210/spi.c M src/soc/qualcomm/ipq40xx/blsp.c M src/soc/qualcomm/ipq40xx/clock.c M src/soc/qualcomm/ipq40xx/include/soc/iomap.h M src/soc/qualcomm/ipq40xx/spi.c M src/soc/qualcomm/ipq806x/clock.c M src/soc/qualcomm/ipq806x/include/soc/iomap.h M src/soc/qualcomm/ipq806x/spi.c M src/soc/qualcomm/ipq806x/usb.c M src/soc/qualcomm/qcs405/blsp.c M src/soc/qualcomm/qcs405/clock.c M src/soc/qualcomm/qcs405/gpio.c M src/soc/qualcomm/qcs405/include/soc/iomap.h M src/soc/qualcomm/qcs405/spi.c M src/soc/qualcomm/qcs405/usb.c M src/soc/qualcomm/sc7180/gpio.c M src/soc/qualcomm/sdm845/clock.c M src/soc/qualcomm/sdm845/usb.c M src/soc/rockchip/common/edp.c M src/soc/rockchip/common/gpio.c M src/soc/rockchip/common/pwm.c M src/soc/rockchip/common/spi.c M src/soc/rockchip/common/vop.c M src/soc/rockchip/rk3288/hdmi.c M src/soc/rockchip/rk3288/sdram.c M src/soc/rockchip/rk3288/software_i2c.c M src/soc/rockchip/rk3288/tsadc.c M src/soc/rockchip/rk3399/clock.c M src/soc/rockchip/rk3399/saradc.c M src/soc/rockchip/rk3399/sdram.c M src/soc/rockchip/rk3399/tsadc.c M src/soc/rockchip/rk3399/usb.c M src/soc/samsung/exynos5250/clock.c M src/soc/samsung/exynos5250/clock_init.c M src/soc/samsung/exynos5250/dp-reg.c M src/soc/samsung/exynos5250/fb.c M src/soc/samsung/exynos5250/power.c M src/soc/samsung/exynos5250/spi.c M src/soc/samsung/exynos5250/usb.c M src/soc/samsung/exynos5420/clock.c M src/soc/samsung/exynos5420/clock_init.c M src/soc/samsung/exynos5420/dmc_init_ddr3.c M src/soc/samsung/exynos5420/power.c M src/soc/samsung/exynos5420/spi.c M src/soc/samsung/exynos5420/usb.c M src/soc/sifive/fu540/clock.c M src/soc/sifive/fu540/spi.c 108 files changed, 2,022 insertions(+), 2,025 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/37433/2
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37433 )
Change subject: Change all clrsetbits_leXX() to clrsetbitsXX() ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37433 )
Change subject: Change all clrsetbits_leXX() to clrsetbitsXX() ......................................................................
Change all clrsetbits_leXX() to clrsetbitsXX()
This patch changes all existing instances of clrsetbits_leXX() to the new endian-independent clrsetbitsXX(), after double-checking that they're all in SoC-specific code operating on CPU registers and not actually trying to make an endian conversion.
This patch was created by running
sed -i -e 's/([cs][le][rt]bits)_le([136][624])/\1\2/g'
across the codebase and cleaning up formatting a bit.
Change-Id: I7fc3e736e5fe927da8960fdcd2aae607b62b5ff4 Signed-off-by: Julius Werner jwerner@chromium.org Reviewed-on: https://review.coreboot.org/c/coreboot/+/37433 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Hung-Te Lin hungte@chromium.org --- M payloads/libpayload/drivers/udc/chipidea.c M src/arch/arm64/include/armv8/arch/mmio.h M src/cpu/ti/am335x/gpio.c M src/drivers/crb/tpm.c M src/include/device/mmio.h M src/mainboard/google/kahlee/mainboard.c M src/mainboard/google/nyan/mainboard.c M src/mainboard/google/nyan_big/mainboard.c M src/mainboard/google/nyan_blaze/mainboard.c M src/mainboard/google/oak/bootblock.c M src/mainboard/google/storm/cdp.c M src/mainboard/google/trogdor/mainboard.c M src/mainboard/google/veyron/bootblock.c M src/mainboard/google/veyron_mickey/bootblock.c M src/mainboard/google/veyron_rialto/bootblock.c M src/mainboard/sifive/hifive-unleashed/media.c M src/soc/amd/picasso/uart.c M src/soc/cavium/cn81xx/timer.c M src/soc/mediatek/common/ddp.c M src/soc/mediatek/common/dsi.c M src/soc/mediatek/common/gpio.c M src/soc/mediatek/common/mtcmos.c M src/soc/mediatek/common/spi.c M src/soc/mediatek/common/timer.c M src/soc/mediatek/common/usb.c M src/soc/mediatek/common/wdt.c M src/soc/mediatek/mt8173/ddp.c M src/soc/mediatek/mt8173/dramc_pi_basic_api.c M src/soc/mediatek/mt8173/dramc_pi_calibration_api.c M src/soc/mediatek/mt8173/dsi.c M src/soc/mediatek/mt8173/emi.c M src/soc/mediatek/mt8173/gpio_init.c M src/soc/mediatek/mt8173/pll.c M src/soc/mediatek/mt8173/pmic_wrap.c M src/soc/mediatek/mt8173/spi.c M src/soc/mediatek/mt8183/auxadc.c M src/soc/mediatek/mt8183/ddp.c M src/soc/mediatek/mt8183/dramc_init_setting.c M src/soc/mediatek/mt8183/dramc_pi_basic_api.c M src/soc/mediatek/mt8183/dramc_pi_calibration_api.c M src/soc/mediatek/mt8183/dsi.c M src/soc/mediatek/mt8183/emi.c M src/soc/mediatek/mt8183/gpio.c M src/soc/mediatek/mt8183/md_ctrl.c M src/soc/mediatek/mt8183/pll.c M src/soc/mediatek/mt8183/spi.c M src/soc/mediatek/mt8183/spm.c M src/soc/mediatek/mt8183/sspm.c M src/soc/nvidia/tegra/usb.c M src/soc/nvidia/tegra124/clock.c M src/soc/nvidia/tegra124/dma.c M src/soc/nvidia/tegra124/include/soc/clock.h M src/soc/nvidia/tegra124/power.c M src/soc/nvidia/tegra124/sdram.c M src/soc/nvidia/tegra124/spi.c M src/soc/nvidia/tegra210/addressmap.c M src/soc/nvidia/tegra210/clock.c M src/soc/nvidia/tegra210/cpu.c M src/soc/nvidia/tegra210/dma.c M src/soc/nvidia/tegra210/include/soc/clock.h M src/soc/nvidia/tegra210/sdram.c M src/soc/nvidia/tegra210/spi.c M src/soc/qualcomm/ipq40xx/blsp.c M src/soc/qualcomm/ipq40xx/clock.c M src/soc/qualcomm/ipq40xx/include/soc/iomap.h M src/soc/qualcomm/ipq40xx/spi.c M src/soc/qualcomm/ipq806x/clock.c M src/soc/qualcomm/ipq806x/include/soc/iomap.h M src/soc/qualcomm/ipq806x/spi.c M src/soc/qualcomm/ipq806x/usb.c M src/soc/qualcomm/qcs405/blsp.c M src/soc/qualcomm/qcs405/clock.c M src/soc/qualcomm/qcs405/gpio.c M src/soc/qualcomm/qcs405/include/soc/iomap.h M src/soc/qualcomm/qcs405/spi.c M src/soc/qualcomm/qcs405/usb.c M src/soc/qualcomm/sc7180/gpio.c M src/soc/qualcomm/sdm845/clock.c M src/soc/qualcomm/sdm845/usb.c M src/soc/rockchip/common/edp.c M src/soc/rockchip/common/gpio.c M src/soc/rockchip/common/pwm.c M src/soc/rockchip/common/spi.c M src/soc/rockchip/common/vop.c M src/soc/rockchip/rk3288/hdmi.c M src/soc/rockchip/rk3288/sdram.c M src/soc/rockchip/rk3288/software_i2c.c M src/soc/rockchip/rk3288/tsadc.c M src/soc/rockchip/rk3399/clock.c M src/soc/rockchip/rk3399/saradc.c M src/soc/rockchip/rk3399/sdram.c M src/soc/rockchip/rk3399/tsadc.c M src/soc/rockchip/rk3399/usb.c M src/soc/samsung/exynos5250/clock.c M src/soc/samsung/exynos5250/clock_init.c M src/soc/samsung/exynos5250/dp-reg.c M src/soc/samsung/exynos5250/fb.c M src/soc/samsung/exynos5250/power.c M src/soc/samsung/exynos5250/spi.c M src/soc/samsung/exynos5250/usb.c M src/soc/samsung/exynos5420/clock.c M src/soc/samsung/exynos5420/clock_init.c M src/soc/samsung/exynos5420/dmc_init_ddr3.c M src/soc/samsung/exynos5420/power.c M src/soc/samsung/exynos5420/spi.c M src/soc/samsung/exynos5420/usb.c M src/soc/sifive/fu540/clock.c M src/soc/sifive/fu540/spi.c 108 files changed, 2,022 insertions(+), 2,025 deletions(-)
Approvals: build bot (Jenkins): Verified Hung-Te Lin: Looks good to me, approved
-
Hung-Te Lin (Code Review) -
Julius Werner (Code Review)
-
Patrick Georgi (Code Review)