Akshu Agrawal has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30726
Change subject: mb/google/kahlee/careena: Add 20ms delay to capture ......................................................................
mb/google/kahlee/careena: Add 20ms delay to capture
define wakeup-delay-ms to 20ms. This avoids the pop noise heard at the start of capture.
BUG=b:119926436 TEST=with kernel patch https://lore.kernel.org/patchwork/patch/1029806/ no pop sound heard at start of capture
Change-Id: I299a584ef2ba66d1e752515100cbe3919b2108f6 Signed-off-by: Akshu Agrawal akshu.agrawal@amd.com --- M src/mainboard/google/kahlee/variants/careena/devicetree.cb 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/30726/1
diff --git a/src/mainboard/google/kahlee/variants/careena/devicetree.cb b/src/mainboard/google/kahlee/variants/careena/devicetree.cb index 23253b2..5124e41 100644 --- a/src/mainboard/google/kahlee/variants/careena/devicetree.cb +++ b/src/mainboard/google/kahlee/variants/careena/devicetree.cb @@ -98,6 +98,7 @@ end #domain device mmio 0xfedc2000 on chip drivers/generic/adau7002 + register "wakeup_delay" = "20" device generic 0.0 on end end chip drivers/i2c/da7219
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30726 )
Change subject: mb/google/kahlee/careena: Add 20ms delay to capture ......................................................................
Patch Set 2: Code-Review+2
Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/30726 )
Change subject: mb/google/kahlee/careena: Add 20ms delay to capture ......................................................................
mb/google/kahlee/careena: Add 20ms delay to capture
define wakeup-delay-ms to 20ms. This avoids the pop noise heard at the start of capture.
BUG=b:119926436 TEST=with kernel patch https://lore.kernel.org/patchwork/patch/1029806/ no pop sound heard at start of capture
Change-Id: I299a584ef2ba66d1e752515100cbe3919b2108f6 Signed-off-by: Akshu Agrawal akshu.agrawal@amd.com Reviewed-on: https://review.coreboot.org/c/30726 Reviewed-by: Martin Roth martinroth@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/kahlee/variants/careena/devicetree.cb 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved
diff --git a/src/mainboard/google/kahlee/variants/careena/devicetree.cb b/src/mainboard/google/kahlee/variants/careena/devicetree.cb index 23253b2..5124e41 100644 --- a/src/mainboard/google/kahlee/variants/careena/devicetree.cb +++ b/src/mainboard/google/kahlee/variants/careena/devicetree.cb @@ -98,6 +98,7 @@ end #domain device mmio 0xfedc2000 on chip drivers/generic/adau7002 + register "wakeup_delay" = "20" device generic 0.0 on end end chip drivers/i2c/da7219
-
Akshu Agrawal (Code Review) -
Martin Roth (Code Review)