Hello Daniel Kurtz,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/30920
to review the following change.
Change subject: soc/amd/stoneyridge/gpio: Remove redundant definitions ......................................................................
soc/amd/stoneyridge/gpio: Remove redundant definitions
Thes are already defined identically ~20 lines above.
Signed-off-by: Daniel Kurtz djkurtz@chromium.org
BUG=none BRANCH=none TEST=compile
Change-Id: Ic3faeb97788b2b524345cdbfb368e98d43bac075 --- M src/soc/amd/stoneyridge/include/soc/gpio.h 1 file changed, 0 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/30920/1
diff --git a/src/soc/amd/stoneyridge/include/soc/gpio.h b/src/soc/amd/stoneyridge/include/soc/gpio.h index 5609ca6..04eda49 100644 --- a/src/soc/amd/stoneyridge/include/soc/gpio.h +++ b/src/soc/amd/stoneyridge/include/soc/gpio.h @@ -474,11 +474,6 @@ #define GPIO_IN_200mS (13 | GPIO_TIMEBASE_15560uS) #define GPIO_IN_500mS (8 | GPIO_TIMEBASE_62440uS)
-#define GPIO_IN_NO_DEBOUNCE (DEBOUNCE_NONE << IN_GLITCH_SHIFT) -#define GPIO_IN_PRESERVE_LOW_GLITCH (GLITCH_LOW << IN_GLITCH_SHIFT) -#define GPIO_IN_PRESERVE_HIGH_GLITCH (GLITCH_HIGH << IN_GLITCH_SHIFT) -#define GPIO_IN_REMOVE_GLITCH (GLITCH_NONE << IN_GLITCH_SHIFT) - #define GPIO_EVENT_INT_STATUS GPIO_INT_STATUS_EN #define GPIO_EVENT_INT_DELIVER GPIO_INT_DELIVERY_EN #define GPIO_EVENT_INT_STATUS_DELIVER (GPIO_INT_STATUS_EN | \
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30920 )
Change subject: soc/amd/stoneyridge/gpio: Remove redundant definitions ......................................................................
Patch Set 1: Code-Review+2
Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/30920 )
Change subject: soc/amd/stoneyridge/gpio: Remove redundant definitions ......................................................................
soc/amd/stoneyridge/gpio: Remove redundant definitions
Thes are already defined identically ~20 lines above.
Signed-off-by: Daniel Kurtz djkurtz@chromium.org
BUG=none BRANCH=none TEST=compile
Change-Id: Ic3faeb97788b2b524345cdbfb368e98d43bac075 Reviewed-on: https://review.coreboot.org/c/30920 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Martin Roth martinroth@google.com --- M src/soc/amd/stoneyridge/include/soc/gpio.h 1 file changed, 0 insertions(+), 5 deletions(-)
Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved
diff --git a/src/soc/amd/stoneyridge/include/soc/gpio.h b/src/soc/amd/stoneyridge/include/soc/gpio.h index 5609ca6..04eda49 100644 --- a/src/soc/amd/stoneyridge/include/soc/gpio.h +++ b/src/soc/amd/stoneyridge/include/soc/gpio.h @@ -474,11 +474,6 @@ #define GPIO_IN_200mS (13 | GPIO_TIMEBASE_15560uS) #define GPIO_IN_500mS (8 | GPIO_TIMEBASE_62440uS)
-#define GPIO_IN_NO_DEBOUNCE (DEBOUNCE_NONE << IN_GLITCH_SHIFT) -#define GPIO_IN_PRESERVE_LOW_GLITCH (GLITCH_LOW << IN_GLITCH_SHIFT) -#define GPIO_IN_PRESERVE_HIGH_GLITCH (GLITCH_HIGH << IN_GLITCH_SHIFT) -#define GPIO_IN_REMOVE_GLITCH (GLITCH_NONE << IN_GLITCH_SHIFT) - #define GPIO_EVENT_INT_STATUS GPIO_INT_STATUS_EN #define GPIO_EVENT_INT_DELIVER GPIO_INT_DELIVERY_EN #define GPIO_EVENT_INT_STATUS_DELIVER (GPIO_INT_STATUS_EN | \
-
Daniel Kurtz (Code Review) -
Martin Roth (Code Review)