Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31008
Change subject: mb/purism/librem_skl: adjust CBFS_SIZE ......................................................................
mb/purism/librem_skl: adjust CBFS_SIZE
Adjust default CBFS_SIZE to match that used in configs for building
Change-Id: Ibe1312560a923dcdefb8af52a721ab76c0b08a2e Signed-off-by: Matt DeVillier matt.devillier@puri.sm --- M src/mainboard/purism/librem_skl/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/31008/1
diff --git a/src/mainboard/purism/librem_skl/Kconfig b/src/mainboard/purism/librem_skl/Kconfig index 224779d..0c138a6 100644 --- a/src/mainboard/purism/librem_skl/Kconfig +++ b/src/mainboard/purism/librem_skl/Kconfig @@ -77,6 +77,6 @@
config CBFS_SIZE hex - default 0x5c0000 + default 0xe00000
endif
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31008 )
Change subject: mb/purism/librem_skl: adjust CBFS_SIZE ......................................................................
Patch Set 1: Code-Review+2
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31008 )
Change subject: mb/purism/librem_skl: adjust CBFS_SIZE ......................................................................
Patch Set 1:
How big is the BIOS region on units that shipped with proper ME firmware? Are they safe?
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31008 )
Change subject: mb/purism/librem_skl: adjust CBFS_SIZE ......................................................................
Patch Set 1:
How big is the BIOS region on units that shipped with proper ME
firmware? Are they safe?
all Skylake-based devices shipped with coreboot and a shrunk/neutered ME, AFAIK
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31008 )
Change subject: mb/purism/librem_skl: adjust CBFS_SIZE ......................................................................
mb/purism/librem_skl: adjust CBFS_SIZE
Adjust default CBFS_SIZE to match that used in configs for building
Change-Id: Ibe1312560a923dcdefb8af52a721ab76c0b08a2e Signed-off-by: Matt DeVillier matt.devillier@puri.sm Reviewed-on: https://review.coreboot.org/c/31008 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/purism/librem_skl/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/mainboard/purism/librem_skl/Kconfig b/src/mainboard/purism/librem_skl/Kconfig index 224779d..0c138a6 100644 --- a/src/mainboard/purism/librem_skl/Kconfig +++ b/src/mainboard/purism/librem_skl/Kconfig @@ -77,6 +77,6 @@
config CBFS_SIZE hex - default 0x5c0000 + default 0xe00000
endif
-
Angel Pons (Code Review) -
Matt DeVillier (Code Review)
-
Nico Huber (Code Review)
-
Patrick Georgi (Code Review)