Attention is currently required from: Yi Chou.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79800?usp=email )
Change subject: libpayload: Move back the ttb_buffer section ......................................................................
Patch Set 6:
(3 comments)
File payloads/libpayload/arch/arm64/mmu.c:
https://review.coreboot.org/c/coreboot/+/79800/comment/ae36ae44_99b49435 : PS6, Line 45: ChormeOS's typo
https://review.coreboot.org/c/coreboot/+/79800/comment/6abc0516_335e9964 : PS6, Line 46: to please `please do`
https://review.coreboot.org/c/coreboot/+/79800/comment/55270c49_ac605f82 : PS6, Line 47: * Please contact: jwerner@chromium.org or yich@chromium.org */ Sorry, my review comes a bit late, but why don't we change this to `__attribute__((__section__(".bss.ttb_buffer")))`, which I think should also work without `-fdata-sections`? Also, the explicit section name allows people to rename the variable without breaking what we are doing (unless there's another new variable named `ttb_buffer`).