Attention is currently required from: Yi Chou.
3 comments:
File payloads/libpayload/arch/arm64/mmu.c:
Patch Set #6, Line 45: ChormeOS's
typo
Patch Set #6, Line 46: to please
`please do`
Patch Set #6, Line 47: * Please contact: jwerner@chromium.org or yich@chromium.org */
Sorry, my review comes a bit late, but why don't we change this to `__attribute__((__section__(".bss.ttb_buffer")))`, which I think should also work without `-fdata-sections`? Also, the explicit section name allows people to rename the variable without breaking what we are doing (unless there's another new variable named `ttb_buffer`).
To view, visit change 79800. To unsubscribe, or for help writing mail filters, visit settings.