Shreesh Chhabbi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42483 )
Change subject: mainboard/volteer: Enable SaGv ......................................................................
mainboard/volteer: Enable SaGv
Change-Id: I1bce3b9f837fb19ba5a20ae31750a73474a86788 Signed-off-by: Shreesh Chhabbi shreesh.chhabbi@intel.com --- M src/mainboard/google/volteer/variants/baseboard/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/42483/1
diff --git a/src/mainboard/google/volteer/variants/baseboard/devicetree.cb b/src/mainboard/google/volteer/variants/baseboard/devicetree.cb index 8cd926c..6dbc415 100644 --- a/src/mainboard/google/volteer/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/volteer/variants/baseboard/devicetree.cb @@ -36,7 +36,7 @@ register "pmc_gpe0_dw2" = "GPP_E"
# FSP configuration - register "SaGv" = "SaGv_Disabled" + register "SaGv" = "SaGv_Enabled" register "SmbusEnable" = "0"
register "usb2_ports[0]" = "USB2_PORT_MID(OC_SKIP)" # Type-A Port A0
Shreesh Chhabbi has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/42483 )
Change subject: mainboard/volteer: Enable SaGv ......................................................................
mainboard/volteer: Enable SaGv
BUG=b/159198381 TEST=Flashed image on Volteer Proto 2 SKU 2 and booted to Chrome OS
Change-Id: I1bce3b9f837fb19ba5a20ae31750a73474a86788 Signed-off-by: Shreesh Chhabbi shreesh.chhabbi@intel.com --- M src/mainboard/google/volteer/variants/baseboard/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/42483/2
Shreesh Chhabbi has uploaded a new patch set (#3) to the change originally created by Shreesh Chhabbi. ( https://review.coreboot.org/c/coreboot/+/42483 )
Change subject: mainboard/volteer: Enable SaGv ......................................................................
mainboard/volteer: Enable SaGv
BUG=b:159198381 TEST=Flashed image on Volteer Proto 2 SKU 2 and booted to Chrome OS
Change-Id: I1bce3b9f837fb19ba5a20ae31750a73474a86788 Signed-off-by: Shreesh Chhabbi shreesh.chhabbi@intel.com --- M src/mainboard/google/volteer/variants/baseboard/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/42483/3
Shreesh Chhabbi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42483 )
Change subject: mainboard/volteer: Enable SaGv ......................................................................
Patch Set 3: Code-Review+1
Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42483 )
Change subject: mainboard/volteer: Enable SaGv ......................................................................
Patch Set 3:
I saw hangs during training when I tried this last time, but hopefully with the flex ratio change it will work better. I'd feel better if Alex tried it on his devices first...
Shreesh Chhabbi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42483 )
Change subject: mainboard/volteer: Enable SaGv ......................................................................
Patch Set 3:
Patch Set 3:
I saw hangs during training when I tried this last time, but hopefully with the flex ratio change it will work better. I'd feel better if Alex tried it on his devices first...
Sure Duncan. I verified 2 cold boots on one of the SKU 2 boards.
Hello build bot (Jenkins), Furquan Shaikh, Wonkyu Kim, Caveh Jalali, Ravishankar Sarawadi, Duncan Laurie, Alex Levin, Raj Astekar, Srinidhi N Kaushik, Shreesh Chhabbi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42483
to look at the new patch set (#5).
Change subject: mainboard/volteer: Enable SaGv for volteer2, delbin & voxel ......................................................................
mainboard/volteer: Enable SaGv for volteer2, delbin & voxel
SaGv needs to be enabled for only QS. On ES2, we are seeing system instability.
BUG=b:159198381 TEST=Flashed image on Volteer Proto 2 SKU 2 and booted to Chrome OS
Change-Id: I1bce3b9f837fb19ba5a20ae31750a73474a86788 Signed-off-by: Shreesh Chhabbi shreesh.chhabbi@intel.com --- M src/mainboard/google/volteer/variants/delbin/overridetree.cb M src/mainboard/google/volteer/variants/volteer2/overridetree.cb M src/mainboard/google/volteer/variants/voxel/overridetree.cb 3 files changed, 3 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/42483/5
Hello build bot (Jenkins), Furquan Shaikh, Wonkyu Kim, Caveh Jalali, Ravishankar Sarawadi, Duncan Laurie, Alex Levin, Raj Astekar, Srinidhi N Kaushik, Shreesh Chhabbi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42483
to look at the new patch set (#6).
Change subject: mainboard/volteer: Enable SaGv for volteer2, delbin & voxel ......................................................................
mainboard/volteer: Enable SaGv for volteer2, delbin & voxel
SaGv needs to be enabled for only QS. On ES2, we are seeing system instability.
BUG=b:159198381 TEST=Tested for boot. Power and performance tests were run with volteer2 with qs setup. System showed stability. Testing on delbin is pending.
Change-Id: I1bce3b9f837fb19ba5a20ae31750a73474a86788 Signed-off-by: Shreesh Chhabbi shreesh.chhabbi@intel.com --- M src/mainboard/google/volteer/variants/delbin/overridetree.cb M src/mainboard/google/volteer/variants/volteer2/overridetree.cb M src/mainboard/google/volteer/variants/voxel/overridetree.cb 3 files changed, 3 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/42483/6
Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42483 )
Change subject: mainboard/volteer: Enable SaGv for volteer2, delbin & voxel ......................................................................
Patch Set 6: Code-Review+1
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42483 )
Change subject: mainboard/volteer: Enable SaGv for volteer2, delbin & voxel ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42483/6/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/delbin/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/42483/6/src/mainboard/google/voltee... PS6, Line 2: register "SaGv" = "SaGv_Enabled" Just a thought: It might be better to set register "SaGv" = "SaGv_Enabled" in baseboard/devicetree.cb and add register "SaGv" = "SaGv_Disabled" in variants/*/overridetree.cb for all variants that are not yet ready to enable this.
When a variant is ready to enable this param, they just need to drop register "SaGv" = "SaGv_Disabled" from their overridetree.cb. Eventually, all overridetree.cb files would be free of this setting and only baseboard/devicetree.cb would have the enabling.
Shreesh Chhabbi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42483 )
Change subject: mainboard/volteer: Enable SaGv for volteer2, delbin & voxel ......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42483/6/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/delbin/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/42483/6/src/mainboard/google/voltee... PS6, Line 2: register "SaGv" = "SaGv_Enabled"
Just a thought: It might be better to set register "SaGv" = "SaGv_Enabled" in baseboard/devicetree. […]
Ack
Hello build bot (Jenkins), Furquan Shaikh, Wonkyu Kim, Caveh Jalali, Ravishankar Sarawadi, Duncan Laurie, Alex Levin, Raj Astekar, Srinidhi N Kaushik, Shreesh Chhabbi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42483
to look at the new patch set (#8).
Change subject: mainboard/volteer: Enable SaGv for volteer2, delbin & voxel ......................................................................
mainboard/volteer: Enable SaGv for volteer2, delbin & voxel
SaGv needs to be enabled for only QS. On ES2, we are seeing system instability.
BUG=b:159198381 TEST=Tested for boot. Power and performance tests were run with volteer2 with qs setup. System showed stability. Testing on delbin is pending.
Change-Id: I1bce3b9f837fb19ba5a20ae31750a73474a86788 Signed-off-by: Shreesh Chhabbi shreesh.chhabbi@intel.com --- M src/mainboard/google/volteer/variants/baseboard/devicetree.cb M src/mainboard/google/volteer/variants/delbin/overridetree.cb M src/mainboard/google/volteer/variants/halvor/overridetree.cb M src/mainboard/google/volteer/variants/malefor/overridetree.cb M src/mainboard/google/volteer/variants/terrador/overridetree.cb M src/mainboard/google/volteer/variants/trondo/overridetree.cb M src/mainboard/google/volteer/variants/volteer/overridetree.cb A src/mainboard/intel/tglrvp/spd/Samsung-K4UBE3D4AA-MGCL.spd-old.hex 8 files changed, 41 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/42483/8
Hello build bot (Jenkins), Furquan Shaikh, Wonkyu Kim, Caveh Jalali, Ravishankar Sarawadi, Duncan Laurie, Alex Levin, Raj Astekar, Srinidhi N Kaushik, Shreesh Chhabbi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42483
to look at the new patch set (#9).
Change subject: mainboard/volteer: Enable SaGv for volteer2, delbin & voxel ......................................................................
mainboard/volteer: Enable SaGv for volteer2, delbin & voxel
SaGv needs to be enabled for only QS. On ES2, we are seeing system instability.
BUG=b:159198381 TEST=Tested for boot. Power and performance tests were run with volteer2 with qs setup. System showed stability. Testing on delbin is pending.
Change-Id: I1bce3b9f837fb19ba5a20ae31750a73474a86788 Signed-off-by: Shreesh Chhabbi shreesh.chhabbi@intel.com --- M src/mainboard/google/volteer/variants/baseboard/devicetree.cb M src/mainboard/google/volteer/variants/delbin/overridetree.cb M src/mainboard/google/volteer/variants/halvor/overridetree.cb M src/mainboard/google/volteer/variants/malefor/overridetree.cb M src/mainboard/google/volteer/variants/terrador/overridetree.cb M src/mainboard/google/volteer/variants/trondo/overridetree.cb M src/mainboard/google/volteer/variants/volteer/overridetree.cb 7 files changed, 9 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/42483/9
Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42483 )
Change subject: mainboard/volteer: Enable SaGv for volteer2, delbin & voxel ......................................................................
Patch Set 9: Code-Review+2
Hello build bot (Jenkins), Furquan Shaikh, Wonkyu Kim, Caveh Jalali, Ravishankar Sarawadi, Duncan Laurie, Alex Levin, Raj Astekar, Srinidhi N Kaushik, Shreesh Chhabbi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42483
to look at the new patch set (#10).
Change subject: mainboard/volteer: Enable SaGv for volteer2, delbin & voxel ......................................................................
mainboard/volteer: Enable SaGv for volteer2, delbin & voxel
SaGv needs to be enabled for only QS. On ES2, we are seeing system instability.
BUG=b:159198381 TEST=Tested for boot. Power and performance tests were run with volteer2 with qs setup. System showed stability. Tested for boot stability on on delbin.
Change-Id: I1bce3b9f837fb19ba5a20ae31750a73474a86788 Signed-off-by: Shreesh Chhabbi shreesh.chhabbi@intel.com --- M src/mainboard/google/volteer/variants/baseboard/devicetree.cb M src/mainboard/google/volteer/variants/delbin/overridetree.cb M src/mainboard/google/volteer/variants/halvor/overridetree.cb M src/mainboard/google/volteer/variants/malefor/overridetree.cb M src/mainboard/google/volteer/variants/terrador/overridetree.cb M src/mainboard/google/volteer/variants/trondo/overridetree.cb M src/mainboard/google/volteer/variants/volteer/overridetree.cb 7 files changed, 9 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/42483/10
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42483 )
Change subject: mainboard/volteer: Enable SaGv for volteer2, delbin & voxel ......................................................................
mainboard/volteer: Enable SaGv for volteer2, delbin & voxel
SaGv needs to be enabled for only QS. On ES2, we are seeing system instability.
BUG=b:159198381 TEST=Tested for boot. Power and performance tests were run with volteer2 with qs setup. System showed stability. Tested for boot stability on on delbin.
Change-Id: I1bce3b9f837fb19ba5a20ae31750a73474a86788 Signed-off-by: Shreesh Chhabbi shreesh.chhabbi@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/42483 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Caveh Jalali caveh@chromium.org --- M src/mainboard/google/volteer/variants/baseboard/devicetree.cb M src/mainboard/google/volteer/variants/delbin/overridetree.cb M src/mainboard/google/volteer/variants/halvor/overridetree.cb M src/mainboard/google/volteer/variants/malefor/overridetree.cb M src/mainboard/google/volteer/variants/terrador/overridetree.cb M src/mainboard/google/volteer/variants/trondo/overridetree.cb M src/mainboard/google/volteer/variants/volteer/overridetree.cb 7 files changed, 9 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Caveh Jalali: Looks good to me, approved
diff --git a/src/mainboard/google/volteer/variants/baseboard/devicetree.cb b/src/mainboard/google/volteer/variants/baseboard/devicetree.cb index 322389d..18bfcc4 100644 --- a/src/mainboard/google/volteer/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/volteer/variants/baseboard/devicetree.cb @@ -47,7 +47,7 @@ register "HeciEnabled" = "1"
# FSP configuration - register "SaGv" = "SaGv_Disabled" + register "SaGv" = "SaGv_Enabled" register "SmbusEnable" = "0"
register "usb2_ports[0]" = "USB2_PORT_MID(OC_SKIP)" # Type-A Port A0 diff --git a/src/mainboard/google/volteer/variants/delbin/overridetree.cb b/src/mainboard/google/volteer/variants/delbin/overridetree.cb index 32204c5..9b5ae62 100644 --- a/src/mainboard/google/volteer/variants/delbin/overridetree.cb +++ b/src/mainboard/google/volteer/variants/delbin/overridetree.cb @@ -1,5 +1,4 @@ chip soc/intel/tigerlake - device domain 0 on end
diff --git a/src/mainboard/google/volteer/variants/halvor/overridetree.cb b/src/mainboard/google/volteer/variants/halvor/overridetree.cb index e53132a..12e059c 100644 --- a/src/mainboard/google/volteer/variants/halvor/overridetree.cb +++ b/src/mainboard/google/volteer/variants/halvor/overridetree.cb @@ -15,6 +15,8 @@ register "usb3_ports[2]" = "USB3_PORT_DEFAULT(OC2)" # Type-A / Type-C Port 2 register "usb3_ports[3]" = "USB3_PORT_EMPTY" # Type-A / Type-C Not Used
+ register "SaGv" = "SaGv_Disabled" + device domain 0 on device pci 15.0 on chip drivers/i2c/generic diff --git a/src/mainboard/google/volteer/variants/malefor/overridetree.cb b/src/mainboard/google/volteer/variants/malefor/overridetree.cb index b2a658c..c84ed83 100644 --- a/src/mainboard/google/volteer/variants/malefor/overridetree.cb +++ b/src/mainboard/google/volteer/variants/malefor/overridetree.cb @@ -17,6 +17,8 @@ register "usb3_ports[2]" = "USB3_PORT_EMPTY" # Type-A / Type-C Not Used register "usb3_ports[3]" = "USB3_PORT_EMPTY" # Type-A / Type-C Not Used
+ register "SaGv" = "SaGv_Disabled" + # I2C Port Config register "SerialIoI2cMode" = "{ [PchSerialIoIndexI2C0] = PchSerialIoPci, diff --git a/src/mainboard/google/volteer/variants/terrador/overridetree.cb b/src/mainboard/google/volteer/variants/terrador/overridetree.cb index 871ec24..c1c386a 100644 --- a/src/mainboard/google/volteer/variants/terrador/overridetree.cb +++ b/src/mainboard/google/volteer/variants/terrador/overridetree.cb @@ -17,6 +17,8 @@ register "usb3_ports[2]" = "USB3_PORT_EMPTY" # Type-A / Type-C Not Used register "usb3_ports[3]" = "USB3_PORT_EMPTY" # Type-A / Type-C Not Used
+ register "SaGv" = "SaGv_Disabled" + device domain 0 on device pci 15.0 on chip drivers/i2c/generic diff --git a/src/mainboard/google/volteer/variants/trondo/overridetree.cb b/src/mainboard/google/volteer/variants/trondo/overridetree.cb index 4bff10d..0932b64 100644 --- a/src/mainboard/google/volteer/variants/trondo/overridetree.cb +++ b/src/mainboard/google/volteer/variants/trondo/overridetree.cb @@ -1,4 +1,5 @@ chip soc/intel/tigerlake + register "SaGv" = "SaGv_Disabled" device domain 0 on device pci 15.1 on chip drivers/i2c/hid diff --git a/src/mainboard/google/volteer/variants/volteer/overridetree.cb b/src/mainboard/google/volteer/variants/volteer/overridetree.cb index 404b257..0944765 100644 --- a/src/mainboard/google/volteer/variants/volteer/overridetree.cb +++ b/src/mainboard/google/volteer/variants/volteer/overridetree.cb @@ -1,4 +1,5 @@ chip soc/intel/tigerlake + register "SaGv" = "SaGv_Disabled" device domain 0 on device pci 15.0 on chip drivers/i2c/generic
-
Caveh Jalali (Code Review) -
Duncan Laurie (Code Review)
-
Furquan Shaikh (Code Review)
-
Patrick Georgi (Code Review)
-
Shreesh Chhabbi (Code Review)
-
Wonkyu Kim (Code Review)