Xinxiong Xu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43320 )
Change subject: mb/google/kukui: Add new configs 'Cerise' and 'Stern' ......................................................................
mb/google/kukui: Add new configs 'Cerise' and 'Stern'
New boards introduced to Kukui family.
BUG=None TEST=make # select Cerise and Stern
Change-Id: I5841d57c0891d5191dd96097b90da889855b56c8 --- M src/mainboard/google/kukui/Kconfig M src/mainboard/google/kukui/Kconfig.name 2 files changed, 10 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/43320/1
diff --git a/src/mainboard/google/kukui/Kconfig b/src/mainboard/google/kukui/Kconfig index 4c8ebbf..7a1990e 100644 --- a/src/mainboard/google/kukui/Kconfig +++ b/src/mainboard/google/kukui/Kconfig @@ -47,6 +47,8 @@ default "Juniper" if BOARD_GOOGLE_JUNIPER default "Kappa" if BOARD_GOOGLE_KAPPA default "Damu" if BOARD_GOOGLE_DAMU + default "Cerise" if BOARD_GOOGLE_CERISE + default "Stern" if BOARD_GOOGLE_STERN
config DRIVER_TPM_SPI_BUS hex diff --git a/src/mainboard/google/kukui/Kconfig.name b/src/mainboard/google/kukui/Kconfig.name index 4b12034..22130e5 100644 --- a/src/mainboard/google/kukui/Kconfig.name +++ b/src/mainboard/google/kukui/Kconfig.name @@ -35,3 +35,11 @@ config BOARD_GOOGLE_DAMU bool "-> Damu" select BOARD_GOOGLE_KUKUI_COMMON + +config BOARD_GOOGLE_CERISE + bool "-> Cerise" + select BOARD_GOOGLE_KUKUI_COMMON + +config BOARD_GOOGLE_STERN + bool "-> Stern" + select BOARD_GOOGLE_KUKUI_COMMON
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43320
to look at the new patch set (#2).
Change subject: mb/google/kukui: Add new configs 'Cerise' and 'Stern' ......................................................................
mb/google/kukui: Add new configs 'Cerise' and 'Stern'
New boards introduced to Kukui family.
BUG=None TEST=make # select Cerise and Stern
Change-Id: I5841d57c0891d5191dd96097b90da889855b56c8 Signed-off-by: xuxinxiong xuxinxiong@huaqin.corp-partner.google.com --- M src/mainboard/google/kukui/Kconfig M src/mainboard/google/kukui/Kconfig.name 2 files changed, 10 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/43320/2
Zhaoyou Hong has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43320 )
Change subject: mb/google/kukui: Add new configs 'Cerise' and 'Stern' ......................................................................
Set Ready For Review
Chen-Tsung Hsieh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43320 )
Change subject: mb/google/kukui: Add new configs 'Cerise' and 'Stern' ......................................................................
Patch Set 3:
(1 comment)
This change is ready for review.
https://review.coreboot.org/c/coreboot/+/43320/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43320/3//COMMIT_MSG@12 PS3, Line 12: TEST=make # select Cerise and Stern Please add BRANCH=kukui
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43320 )
Change subject: mb/google/kukui: Add new configs 'Cerise' and 'Stern' ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43320/3/src/mainboard/google/kukui/... File src/mainboard/google/kukui/Kconfig:
https://review.coreboot.org/c/coreboot/+/43320/3/src/mainboard/google/kukui/... PS3, Line 32: DRIVER_ANALOGIX_ANX7625 Please add your boards here if you're also using ANX7625.
Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43320 )
Change subject: mb/google/kukui: Add new configs 'Cerise' and 'Stern' ......................................................................
Patch Set 3:
Hi Hash (Zhaoyou),
If the CL is not created by you then please review CLs from your team firstly. And basically we will only review the CL until +1 from you. Thanks.
Zhaoyou Hong has uploaded a new patch set (#4) to the change originally created by Xinxiong Xu. ( https://review.coreboot.org/c/coreboot/+/43320 )
Change subject: mb/google/kukui: Add new configs 'Cerise' and 'Stern' ......................................................................
mb/google/kukui: Add new configs 'Cerise' and 'Stern'
New boards introduced to Kukui family.
BUG=b:160854400 BRANCH=kukui TEST=make # select Cerise and Stern
Change-Id: I5841d57c0891d5191dd96097b90da889855b56c8 Signed-off-by: xuxinxiong xuxinxiong@huaqin.corp-partner.google.com --- M src/mainboard/google/kukui/Kconfig M src/mainboard/google/kukui/Kconfig.name 2 files changed, 10 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/43320/4
Zhaoyou Hong has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43320 )
Change subject: mb/google/kukui: Add new configs 'Cerise' and 'Stern' ......................................................................
Patch Set 4:
Patch Set 3:
Hi Hash (Zhaoyou),
If the CL is not created by you then please review CLs from your team firstly. And basically we will only review the CL until +1 from you. Thanks.
Got it. Thank you.
Hello Hung-Te Lin, build bot (Jenkins), Chen-Tsung Hsieh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43320
to look at the new patch set (#5).
Change subject: mb/google/kukui: Add new configs 'Cerise' and 'Stern' ......................................................................
mb/google/kukui: Add new configs 'Cerise' and 'Stern'
New boards introduced to Kukui family.
BUG=None TEST=make # select Cerise and Stern
Change-Id: I5841d57c0891d5191dd96097b90da889855b56c8 Signed-off-by: xuxinxiong xuxinxiong@huaqin.corp-partner.google.com --- M src/mainboard/google/kukui/Kconfig M src/mainboard/google/kukui/Kconfig.name 2 files changed, 11 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/43320/5
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43320 )
Change subject: mb/google/kukui: Add new configs 'Cerise' and 'Stern' ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/43320/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43320/5//COMMIT_MSG@11 PS5, Line 11: None Do you have a bug from project tracker? if yes please state it here
https://review.coreboot.org/c/coreboot/+/43320/5//COMMIT_MSG@13 PS5, Line 13: BRANCH=kukui
Hello Hung-Te Lin, build bot (Jenkins), Chen-Tsung Hsieh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43320
to look at the new patch set (#6).
Change subject: mb/google/kukui: Add new configs 'Cerise' and 'Stern' ......................................................................
mb/google/kukui: Add new configs 'Cerise' and 'Stern'
New boards introduced to Kukui family.
BUG=b:160854400 TEST=make # select Cerise and Stern BRANCH=kukui
Change-Id: I5841d57c0891d5191dd96097b90da889855b56c8 Signed-off-by: xuxinxiong xuxinxiong@huaqin.corp-partner.google.com --- M src/mainboard/google/kukui/Kconfig M src/mainboard/google/kukui/Kconfig.name 2 files changed, 11 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/43320/6
Xinxiong Xu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43320 )
Change subject: mb/google/kukui: Add new configs 'Cerise' and 'Stern' ......................................................................
Patch Set 6:
(2 comments)
The BUG ID and BRANCH had been added!
https://review.coreboot.org/c/coreboot/+/43320/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43320/5//COMMIT_MSG@11 PS5, Line 11: None
Do you have a bug from project tracker? if yes please state it here
Bug ID had been updated!
https://review.coreboot.org/c/coreboot/+/43320/5//COMMIT_MSG@13 PS5, Line 13:
BRANCH=kukui
BRANCH had been added!
Zhaoyou Hong has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43320 )
Change subject: mb/google/kukui: Add new configs 'Cerise' and 'Stern' ......................................................................
Patch Set 6: Code-Review+1
LGTM
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43320 )
Change subject: mb/google/kukui: Add new configs 'Cerise' and 'Stern' ......................................................................
Patch Set 6: Code-Review+2
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43320 )
Change subject: mb/google/kukui: Add new configs 'Cerise' and 'Stern' ......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/c/coreboot/+/43320/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43320/3//COMMIT_MSG@12 PS3, Line 12: TEST=make # select Cerise and Stern
Please add BRANCH=kukui
Ack
https://review.coreboot.org/c/coreboot/+/43320/3/src/mainboard/google/kukui/... File src/mainboard/google/kukui/Kconfig:
https://review.coreboot.org/c/coreboot/+/43320/3/src/mainboard/google/kukui/... PS3, Line 32: DRIVER_ANALOGIX_ANX7625
Please add your boards here if you're also using ANX7625.
Ack
Chen-Tsung Hsieh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43320 )
Change subject: mb/google/kukui: Add new configs 'Cerise' and 'Stern' ......................................................................
Patch Set 6: Code-Review+1
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43320 )
Change subject: mb/google/kukui: Add new configs 'Cerise' and 'Stern' ......................................................................
mb/google/kukui: Add new configs 'Cerise' and 'Stern'
New boards introduced to Kukui family.
BUG=b:160854400 TEST=make # select Cerise and Stern BRANCH=kukui
Change-Id: I5841d57c0891d5191dd96097b90da889855b56c8 Signed-off-by: xuxinxiong xuxinxiong@huaqin.corp-partner.google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/43320 Reviewed-by: Zhaoyou Hong hongzhaoyou@huaqin.corp-partner.google.com Reviewed-by: Hung-Te Lin hungte@chromium.org Reviewed-by: Chen-Tsung Hsieh chentsung@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/kukui/Kconfig M src/mainboard/google/kukui/Kconfig.name 2 files changed, 11 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Hung-Te Lin: Looks good to me, approved Chen-Tsung Hsieh: Looks good to me, but someone else must approve Zhaoyou Hong: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/kukui/Kconfig b/src/mainboard/google/kukui/Kconfig index 4c8ebbf..fa76796 100644 --- a/src/mainboard/google/kukui/Kconfig +++ b/src/mainboard/google/kukui/Kconfig @@ -29,7 +29,7 @@ select MAINBOARD_FORCE_NATIVE_VGA_INIT select HAVE_LINEAR_FRAMEBUFFER select DRIVER_PARADE_PS8640 if BOARD_GOOGLE_JACUZZI - select DRIVER_ANALOGIX_ANX7625 if BOARD_GOOGLE_JUNIPER || BOARD_GOOGLE_DAMU || BOARD_GOOGLE_KAPPA + select DRIVER_ANALOGIX_ANX7625 if BOARD_GOOGLE_JUNIPER || BOARD_GOOGLE_DAMU || BOARD_GOOGLE_KAPPA || BOARD_GOOGLE_CERISE || BOARD_GOOGLE_STERN select MT8183_DRAM_EMCP if BOARD_GOOGLE_KRANE
config MAINBOARD_DIR @@ -47,6 +47,8 @@ default "Juniper" if BOARD_GOOGLE_JUNIPER default "Kappa" if BOARD_GOOGLE_KAPPA default "Damu" if BOARD_GOOGLE_DAMU + default "Cerise" if BOARD_GOOGLE_CERISE + default "Stern" if BOARD_GOOGLE_STERN
config DRIVER_TPM_SPI_BUS hex diff --git a/src/mainboard/google/kukui/Kconfig.name b/src/mainboard/google/kukui/Kconfig.name index 4b12034..22130e5 100644 --- a/src/mainboard/google/kukui/Kconfig.name +++ b/src/mainboard/google/kukui/Kconfig.name @@ -35,3 +35,11 @@ config BOARD_GOOGLE_DAMU bool "-> Damu" select BOARD_GOOGLE_KUKUI_COMMON + +config BOARD_GOOGLE_CERISE + bool "-> Cerise" + select BOARD_GOOGLE_KUKUI_COMMON + +config BOARD_GOOGLE_STERN + bool "-> Stern" + select BOARD_GOOGLE_KUKUI_COMMON
-
Chen-Tsung Hsieh (Code Review) -
Hung-Te Lin (Code Review)
-
Marco Chen (Code Review)
-
Patrick Georgi (Code Review)
-
Xinxiong Xu (Code Review)
-
Zhaoyou Hong (Code Review)