Change in coreboot[master]: mb/google/hatch: Set SA slow slew rate to 1/2 for jinlon/dratini

List overview All Threads
Download

newer

older

Change in coreboot[master]: Zork:...

Change in coreboot[master]:...

Chen Wisley (Code Review)

8 Jul 2020 8 Jul '20

10:31 a.m.

Chen Wisley has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43284 )

Change subject: mb/google/hatch: Set SA slow slew rate to 1/2 for jinlon/dratini ......................................................................

mb/google/hatch: Set SA slow slew rate to 1/2 for jinlon/dratini

Applied CL (cb:38212) to reduce acoustic noise, and observed that screen flicked on vt2 on some devices after idle a perior of time. Remove SSR (1/8) setting for SA to default SSR 1/2, issue disappeared, and didn't affect noise much.

BUG=none TEST=build dratini, observe that screen flick issue disapppered

Change-Id: I9e81c2f15dd6babfa360eee213fc4ab6310c7455 --- M src/mainboard/google/hatch/variants/dratini/overridetree.cb M src/mainboard/google/hatch/variants/jinlon/overridetree.cb 2 files changed, 0 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/43284/1

diff --git a/src/mainboard/google/hatch/variants/dratini/overridetree.cb b/src/mainboard/google/hatch/variants/dratini/overridetree.cb index 0bada7d..2bfcc26 100644 --- a/src/mainboard/google/hatch/variants/dratini/overridetree.cb +++ b/src/mainboard/google/hatch/variants/dratini/overridetree.cb @@ -23,7 +23,6 @@ register "AcousticNoiseMitigation" = "1" register "SlowSlewRateForIa" = "2" register "SlowSlewRateForGt" = "2" - register "SlowSlewRateForSa" = "2" register "FastPkgCRampDisableIa" = "1" register "FastPkgCRampDisableGt" = "1" register "FastPkgCRampDisableSa" = "1" diff --git a/src/mainboard/google/hatch/variants/jinlon/overridetree.cb b/src/mainboard/google/hatch/variants/jinlon/overridetree.cb index a3bb782..fc3bb85 100644 --- a/src/mainboard/google/hatch/variants/jinlon/overridetree.cb +++ b/src/mainboard/google/hatch/variants/jinlon/overridetree.cb @@ -23,7 +23,6 @@ register "AcousticNoiseMitigation" = "1" register "SlowSlewRateForIa" = "2" register "SlowSlewRateForGt" = "2" - register "SlowSlewRateForSa" = "2" register "FastPkgCRampDisableIa" = "1" register "FastPkgCRampDisableGt" = "1" register "FastPkgCRampDisableSa" = "1"

Attachments:

attachment.htm (text/html — 3.9 KB)

Show replies by date

Chen Wisley (Code Review)

8 Jul 8 Jul

10:33 a.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43284

to look at the new patch set (#2).

Change subject: mb/google/hatch: Set SA slow slew rate to 1/2 for jinlon/dratini ......................................................................

mb/google/hatch: Set SA slow slew rate to 1/2 for jinlon/dratini

BUG=none TEST=build dratini, observe that screen flick issue disapppered

Change-Id: I9e81c2f15dd6babfa360eee213fc4ab6310c7455 Signed-off-by: Wisley Chen wisley.chen@quantatw.com --- M src/mainboard/google/hatch/variants/dratini/overridetree.cb M src/mainboard/google/hatch/variants/jinlon/overridetree.cb 2 files changed, 0 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/43284/2

Chen Wisley (Code Review)

10:35 a.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43284

to look at the new patch set (#3).

Change subject: mb/google/hatch: Set SA slow slew rate to 1/2 for jinlon/dratini ......................................................................

mb/google/hatch: Set SA slow slew rate to 1/2 for jinlon/dratini

Applied CL (cb:38212) to reduce acoustic noise, and observed that screen flicked on vt2 on some devices after idle a period of time. Remove SSR (1/8) setting for SA to default SSR 1/2, issue disappeared, and didn't affect noise much.

BUG=none TEST=build dratini, observe that screen flick issue disapppered

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/43284/3

Chen Wisley (Code Review)

10:35 a.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43284

to look at the new patch set (#4).

Change subject: mb/google/hatch: Set SA slow slew rate to 1/2 for jinlon/dratini ......................................................................

mb/google/hatch: Set SA slow slew rate to 1/2 for jinlon/dratini

Applied CL (cb:38212) to reduce acoustic noise, and observed that screen flicked on vt2 on some devices after idle a period of time. Remove SSR (1/8) setting for SA to default SSR (1/2), issue disappeared, and didn't affect noise much.

BUG=none TEST=build dratini, observe that screen flick issue disapppered

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/43284/4

Chen Wisley (Code Review)

11:25 a.m.

Chen Wisley has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43284 )

Change subject: mb/google/hatch: Set SA slow slew rate to 1/2 for jinlon/dratini ......................................................................

Patch Set 5:

This change is ready for review.

-- To view, visit https://review.coreboot.org/c/coreboot/+/43284 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9e81c2f15dd6babfa360eee213fc4ab6310c7455 Gerrit-Change-Number: 43284 Gerrit-PatchSet: 5 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@google.com Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 08 Jul 2020 09:25:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Paul Menzel (Code Review)

12:56 p.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43284 )

Change subject: mb/google/hatch: Set SA slow slew rate to 1/2 for jinlon/dratini ......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43284/5//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/43284/5//COMMIT_MSG@9 PS5, Line 9: cb:38212 Please capitalize CB, so Gerrit marks it up.

Please also use git short hashes with the summary, as that is how git can be used.

-- To view, visit https://review.coreboot.org/c/coreboot/+/43284 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9e81c2f15dd6babfa360eee213fc4ab6310c7455 Gerrit-Change-Number: 43284 Gerrit-PatchSet: 5 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@google.com Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 08 Jul 2020 10:56:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Chen Wisley (Code Review)

1:06 p.m.

Hello build bot (Jenkins), Philip Chen, Tim Wawrzynczak, Paul Fagerburg,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43284

to look at the new patch set (#6).

Change subject: mb/google/hatch: Set SA slow slew rate to 1/2 for jinlon/dratini ......................................................................

mb/google/hatch: Set SA slow slew rate to 1/2 for jinlon/dratini

Applied CL (CB:38212, commit eae254e) to reduce acoustic noise, and observed that screen flicked on vt2 on some devices after idle a period of time. Remove SSR (1/8) setting for SA to default SSR (1/2), issue disappeared, and didn't affect noise much.

BUG=b:160754994 TEST=build dratini, observe that screen flick issue disapppered

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/43284/6

-- To view, visit https://review.coreboot.org/c/coreboot/+/43284 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9e81c2f15dd6babfa360eee213fc4ab6310c7455 Gerrit-Change-Number: 43284 Gerrit-PatchSet: 6 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@google.com Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Chen Wisley (Code Review)

1:06 p.m.

Chen Wisley has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43284 )

Change subject: mb/google/hatch: Set SA slow slew rate to 1/2 for jinlon/dratini ......................................................................

Patch Set 6:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43284/5//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/43284/5//COMMIT_MSG@9 PS5, Line 9: cb:38212

...

Please capitalize CB, so Gerrit marks it up. […]

Done, thanks

-- To view, visit https://review.coreboot.org/c/coreboot/+/43284 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9e81c2f15dd6babfa360eee213fc4ab6310c7455 Gerrit-Change-Number: 43284 Gerrit-PatchSet: 6 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@google.com Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 08 Jul 2020 11:06:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Paul Fagerburg (Code Review)

6:04 p.m.

Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43284 )

Change subject: mb/google/hatch: Set SA slow slew rate to 1/2 for jinlon/dratini ......................................................................

Patch Set 6:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43284/6//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/43284/6//COMMIT_MSG@9 PS6, Line 9: Applied CL (CB:38212, commit eae254e) to reduce acoustic noise, and observed that screen Please word-wrap the commit message so that lines are no more than 72 characters long. I would also suggest putting the description of "what" first - "remove SSR (1/8) setting ..." - and then following it with a "why" - because CB:38212 (commit eae254e) caused screen flickering on VT2 on some devices ...

-- To view, visit https://review.coreboot.org/c/coreboot/+/43284 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9e81c2f15dd6babfa360eee213fc4ab6310c7455 Gerrit-Change-Number: 43284 Gerrit-PatchSet: 6 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@google.com Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Fagerburg pfagerburg@chromium.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 08 Jul 2020 16:04:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Chen Wisley (Code Review)

9 Jul 9 Jul

3:21 a.m.

Hello build bot (Jenkins), Philip Chen, Tim Wawrzynczak, Paul Fagerburg,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43284

to look at the new patch set (#7).

Change subject: mb/google/hatch: Set SA slow slew rate to 1/2 for jinlon/dratini ......................................................................

mb/google/hatch: Set SA slow slew rate to 1/2 for jinlon/dratini

Remove SSR (1/8) setting for SA to default SSR (1/2), screen flicking issue disappeared, and didn't affect acoustic noise much.

Because CB:38212 (commit eae254e) caused screen flickering on VT2 on some devices after idle a period of time.

BUG=b:160754994 TEST=build dratini, observe that screen flick issue disapppered

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/43284/7

-- To view, visit https://review.coreboot.org/c/coreboot/+/43284 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9e81c2f15dd6babfa360eee213fc4ab6310c7455 Gerrit-Change-Number: 43284 Gerrit-PatchSet: 7 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@google.com Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Fagerburg pfagerburg@chromium.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Paul Fagerburg (Code Review)

4:19 a.m.

Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43284 )

Change subject: mb/google/hatch: Set SA slow slew rate to 1/2 for jinlon/dratini ......................................................................

Patch Set 7: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/43284 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9e81c2f15dd6babfa360eee213fc4ab6310c7455 Gerrit-Change-Number: 43284 Gerrit-PatchSet: 7 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Paul Fagerburg pfagerburg@google.com Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 09 Jul 2020 02:19:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Chen Wisley (Code Review)

10 Jul 10 Jul

3:05 a.m.

Chen Wisley has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43284 )

Change subject: mb/google/hatch: Set SA slow slew rate to 1/2 for jinlon/dratini ......................................................................

Patch Set 7:

Hi Tim/Philip/Paul,

Could you help to review? if have no concern, please help give CR+2.

Thanks

-- To view, visit https://review.coreboot.org/c/coreboot/+/43284 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9e81c2f15dd6babfa360eee213fc4ab6310c7455 Gerrit-Change-Number: 43284 Gerrit-PatchSet: 7 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Paul Fagerburg pfagerburg@google.com Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 10 Jul 2020 01:05:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Chen Wisley (Code Review)

13 Jul 13 Jul

3:06 a.m.

Chen Wisley has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43284 )

Change subject: mb/google/hatch: Set SA slow slew rate to 1/2 for jinlon/dratini ......................................................................

Patch Set 7:

ping

-- To view, visit https://review.coreboot.org/c/coreboot/+/43284 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9e81c2f15dd6babfa360eee213fc4ab6310c7455 Gerrit-Change-Number: 43284 Gerrit-PatchSet: 7 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Paul Fagerburg pfagerburg@google.com Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 13 Jul 2020 01:06:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Paul Menzel (Code Review)

9:05 a.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43284 )

Change subject: mb/google/hatch: Set SA slow slew rate to 1/2 for jinlon/dratini ......................................................................

Patch Set 7: Code-Review+1

(1 comment)

https://review.coreboot.org/c/coreboot/+/43284/7//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/43284/7//COMMIT_MSG@12 PS7, Line 12: Because CB:38212 (commit eae254e) caused screen flickering on VT2 on : some devices after idle a period of time. Please put the problem description as the first paragraph.

-- To view, visit https://review.coreboot.org/c/coreboot/+/43284 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9e81c2f15dd6babfa360eee213fc4ab6310c7455 Gerrit-Change-Number: 43284 Gerrit-PatchSet: 7 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Paul Fagerburg pfagerburg@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 13 Jul 2020 07:05:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Chen Wisley (Code Review)

12:17 p.m.

Hello build bot (Jenkins), Philip Chen, Paul Menzel, Tim Wawrzynczak, Paul Fagerburg, Paul Fagerburg,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43284

to look at the new patch set (#8).

Change subject: mb/google/hatch: Set SA slow slew rate to 1/2 for jinlon/dratini ......................................................................

mb/google/hatch: Set SA slow slew rate to 1/2 for jinlon/dratini

Screen flickered on VT2 on some devices after idle a period of time.

Remove SSR (1/8) setting for SA to default SSR (1/2), screen flicking issue disappeared, and didn't affect acoustic noise much.

Because CB:38212 (commit eae254e) caused this issue.

BUG=b:160754994 TEST=build dratini, observe that screen flick issue disapppered

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/43284/8

-- To view, visit https://review.coreboot.org/c/coreboot/+/43284 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9e81c2f15dd6babfa360eee213fc4ab6310c7455 Gerrit-Change-Number: 43284 Gerrit-PatchSet: 8 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Paul Fagerburg pfagerburg@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Paul Fagerburg (Code Review)

4:51 p.m.

Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43284 )

Change subject: mb/google/hatch: Set SA slow slew rate to 1/2 for jinlon/dratini ......................................................................

Patch Set 8: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/43284 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9e81c2f15dd6babfa360eee213fc4ab6310c7455 Gerrit-Change-Number: 43284 Gerrit-PatchSet: 8 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Paul Fagerburg pfagerburg@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 13 Jul 2020 14:51:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Chen Wisley (Code Review)

14 Jul 14 Jul

2:06 p.m.

Chen Wisley has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43284 )

Change subject: mb/google/hatch: Set SA slow slew rate to 1/2 for jinlon/dratini ......................................................................

Patch Set 8:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43284/7//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/43284/7//COMMIT_MSG@12 PS7, Line 12: Because CB:38212 (commit eae254e) caused screen flickering on VT2 on : some devices after idle a period of time.

...

Please put the problem description as the first paragraph.

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/43284 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9e81c2f15dd6babfa360eee213fc4ab6310c7455 Gerrit-Change-Number: 43284 Gerrit-PatchSet: 8 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Paul Fagerburg pfagerburg@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 14 Jul 2020 12:06:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Chen Wisley (Code Review)

2:08 p.m.

Chen Wisley has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43284 )

Change subject: mb/google/hatch: Set SA slow slew rate to 1/2 for jinlon/dratini ......................................................................

Patch Set 8:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43284/6//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/43284/6//COMMIT_MSG@9 PS6, Line 9: Applied CL (CB:38212, commit eae254e) to reduce acoustic noise, and observed that screen

...

Please word-wrap the commit message so that lines are no more than 72 characters long. […]

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/43284 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9e81c2f15dd6babfa360eee213fc4ab6310c7455 Gerrit-Change-Number: 43284 Gerrit-PatchSet: 8 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Paul Fagerburg pfagerburg@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 14 Jul 2020 12:08:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Fagerburg pfagerburg@chromium.org Gerrit-MessageType: comment

Patrick Georgi (Code Review)

6:08 p.m.

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43284 )

Change subject: mb/google/hatch: Set SA slow slew rate to 1/2 for jinlon/dratini ......................................................................

mb/google/hatch: Set SA slow slew rate to 1/2 for jinlon/dratini

Screen flickered on VT2 on some devices after idle a period of time.

Remove SSR (1/8) setting for SA to default SSR (1/2), screen flicking issue disappeared, and didn't affect acoustic noise much.

Because CB:38212 (commit eae254e) caused this issue.

BUG=b:160754994 TEST=build dratini, observe that screen flick issue disapppered

Change-Id: I9e81c2f15dd6babfa360eee213fc4ab6310c7455 Signed-off-by: Wisley Chen wisley.chen@quantatw.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/43284 Reviewed-by: Paul Fagerburg pfagerburg@chromium.org Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/hatch/variants/dratini/overridetree.cb M src/mainboard/google/hatch/variants/jinlon/overridetree.cb 2 files changed, 0 insertions(+), 2 deletions(-)

Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Paul Fagerburg: Looks good to me, approved

-- To view, visit https://review.coreboot.org/c/coreboot/+/43284 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9e81c2f15dd6babfa360eee213fc4ab6310c7455 Gerrit-Change-Number: 43284 Gerrit-PatchSet: 9 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Paul Fagerburg pfagerburg@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

1394

days inactive

1400

days old

coreboot-gerrit@coreboot.org

18 comments

4 participants

tags (0)

participants (4)

Chen Wisley (Code Review)
Patrick Georgi (Code Review)
Paul Fagerburg (Code Review)
Paul Menzel (Code Review)