13 Jul
2020
13 Jul
'20
7:52 p.m.
Shreesh Chhabbi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42483 )
Change subject: mainboard/volteer: Enable SaGv for volteer2, delbin & voxel ......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42483/6/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/delbin/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/42483/6/src/mainboard/google/voltee... PS6, Line 2: register "SaGv" = "SaGv_Enabled"
Just a thought: It might be better to set register "SaGv" = "SaGv_Enabled" in baseboard/devicetree. […]
Ack
--
To view, visit https://review.coreboot.org/c/coreboot/+/42483
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1bce3b9f837fb19ba5a20ae31750a73474a86788
Gerrit-Change-Number: 42483
Gerrit-PatchSet: 7
Gerrit-Owner: Shreesh Chhabbi shreesh.chhabbi@intel.com
Gerrit-Reviewer: Alex Levin levinale@chromium.org
Gerrit-Reviewer: Caveh Jalali caveh@chromium.org
Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Raj Astekar raj.astekar@intel.com
Gerrit-Reviewer: Ravishankar Sarawadi ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Shreesh Chhabbi shreesh.chhabbi@intel.corp-partner.google.com
Gerrit-Reviewer: Srinidhi N Kaushik srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Wonkyu Kim wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 13 Jul 2020 19:52:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh furquan@google.com
Gerrit-MessageType: comment