Attention is currently required from: Subrata Banik, Ethan Tsao, Ravishankar Sarawadi, Tim Wawrzynczak. Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61576 )
Change subject: util/ifdtool: add platform_v1 to reduce common ifd tool change ......................................................................
Patch Set 1:
(1 comment)
File util/ifdtool/ifdtool.c:
https://review.coreboot.org/c/coreboot/+/61576/comment/bc7b7152_2f0f4182 PS1, Line 227: PLATFORM_V1
PLATFORM_IFD2 is more applicable as all newer SoC might support IFDv2 instead v1 hence it is more ap […]
IFD2 platform already have use many plaforms which is not same as TGL,ADL.
static const int ifd_2_platforms[] = { PLATFORM_APL, PLATFORM_GLK, PLATFORM_CNL, PLATFORM_LBG, PLATFORM_ICL, PLATFORM_TGL, PLATFORM_JSL, PLATFORM_EHL, PLATFORM_ADL, PLATFORM_SKLKBL, PLATFORM_V1, };
Will PLATFORM_IFD2_COMMON_V1 is better? I think if there is new change for new platform we can use PLATFORM_IFD2_COMMON_V2 like this.
In that case we can use "ifd2_common_v1" or "ifd2_v1" as platform string.
What do you think?