Attention is currently required from: Subrata Banik, Ethan Tsao, Ravishankar Sarawadi, Tim Wawrzynczak.

View Change

1 comment:

• File util/ifdtool/ifdtool.c:

  • Patch Set #1, Line 227: PLATFORM_V1

    PLATFORM_IFD2 is more applicable as all newer SoC might support IFDv2 instead v1 hence it is more ap […]

    IFD2 platform already have use many plaforms which is not same as TGL,ADL.

    static const int ifd_2_platforms[] = {
    	PLATFORM_APL,
    	PLATFORM_GLK,
    	PLATFORM_CNL,
    	PLATFORM_LBG,
    	PLATFORM_ICL,
    	PLATFORM_TGL,
    	PLATFORM_JSL,
    	PLATFORM_EHL,
    	PLATFORM_ADL,
    	PLATFORM_SKLKBL,
    	PLATFORM_V1,
    };

    Will PLATFORM_IFD2_COMMON_V1 is better?
    I think if there is new change for new platform we can use PLATFORM_IFD2_COMMON_V2 like this.

    In that case we can use "ifd2_common_v1" or "ifd2_v1" as platform string.

    What do you think?

To view, visit change 61576. To unsubscribe, or for help writing mail filters, visit settings.