Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29977 )
Change subject: sb/intel/common: Create a common PCH finalise implementation
......................................................................
Patch Set 2:
Outside the scope of this patchset but could we make finalizing in
SMM optional?
Partially, yes. We already have the Kconfig (INTEL_CHIPSET_LOCKDOWN)
to decide. IIRC, locking SMM can only be done from SMM, though, so
that would have to be split out.
We could also always let coreboot trigger the finalization, and
instead make the SPILOCK configurable (for payloads that still need
access). I guess there's also something in depthcharge for these
platforms that didn't want things locked earlier.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/29977
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I781082b1ed507b00815d1e85aec3e56ae5a4bef2
Gerrit-Change-Number: 29977
Gerrit-PatchSet: 2
Gerrit-Owner: Tristan Corrick
tristan@corrick.kiwi
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tristan Corrick
tristan@corrick.kiwi
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 01 Dec 2018 13:36:11 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment