[coreboot-gerrit] Change in ...coreboot[master]: sb/intel/common: Create a common PCH finalise implementation

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29977 )

Change subject: sb/intel/common: Create a common PCH finalise implementation
......................................................................

Patch Set 2:
> Outside the scope of this patchset but could we make finalizing in
> SMM optional?

Partially, yes. We already have the Kconfig (INTEL_CHIPSET_LOCKDOWN)
to decide. IIRC, locking SMM can only be done from SMM, though, so
that would have to be split out.

We could also always let coreboot trigger the finalization, and
instead make the SPILOCK configurable (for payloads that still need
access). I guess there's also something in depthcharge for these
platforms that didn't want things locked earlier.