Attention is currently required from: Cliff Huang, Julius Werner, Lance Zhao, Tim Wawrzynczak.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80007?usp=email )
Change subject: acpi: Reformat C files with clang-format v16 ......................................................................
Patch Set 2:
(2 comments)
File src/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/80007/comment/04bfdb72_fcb88143 : PS1, Line 100: xsdt->header
[to continue the discussion here] […]
I'm fine with whatever we want to do. We probably should document it in our coding style document though. https://doc.coreboot.org/contributing/coding_style.html
https://review.coreboot.org/c/coreboot/+/80007/comment/74ac7cf9_26b8f601 : PS1, Line 608: This issue of using spaces instead of tabs is directly from clang-format. I tested with version 17.06 and see the same problem. It's easy to fix in a script, so that's what I'm doing for now.
#!/usr/bin/env bash
files="$(git ls-files | grep '.c$')" for file in ${files};do ${XGCCPATH}/clang-format -i "${file}" sed -Ei 's|^ {16}|\t\t|g' "${file}" # fix clang-format bug sed -Ei 's|^ {8}|\t|g' "${file}" # fix clang-format bug done