Attention is currently required from: Cliff Huang, Julius Werner, Lance Zhao, Tim Wawrzynczak.

View Change

2 comments:

• File src/acpi/acpi.c:

  • Patch Set #1, Line 100: xsdt->header

    [to continue the discussion here] […]

    I'm fine with whatever we want to do. We probably should document it in our coding style document though.
    https://doc.coreboot.org/contributing/coding_style.html

  • Patch Set #1, Line 608:

    This issue of using spaces instead of tabs is directly from clang-format. I tested with version 17.06 and see the same problem. It's easy to fix in a script, so that's what I'm doing for now.

    #!/usr/bin/env bash

    files="$(git ls-files | grep '\.c$')"
    for file in ${files};do
        ${XGCCPATH}/clang-format -i "${file}"
        sed -Ei 's|^ {16}|\t\t|g' "${file}" # fix clang-format bug
        sed -Ei 's|^ {8}|\t|g' "${file}"    # fix clang-format bug
    done

To view, visit change 80007. To unsubscribe, or for help writing mail filters, visit settings.