Change in ...coreboot[master]: sb/intel/{common,i82801dx}: Update debug code

[Jacob Garber (Code Review)]

Jacob Garber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32179

Change subject: sb/intel/{common,i82801dx}: Update debug code
......................................................................

sb/intel/{common,i82801dx}: Update debug code

This finishes the work done in 3e3b858 (sb/intel/ibexpeak:
Update debug code to match other chips).

Found-by: Coverity Scan, CID 1229598 (DEADCODE)
Signed-off-by: Jacob Garber 
Change-Id: I65df8f3363c62b364e096368a36ba5e9e8894c13
---
M src/southbridge/intel/common/smihandler.c
M src/southbridge/intel/i82801dx/smihandler.c
2 files changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/32179/1

diff --git a/src/southbridge/intel/common/smihandler.c b/src/southbridge/intel/common/smihandler.c
index b2cf49a..8a16aaa 100644
--- a/src/southbridge/intel/common/smihandler.c
+++ b/src/southbridge/intel/common/smihandler.c
@@ -418,7 +418,7 @@
    } else if (tco_sts & (1 << 3)) { /* TIMEOUT */
    	/* Handle TCO timeout */
    	printk(BIOS_DEBUG, "TCO Timeout.\n");
-	} else if (!tco_sts) {
+	} else {
    	dump_tco_status(tco_sts);
    }
 }
diff --git a/src/southbridge/intel/i82801dx/smihandler.c b/src/southbridge/intel/i82801dx/smihandler.c
index 17bedab..18dc4d8 100644
--- a/src/southbridge/intel/i82801dx/smihandler.c
+++ b/src/southbridge/intel/i82801dx/smihandler.c
@@ -490,7 +490,7 @@
    } else if (tco_sts & (1 << 3)) { /* TIMEOUT */
    	/* Handle TCO timeout */
    	printk(BIOS_DEBUG, "TCO Timeout.\n");
-	} else if (!tco_sts) {
+	} else {
    	dump_tco_status(tco_sts);
    }
 }

Change in ...coreboot[master]: sb/intel/{common,i82801dx}: Improve TCO debug code

[Jacob Garber (Code Review)]

Hello Patrick Rudolph, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32179

to look at the new patch set (#2).

Change subject: sb/intel/{common,i82801dx}: Improve TCO debug code
......................................................................

sb/intel/{common,i82801dx}: Improve TCO debug code

Report unhandled TCO bits (previously dead code). This
finishes the work done in 3e3b858 (sb/intel/ibexpeak:
Update debug code to match other chips).

Found-by: Coverity Scan, CID 1229598 (DEADCODE)
Signed-off-by: Jacob Garber 
Change-Id: I65df8f3363c62b364e096368a36ba5e9e8894c13
---
M src/southbridge/intel/common/smihandler.c
M src/southbridge/intel/i82801dx/smihandler.c
2 files changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/32179/2

Change in ...coreboot[master]: sb/intel/{common,i82801dx}: Improve TCO debug code

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32179 )

Change subject: sb/intel/{common,i82801dx}: Improve TCO debug code
......................................................................

Patch Set 2: Code-Review+2

Change in ...coreboot[master]: sb/intel/{common,i82801dx}: Improve TCO debug code

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32179 )

Change subject: sb/intel/{common,i82801dx}: Improve TCO debug code
......................................................................

Patch Set 2: Code-Review+2

Change in ...coreboot[master]: sb/intel/{common,i82801dx}: Improve TCO debug code

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32179 )

Change subject: sb/intel/{common,i82801dx}: Improve TCO debug code
......................................................................

sb/intel/{common,i82801dx}: Improve TCO debug code

Report unhandled TCO bits (previously dead code). This
finishes the work done in 3e3b858 (sb/intel/ibexpeak:
Update debug code to match other chips).

Found-by: Coverity Scan, CID 1229598 (DEADCODE)
Signed-off-by: Jacob Garber 
Change-Id: I65df8f3363c62b364e096368a36ba5e9e8894c13
Reviewed-on: https://review.coreboot.org/c/coreboot/+/32179
Reviewed-by: Patrick Rudolph 
Reviewed-by: Kyösti Mälkki 
Tested-by: build bot (Jenkins) 
---
M src/southbridge/intel/common/smihandler.c
M src/southbridge/intel/i82801dx/smihandler.c
2 files changed, 2 insertions(+), 2 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Kyösti Mälkki: Looks good to me, approved
  Patrick Rudolph: Looks good to me, approved

diff --git a/src/southbridge/intel/common/smihandler.c b/src/southbridge/intel/common/smihandler.c
index b2cf49a..8a16aaa 100644
--- a/src/southbridge/intel/common/smihandler.c
+++ b/src/southbridge/intel/common/smihandler.c
@@ -418,7 +418,7 @@
    } else if (tco_sts & (1 << 3)) { /* TIMEOUT */
    	/* Handle TCO timeout */
    	printk(BIOS_DEBUG, "TCO Timeout.\n");
-	} else if (!tco_sts) {
+	} else {
    	dump_tco_status(tco_sts);
    }
 }
diff --git a/src/southbridge/intel/i82801dx/smihandler.c b/src/southbridge/intel/i82801dx/smihandler.c
index 17bedab..18dc4d8 100644
--- a/src/southbridge/intel/i82801dx/smihandler.c
+++ b/src/southbridge/intel/i82801dx/smihandler.c
@@ -490,7 +490,7 @@
    } else if (tco_sts & (1 << 3)) { /* TIMEOUT */
    	/* Handle TCO timeout */
    	printk(BIOS_DEBUG, "TCO Timeout.\n");
-	} else if (!tco_sts) {
+	} else {
    	dump_tco_status(tco_sts);
    }
 }