Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29917 )
Change subject: src: Remove unused variables
......................................................................
Patch Set 33: Code-Review-2
(2 comments)
I am blocking this on basis that I don't want additional printk's appear with a commit message like this. Specially for amdfam15h SMP init related code path, those platforms are somewhat unstable to boot (although that's probably more of a romstage problem).
https://review.coreboot.org/#/c/29917/31/src/cpu/amd/quadcore/quadcore.c
File src/cpu/amd/quadcore/quadcore.c:
https://review.coreboot.org/#/c/29917/31/src/cpu/amd/quadcore/quadcore.c@98
PS31, Line 98: uint32_t timeout, ap_apicid;
Why promote these, they are only used inside that 'for' block scope.
https://review.coreboot.org/#/c/29917/31/src/cpu/amd/quadcore/quadcore.c@101
PS31, Line 101: get_boot_apic_id(nodeid
It's unrelated, as the fix is to read timeout and print it.
Adding the printk needs to be split to separate change.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/29917
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibdfbf1031130ff861c4313d1271d6ccb68bf8837
Gerrit-Change-Number: 29917
Gerrit-PatchSet: 33
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Damien Zammit
damien@zamaudio.com
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Huang Jin
huang.jin@intel.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: York Yang
yyang024@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Comment-Date: Sun, 07 Apr 2019 03:19:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Patrick Rudolph
siro@das-labor.org
Comment-In-Reply-To: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-MessageType: comment