Change in ...coreboot[master]: cpu/intel/common: Add newline to set_feature_ctrl_lock() output

[Matt DeVillier (Code Review)]

Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31532

Change subject: cpu/intel/common: Add newline to set_feature_ctrl_lock() output
......................................................................

cpu/intel/common: Add newline to set_feature_ctrl_lock() output

Without newline, if IA32_FEATURE_CONTROL already locked, next
console line will be concatenated. If run on a multiple CPUs,
you get multiple lines concatenated.

Change-Id: I5b73ae4cb045973fa3ce07f4d93fda0caadf78eb
Signed-off-by: Matt DeVillier 
---
M src/cpu/intel/common/common_init.c
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/31532/1

diff --git a/src/cpu/intel/common/common_init.c b/src/cpu/intel/common/common_init.c
index 0aef3e8..321c56c 100644
--- a/src/cpu/intel/common/common_init.c
+++ b/src/cpu/intel/common/common_init.c
@@ -83,7 +83,7 @@
    msr = rdmsr(IA32_FEATURE_CONTROL);

if (msr.lo & (1 << 0)) {
-		printk(BIOS_DEBUG, "IA32_FEATURE_CONTROL already locked; ");
+		printk(BIOS_DEBUG, "IA32_FEATURE_CONTROL already locked\n");
    	/* IA32_FEATURE_CONTROL locked. If we set it again we get an
    	 * illegal instruction
    	 */

[Elyes HAOUAS (Code Review)]

Elyes HAOUAS has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31532 )

Change subject: cpu/intel/common: Add newline to set_feature_ctrl_lock() output
......................................................................

Patch Set 1: Code-Review+1

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31532 )

Change subject: cpu/intel/common: Add newline to set_feature_ctrl_lock() output
......................................................................

Patch Set 1: Code-Review+2

Oops.

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31532 )

Change subject: cpu/intel/common: Add newline to set_feature_ctrl_lock() output
......................................................................

Patch Set 1: Code-Review+2

[Nico Huber (Code Review)]

Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31532 )

Change subject: cpu/intel/common: Add newline to set_feature_ctrl_lock() output
......................................................................

cpu/intel/common: Add newline to set_feature_ctrl_lock() output

Without newline, if IA32_FEATURE_CONTROL already locked, next
console line will be concatenated. If run on a multiple CPUs,
you get multiple lines concatenated.

Change-Id: I5b73ae4cb045973fa3ce07f4d93fda0caadf78eb
Signed-off-by: Matt DeVillier 
Reviewed-on: https://review.coreboot.org/c/31532
Tested-by: build bot (Jenkins) 
Reviewed-by: Elyes HAOUAS 
Reviewed-by: Angel Pons 
Reviewed-by: Nico Huber 
---
M src/cpu/intel/common/common_init.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Nico Huber: Looks good to me, approved
  Elyes HAOUAS: Looks good to me, but someone else must approve
  Angel Pons: Looks good to me, approved

diff --git a/src/cpu/intel/common/common_init.c b/src/cpu/intel/common/common_init.c
index 0aef3e8..321c56c 100644
--- a/src/cpu/intel/common/common_init.c
+++ b/src/cpu/intel/common/common_init.c
@@ -83,7 +83,7 @@
    msr = rdmsr(IA32_FEATURE_CONTROL);

if (msr.lo & (1 << 0)) {
-		printk(BIOS_DEBUG, "IA32_FEATURE_CONTROL already locked; ");
+		printk(BIOS_DEBUG, "IA32_FEATURE_CONTROL already locked\n");
    	/* IA32_FEATURE_CONTROL locked. If we set it again we get an
    	 * illegal instruction
    	 */