Attention is currently required from: Sean Rhodes, Paul Menzel. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62994 )
Change subject: ec/starlabs/merlin: Add EC related files for Cezanne boards ......................................................................
Patch Set 5: Code-Review+1
(1 comment)
File src/ec/starlabs/merlin/variants/cezanne/emem.asl:
https://review.coreboot.org/c/coreboot/+/62994/comment/1f62b2be_2675621d PS4, Line 138: Offset(0xf7), : TBTC, 8, // Thunderbolt Command : TBTP, 8, // Thunderbolt Data Port : TBTD, 8, // Thunderbolt Data : TBTA, 8, // Thunderbolt Acknowledge : TBTG, 16, // Thunderbolt DBG Data
They share the same EC code as the Intel ones - so I guess these are just "Reserved but added for co […]
If possible (i.e. if it doesn't cause errors), I wouldn't define these fields. If not, I'd add a comment about it.
-
Angel Pons (Code Review)