Attention is currently required from: Patrick Georgi, Furquan Shaikh, Vitaly Rodionov, Paul Menzel, Nick Vaccaro, Angel Pons, Robert Chen, Marco Chen, Name of user not set #1004174, Karthik Ramasubramanian, Xiang Liu.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61448 )
Change subject: drivers/i2c/cs35l53: Add driver for generating device in SSDT
......................................................................
Patch Set 6:
(1 comment)
File src/drivers/i2c/cs35l53/chip.h:
https://review.coreboot.org/c/coreboot/+/61448/comment/4395bdf2_bf483fe5
PS6, Line 128: enum cs35l53_gpio_src gpio_src_select[CS35L53_MAX_GPIOS];
We made the change to using arrays in response to a suggestion from Subrata Banik. I wouldn't want to change this back without agreement from them.
The reason, I have suggested an array to have flexibility to have more GPIOx if required in future.
Additionally, https://review.coreboot.org/c/coreboot/+/61448/6/src/drivers/i2c/cs35l53/cs3... can better handle using `loop` isn't it ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61448
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2cbb1cef89f8d56ee73fab06c68933a2ab8c3606
Gerrit-Change-Number: 61448
Gerrit-PatchSet: 6
Gerrit-Owner: Vitaly Rodionov
vitaly.rodionov@cirrus.corp-partner.google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Kevin Chiu
kevin.chiu.17802@gmail.com
Gerrit-Reviewer: Marco Chen
marcochen@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Patrick Georgi
patrick@coreboot.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: YH Lin
yueherngl@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Name of user not set #1004174
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Robert Chen
robert.chen@quanta.corp-partner.google.com
Gerrit-CC: Shon Wang
shon.wang@quanta.corp-partner.google.com
Gerrit-CC: Subrata Banik
subratabanik@google.com
Gerrit-CC: Vitaly Rodionov
vitaly.rodionov@gmail.com
Gerrit-CC: Xiang Liu
xiang.liu@cirrus.corp-partner.google.com
Gerrit-CC: YH Lin
yueherngl@chromium.org
Gerrit-Attention: Patrick Georgi
patrick@coreboot.org
Gerrit-Attention: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Attention: Vitaly Rodionov
vitaly.rodionov@cirrus.corp-partner.google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Robert Chen
robert.chen@quanta.corp-partner.google.com
Gerrit-Attention: Marco Chen
marcochen@google.com
Gerrit-Attention: Name of user not set #1004174
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Xiang Liu
xiang.liu@cirrus.corp-partner.google.com
Gerrit-Comment-Date: Tue, 01 Mar 2022 11:56:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Name of user not set #1004174
Gerrit-MessageType: comment