Attention is currently required from: Patrick Georgi, Furquan Shaikh, Vitaly Rodionov, Paul Menzel, Nick Vaccaro, Angel Pons, Robert Chen, Marco Chen, Name of user not set #1004174, Karthik Ramasubramanian, Xiang Liu.

View Change

1 comment:

• File src/drivers/i2c/cs35l53/chip.h:

  • Patch Set #6, Line 128: enum cs35l53_gpio_src gpio_src_select[CS35L53_MAX_GPIOS];

    We made the change to using arrays in response to a suggestion from Subrata Banik. I wouldn't want to change this back without agreement from them.

    The reason, I have suggested an array to have flexibility to have more GPIOx if required in future.

    Additionally, https://review.coreboot.org/c/coreboot/+/61448/6/src/drivers/i2c/cs35l53/cs35l53.c#109 can better handle using `loop` isn't it ?

To view, visit change 61448. To unsubscribe, or for help writing mail filters, visit settings.