Attention is currently required from: Michał Żygowski, Paul Menzel.
Kacper Stojek has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68474 )
Change subject: util/inteltool: Add support for Elkhart lake ......................................................................
Patch Set 8:
(10 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/68474/comment/ac4698dd_69042625 PS1, Line 10:
It is not there. […]
I've done it here in the gerrit editor, so maybe I really did not push this change. Now it is here though.
File util/inteltool/gpio_names/elkhartlake.h:
https://review.coreboot.org/c/coreboot/+/68474/comment/167e7087_1c976490 PS6, Line 447: "VGPIO_0", "n/a", : "VGPIO_4", "n/a", : "VGPIO_5", "n/a", : "VGPIO_6", "n/a", : "VGPIO_7", "n/a", : "VGPIO_8", "n/a", : "VGPIO_9", "n/a", : "VGPIO_10", "n/a", : "VGPIO_11", "n/a", : "VGPIO_12", "n/a", : "VGPIO_13", "n/a", : "VGPIO_18", "n/a", : "VGPIO_19", "n/a", : "VGPIO_20", "n/a", : "VGPIO_21", "n/a", : "VGPIO_22", "n/a", : "VGPIO_23", "n/a", : "VGPIO_24", "n/a", : "VGPIO_25", "n/a", : "VGPIO_30", "n/a", : "VGPIO_31", "n/a", : "VGPIO_32", "n/a", : "VGPIO_33", "n/a", : "VGPIO_34", "n/a", : "VGPIO_35", "n/a", : "VGPIO_36", "n/a", : "VGPIO_37", "n/a", : "VGPIO_39", "n/a",
I guess VGPIOs have only 1 native function which is VGPIOx, so I would suggest to change it to: […]
Done
https://review.coreboot.org/c/coreboot/+/68474/comment/2302c6d8_bd38cf18 PS6, Line 486: "VGPIO_USB_0", "n/a", : "VGPIO_USB_1", "n/a", : "VGPIO_USB_2", "n/a", : "VGPIO_USB_3", "n/a",
"VGPIO_USB_0", "VGPIO_USB_0", […]
Done
https://review.coreboot.org/c/coreboot/+/68474/comment/d62eed63_9680c7c7 PS6, Line 501: &elkhartlake_pch_group_t, : &elkhartlake_pch_group_g,
Bad indent
Done
https://review.coreboot.org/c/coreboot/+/68474/comment/9f0f3853_7946c524 PS6, Line 528: &elkhartlake_pch_group_gpd,
Bad indent
Done
https://review.coreboot.org/c/coreboot/+/68474/comment/d465aeae_ad575495 PS6, Line 539: &elkhartlake_pch_group_s, : &elkhartlake_pch_group_a, : &elkhartlake_pch_group_vgpio_usb,
Bad indent
Done
https://review.coreboot.org/c/coreboot/+/68474/comment/13658ff6_1ce37538 PS6, Line 552: &elkhartlake_pch_group_c, : &elkhartlake_pch_group_f, : &elkhartlake_pch_group_e,
Bad indent
Done
https://review.coreboot.org/c/coreboot/+/68474/comment/764b5b11_40f6de4b PS6, Line 565: &elkhartlake_pch_group_r,
Bad indent
Done
File util/inteltool/gpio_names/elkhartlake.h:
https://review.coreboot.org/c/coreboot/+/68474/comment/a08f3959_2c4759ad PS1, Line 150: "GP_DSW07","n/a",
Let's make it RSVD
Done
File util/inteltool/inteltool.h:
https://review.coreboot.org/c/coreboot/+/68474/comment/ca62531f_36ed672f PS6, Line 300: #define PCI_DEVICE_ID_INTEL_EHL 0x4b00
One TAB more? It seems not to be aligned properly with above defines […]
For now I've just added the tab and left it at that.
-
Kacper Stojek (Code Review)