Attention is currently required from: Michał Żygowski, Paul Menzel.
10 comments:
Commit Message:
It is not there. […]
I've done it here in the gerrit editor, so maybe I really did not push this change. Now it is here though.
File util/inteltool/gpio_names/elkhartlake.h:
"VGPIO_0", "n/a",
"VGPIO_4", "n/a",
"VGPIO_5", "n/a",
"VGPIO_6", "n/a",
"VGPIO_7", "n/a",
"VGPIO_8", "n/a",
"VGPIO_9", "n/a",
"VGPIO_10", "n/a",
"VGPIO_11", "n/a",
"VGPIO_12", "n/a",
"VGPIO_13", "n/a",
"VGPIO_18", "n/a",
"VGPIO_19", "n/a",
"VGPIO_20", "n/a",
"VGPIO_21", "n/a",
"VGPIO_22", "n/a",
"VGPIO_23", "n/a",
"VGPIO_24", "n/a",
"VGPIO_25", "n/a",
"VGPIO_30", "n/a",
"VGPIO_31", "n/a",
"VGPIO_32", "n/a",
"VGPIO_33", "n/a",
"VGPIO_34", "n/a",
"VGPIO_35", "n/a",
"VGPIO_36", "n/a",
"VGPIO_37", "n/a",
"VGPIO_39", "n/a",
I guess VGPIOs have only 1 native function which is VGPIOx, so I would suggest to change it to: […]
Done
"VGPIO_USB_0", "n/a",
"VGPIO_USB_1", "n/a",
"VGPIO_USB_2", "n/a",
"VGPIO_USB_3", "n/a",
"VGPIO_USB_0", "VGPIO_USB_0", […]
Done
&elkhartlake_pch_group_t,
&elkhartlake_pch_group_g,
Bad indent
Done
Patch Set #6, Line 528: &elkhartlake_pch_group_gpd,
Bad indent
Done
&elkhartlake_pch_group_s,
&elkhartlake_pch_group_a,
&elkhartlake_pch_group_vgpio_usb,
Bad indent
Done
&elkhartlake_pch_group_c,
&elkhartlake_pch_group_f,
&elkhartlake_pch_group_e,
Bad indent
Done
Patch Set #6, Line 565: &elkhartlake_pch_group_r,
Bad indent
Done
File util/inteltool/gpio_names/elkhartlake.h:
Patch Set #1, Line 150: "GP_DSW07","n/a",
Let's make it RSVD
Done
File util/inteltool/inteltool.h:
Patch Set #6, Line 300: #define PCI_DEVICE_ID_INTEL_EHL 0x4b00
One TAB more? It seems not to be aligned properly with above defines […]
For now I've just added the tab and left it at that.
To view, visit change 68474. To unsubscribe, or for help writing mail filters, visit settings.