Tao Xia has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47586 )
Change subject: mb/google/kukui: Fix no firmware beep issue ......................................................................
mb/google/kukui: Fix no firmware beep issue
There are no two beeps during the developer screen after changing from the normal mode to the developer mode. The RT1015 amplifier works with I2C mode on Kakadu. So the SCL6/SDA6 should be configured as I2C function instead of GPIO function. And the RT1015 amplifier initialization should be done through I2C6 interface.
BUG=b:171763469 BRANCH=kukui TEST=There are two beeps during the developer screen after changing from the normal mode to the developer mode.
Signed-off-by: Tao Xia xiatao5@huaqin.corp-partner.google.com Change-Id: If07674d94a0b63ac3174d16d11bf371e0bd8c8cf --- M src/mainboard/google/kukui/Kconfig M src/mainboard/google/kukui/chromeos.c M src/mainboard/google/kukui/mainboard.c 3 files changed, 26 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/47586/1
diff --git a/src/mainboard/google/kukui/Kconfig b/src/mainboard/google/kukui/Kconfig index cff94da..358d445 100644 --- a/src/mainboard/google/kukui/Kconfig +++ b/src/mainboard/google/kukui/Kconfig @@ -17,6 +17,12 @@ select EC_GOOGLE_CHROMEEC_SWITCHES select VBOOT_VBNV_FLASH
+config RT1015_I2C_MODE + bool + default n + help + The platform that uses rt1015 I2C mode should select this option to enable it. + config BOARD_SPECIFIC_OPTIONS def_bool y select RTC @@ -37,6 +43,7 @@ select MAINBOARD_FORCE_NATIVE_VGA_INIT select HAVE_LINEAR_FRAMEBUFFER select MT8183_DRAM_EMCP if BOARD_GOOGLE_KRANE || BOARD_GOOGLE_KAKADU + select RT1015_I2C_MODE if BOARD_GOOGLE_KAKADU
config MAINBOARD_DIR string diff --git a/src/mainboard/google/kukui/chromeos.c b/src/mainboard/google/kukui/chromeos.c index c5810d1..6fce1c3 100644 --- a/src/mainboard/google/kukui/chromeos.c +++ b/src/mainboard/google/kukui/chromeos.c @@ -25,7 +25,20 @@ {CR50_IRQ.id, ACTIVE_HIGH, -1, "TPM interrupt"}, {GPIO_EN_SPK_AMP.id, ACTIVE_HIGH, -1, "speaker enable"}, }; - lb_add_gpios(gpios, chromeos_gpios, ARRAY_SIZE(chromeos_gpios)); + + struct lb_gpio chromeos_gpios_1[] = { + {GPIO_WP.id, ACTIVE_LOW, + !get_write_protect_state(), "write protect"}, + {EC_IN_RW.id, ACTIVE_HIGH, -1, "EC in RW"}, + {EC_IRQ.id, ACTIVE_LOW, -1, "EC interrupt"}, + {CR50_IRQ.id, ACTIVE_HIGH, -1, "TPM interrupt"}, + }; + + if (CONFIG(RT1015_I2C_MODE)) + lb_add_gpios(gpios, chromeos_gpios_1, ARRAY_SIZE(chromeos_gpios_1)); + else + lb_add_gpios(gpios, chromeos_gpios, ARRAY_SIZE(chromeos_gpios)); + }
int get_write_protect_state(void) diff --git a/src/mainboard/google/kukui/mainboard.c b/src/mainboard/google/kukui/mainboard.c index 268b7ca..746b3af 100644 --- a/src/mainboard/google/kukui/mainboard.c +++ b/src/mainboard/google/kukui/mainboard.c @@ -18,6 +18,7 @@ #include <soc/mtcmos.h> #include <soc/spm.h> #include <soc/usb.h> +#include <soc/i2c.h> #include <string.h>
#include "gpio.h" @@ -54,6 +55,9 @@ gpio_set_mode(GPIO(CAM_PDN1), PAD_CAM_PDN1_FUNC_I2S2_BCK); gpio_set_mode(GPIO(CAM_PDN0), PAD_CAM_PDN0_FUNC_I2S2_MCK); gpio_set_mode(GPIO(EINT3), PAD_EINT3_FUNC_I2S3_DO); + + if (CONFIG(RT1015_I2C_MODE)) + mtk_i2c_bus_init(6); }
static void configure_ec(void) @@ -91,7 +95,7 @@ gpio_output(GPIO_PPVARN_LCD_EN, 1); gpio_output(GPIO_PP1800_LCM_EN, 1); gpio_output(GPIO_PP3300_LCM_EN, 1); - mdelay(6); + mdelay(15); gpio_output(GPIO_LCM_RST_1V8, 1); mdelay(6); }
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47586 )
Change subject: mb/google/kukui: Fix no firmware beep issue ......................................................................
Patch Set 1:
(20 comments)
https://review.coreboot.org/c/coreboot/+/47586/1/src/mainboard/google/kukui/... File src/mainboard/google/kukui/Kconfig:
https://review.coreboot.org/c/coreboot/+/47586/1/src/mainboard/google/kukui/... PS1, Line 20: config RT1015_I2C_MODE DOS line endings
https://review.coreboot.org/c/coreboot/+/47586/1/src/mainboard/google/kukui/... PS1, Line 21: bool DOS line endings
https://review.coreboot.org/c/coreboot/+/47586/1/src/mainboard/google/kukui/... PS1, Line 22: default n DOS line endings
https://review.coreboot.org/c/coreboot/+/47586/1/src/mainboard/google/kukui/... PS1, Line 23: help DOS line endings
https://review.coreboot.org/c/coreboot/+/47586/1/src/mainboard/google/kukui/... File src/mainboard/google/kukui/chromeos.c:
https://review.coreboot.org/c/coreboot/+/47586/1/src/mainboard/google/kukui/... PS1, Line 29: struct lb_gpio chromeos_gpios_1[] = { DOS line endings
https://review.coreboot.org/c/coreboot/+/47586/1/src/mainboard/google/kukui/... PS1, Line 30: {GPIO_WP.id, ACTIVE_LOW, DOS line endings
https://review.coreboot.org/c/coreboot/+/47586/1/src/mainboard/google/kukui/... PS1, Line 31: !get_write_protect_state(), "write protect"}, DOS line endings
https://review.coreboot.org/c/coreboot/+/47586/1/src/mainboard/google/kukui/... PS1, Line 32: {EC_IN_RW.id, ACTIVE_HIGH, -1, "EC in RW"}, DOS line endings
https://review.coreboot.org/c/coreboot/+/47586/1/src/mainboard/google/kukui/... PS1, Line 33: {EC_IRQ.id, ACTIVE_LOW, -1, "EC interrupt"}, DOS line endings
https://review.coreboot.org/c/coreboot/+/47586/1/src/mainboard/google/kukui/... PS1, Line 34: {CR50_IRQ.id, ACTIVE_HIGH, -1, "TPM interrupt"}, DOS line endings
https://review.coreboot.org/c/coreboot/+/47586/1/src/mainboard/google/kukui/... PS1, Line 35: }; DOS line endings
https://review.coreboot.org/c/coreboot/+/47586/1/src/mainboard/google/kukui/... PS1, Line 36: DOS line endings
https://review.coreboot.org/c/coreboot/+/47586/1/src/mainboard/google/kukui/... PS1, Line 37: if (CONFIG(RT1015_I2C_MODE)) DOS line endings
https://review.coreboot.org/c/coreboot/+/47586/1/src/mainboard/google/kukui/... PS1, Line 38: lb_add_gpios(gpios, chromeos_gpios_1, ARRAY_SIZE(chromeos_gpios_1)); DOS line endings
https://review.coreboot.org/c/coreboot/+/47586/1/src/mainboard/google/kukui/... PS1, Line 39: else DOS line endings
https://review.coreboot.org/c/coreboot/+/47586/1/src/mainboard/google/kukui/... PS1, Line 39: else suspect code indent for conditional statements (8, 12)
https://review.coreboot.org/c/coreboot/+/47586/1/src/mainboard/google/kukui/... PS1, Line 40: lb_add_gpios(gpios, chromeos_gpios, ARRAY_SIZE(chromeos_gpios)); DOS line endings
https://review.coreboot.org/c/coreboot/+/47586/1/src/mainboard/google/kukui/... File src/mainboard/google/kukui/mainboard.c:
https://review.coreboot.org/c/coreboot/+/47586/1/src/mainboard/google/kukui/... PS1, Line 21: #include <soc/i2c.h> DOS line endings
https://review.coreboot.org/c/coreboot/+/47586/1/src/mainboard/google/kukui/... PS1, Line 59: if (CONFIG(RT1015_I2C_MODE)) DOS line endings
https://review.coreboot.org/c/coreboot/+/47586/1/src/mainboard/google/kukui/... PS1, Line 60: mtk_i2c_bus_init(6); DOS line endings
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47586
to look at the new patch set (#2).
Change subject: mb/google/kukui: Fix no firmware beep issue ......................................................................
mb/google/kukui: Fix no firmware beep issue
There are no two beeps during the developer screen after changing from the normal mode to the developer mode. The RT1015 amplifier works with I2C mode on Kakadu. So the SCL6/SDA6 should be configured as I2C function instead of GPIO function. And the RT1015 amplifier initialization should be done through I2C6 interface.
BUG=b:171763469 BRANCH=kukui TEST=There are two beeps during the developer screen after changing from the normal mode to the developer mode.
Signed-off-by: Tao Xia xiatao5@huaqin.corp-partner.google.com Change-Id: If07674d94a0b63ac3174d16d11bf371e0bd8c8cf --- M src/mainboard/google/kukui/Kconfig M src/mainboard/google/kukui/chromeos.c M src/mainboard/google/kukui/mainboard.c 3 files changed, 26 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/47586/2
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47586 )
Change subject: mb/google/kukui: Fix no firmware beep issue ......................................................................
Patch Set 2:
(4 comments)
https://review.coreboot.org/c/coreboot/+/47586/2/src/mainboard/google/kukui/... File src/mainboard/google/kukui/chromeos.c:
https://review.coreboot.org/c/coreboot/+/47586/2/src/mainboard/google/kukui/... PS2, Line 37: if (CONFIG(RT1015_I2C_MODE)) suspect code indent for conditional statements (8, 12)
https://review.coreboot.org/c/coreboot/+/47586/2/src/mainboard/google/kukui/... PS2, Line 38: lb_add_gpios(gpios, chromeos_gpios_1, ARRAY_SIZE(chromeos_gpios_1)); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/47586/2/src/mainboard/google/kukui/... PS2, Line 38: lb_add_gpios(gpios, chromeos_gpios_1, ARRAY_SIZE(chromeos_gpios_1)); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/47586/2/src/mainboard/google/kukui/... PS2, Line 39: else suspect code indent for conditional statements (8, 12)
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47586
to look at the new patch set (#3).
Change subject: mb/google/kukui: Fix no firmware beep issue ......................................................................
mb/google/kukui: Fix no firmware beep issue
There are no two beeps during the developer screen after changing from the normal mode to the developer mode. The RT1015 amplifier works with I2C mode on Kakadu. So the SCL6/SDA6 should be configured as I2C function instead of GPIO function. And the RT1015 amplifier initialization should be done through I2C6 interface.
BUG=b:171763469 BRANCH=kukui TEST=There are two beeps during the developer screen after changing from the normal mode to the developer mode.
Signed-off-by: Tao Xia xiatao5@huaqin.corp-partner.google.com Change-Id: If07674d94a0b63ac3174d16d11bf371e0bd8c8cf --- M src/mainboard/google/kukui/Kconfig M src/mainboard/google/kukui/chromeos.c M src/mainboard/google/kukui/mainboard.c 3 files changed, 25 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/47586/3
Hello Hung-Te Lin, Jianbo Zhang, build bot (Jenkins), Patrick Georgi, Xuxin Xiong, Yu-Ping Wu, Zhuohao Lee,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47586
to look at the new patch set (#4).
Change subject: mb/google/kukui: Fix no firmware beep issue ......................................................................
mb/google/kukui: Fix no firmware beep issue
There are no two beeps during the developer screen after changing from the normal mode to the developer mode. The RT1015 amplifier works with I2C mode on Kakadu. So the SCL6/SDA6 should be configured as I2C function instead of GPIO function. And the RT1015 amplifier initialization should be done through I2C6 interface.
BUG=b:171763469 BRANCH=kukui TEST=There are two beeps during the developer screen after changing from the normal mode to the developer mode.
Signed-off-by: Tao Xia xiatao5@huaqin.corp-partner.google.com Change-Id: If07674d94a0b63ac3174d16d11bf371e0bd8c8cf --- M src/mainboard/google/kukui/Kconfig M src/mainboard/google/kukui/chromeos.c M src/mainboard/google/kukui/mainboard.c 3 files changed, 23 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/47586/4
Hello Hung-Te Lin, Jianbo Zhang, build bot (Jenkins), Patrick Georgi, Xuxin Xiong, Yu-Ping Wu, Zhuohao Lee,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47586
to look at the new patch set (#5).
Change subject: mb/google/kukui: Fix no firmware beep issue ......................................................................
mb/google/kukui: Fix no firmware beep issue
There are no two beeps during the developer screen after changing from the normal mode to the developer mode. The RT1015 amplifier works with I2C mode on Kakadu. So the SCL6/SDA6 should be configured as I2C function instead of GPIO function. And the RT1015 amplifier initialization should be done through I2C6 interface.
BUG=b:171763469 BRANCH=kukui TEST=There are two beeps during the developer screen after changing from the normal mode to the developer mode.
Signed-off-by: Tao Xia xiatao5@huaqin.corp-partner.google.com Change-Id: If07674d94a0b63ac3174d16d11bf371e0bd8c8cf --- M src/mainboard/google/kukui/Kconfig M src/mainboard/google/kukui/chromeos.c M src/mainboard/google/kukui/mainboard.c 3 files changed, 15 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/47586/5
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47586 )
Change subject: mb/google/kukui: Fix no firmware beep issue ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/47586/5/src/mainboard/google/kukui/... File src/mainboard/google/kukui/chromeos.c:
https://review.coreboot.org/c/coreboot/+/47586/5/src/mainboard/google/kukui/... PS5, Line 26: #if (CONFIG_RT1015_I2C_MODE==0) spaces required around that '==' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47586/5/src/mainboard/google/kukui/... PS5, Line 26: #if (CONFIG_RT1015_I2C_MODE==0) braces {} are not necessary for single statement blocks
Hello Hung-Te Lin, Jianbo Zhang, build bot (Jenkins), Patrick Georgi, Xuxin Xiong, Yu-Ping Wu, Zhuohao Lee,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47586
to look at the new patch set (#6).
Change subject: mb/google/kukui: Fix no firmware beep issue ......................................................................
mb/google/kukui: Fix no firmware beep issue
There are no two beeps during the developer screen after changing from the normal mode to the developer mode. The RT1015 amplifier works with I2C mode on Kakadu. So the SCL6/SDA6 should be configured as I2C function instead of GPIO function. And the RT1015 amplifier initialization should be done through I2C6 interface.
BUG=b:171763469 BRANCH=kukui TEST=There are two beeps during the developer screen after changing from the normal mode to the developer mode.
Signed-off-by: Tao Xia xiatao5@huaqin.corp-partner.google.com Change-Id: If07674d94a0b63ac3174d16d11bf371e0bd8c8cf --- M src/mainboard/google/kukui/Kconfig M src/mainboard/google/kukui/chromeos.c M src/mainboard/google/kukui/mainboard.c 3 files changed, 15 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/47586/6
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47586 )
Change subject: mb/google/kukui: Fix no firmware beep issue ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47586/6/src/mainboard/google/kukui/... File src/mainboard/google/kukui/chromeos.c:
https://review.coreboot.org/c/coreboot/+/47586/6/src/mainboard/google/kukui/... PS6, Line 26: #if (CONFIG_RT1015_I2C_MODE == 0) braces {} are not necessary for single statement blocks
Hello Hung-Te Lin, Jianbo Zhang, build bot (Jenkins), Patrick Georgi, Xuxin Xiong, Yu-Ping Wu, Zhuohao Lee,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47586
to look at the new patch set (#7).
Change subject: mb/google/kukui: Fix no firmware beep issue ......................................................................
mb/google/kukui: Fix no firmware beep issue
There are no two beeps during the developer screen after changing from the normal mode to the developer mode. The RT1015 amplifier works with I2C mode on Kakadu. So the SCL6/SDA6 should be configured as I2C function instead of GPIO function. And the RT1015 amplifier initialization should be done through I2C6 interface.
BUG=b:171763469 BRANCH=kukui TEST=There are two beeps during the developer screen after changing from the normal mode to the developer mode.
Signed-off-by: Tao Xia xiatao5@huaqin.corp-partner.google.com Change-Id: If07674d94a0b63ac3174d16d11bf371e0bd8c8cf --- M src/mainboard/google/kukui/Kconfig M src/mainboard/google/kukui/chromeos.c M src/mainboard/google/kukui/mainboard.c 3 files changed, 15 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/47586/7
Hello Hung-Te Lin, Jianbo Zhang, build bot (Jenkins), Patrick Georgi, Xuxin Xiong, Yu-Ping Wu, Zhuohao Lee,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47586
to look at the new patch set (#8).
Change subject: mb/google/kukui: Fix no firmware beep issue ......................................................................
mb/google/kukui: Fix no firmware beep issue
There are no two beeps during the developer screen after changing from the normal mode to the developer mode. The RT1015 amplifier works with I2C mode on Kakadu. So the SCL6/SDA6 should be configured as I2C function instead of GPIO function. And the RT1015 amplifier initialization should be done through I2C6 interface.
BUG=b:171763469 BRANCH=kukui TEST=There are two beeps during the developer screen after changing from the normal mode to the developer mode.
Signed-off-by: Tao Xia xiatao5@huaqin.corp-partner.google.com Change-Id: If07674d94a0b63ac3174d16d11bf371e0bd8c8cf --- M src/mainboard/google/kukui/Kconfig M src/mainboard/google/kukui/chromeos.c M src/mainboard/google/kukui/mainboard.c 3 files changed, 15 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/47586/8
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47586 )
Change subject: mb/google/kukui: Fix no firmware beep issue ......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47586/8/src/mainboard/google/kukui/... File src/mainboard/google/kukui/chromeos.c:
https://review.coreboot.org/c/coreboot/+/47586/8/src/mainboard/google/kukui/... PS8, Line 26: #if !CONFIG(RT1015_I2C_MODE) braces {} are not necessary for single statement blocks
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47586 )
Change subject: mb/google/kukui: Fix no firmware beep issue ......................................................................
Patch Set 9:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47586/9/src/mainboard/google/kukui/... File src/mainboard/google/kukui/chromeos.c:
https://review.coreboot.org/c/coreboot/+/47586/9/src/mainboard/google/kukui/... PS9, Line 26: #if !CONFIG(RT1015_I2C_MODE) braces {} are not necessary for single statement blocks
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47586 )
Change subject: mb/google/kukui: Fix no firmware beep issue ......................................................................
Patch Set 9:
(2 comments)
https://review.coreboot.org/c/coreboot/+/47586/9/src/mainboard/google/kukui/... File src/mainboard/google/kukui/chromeos.c:
https://review.coreboot.org/c/coreboot/+/47586/9/src/mainboard/google/kukui/... PS9, Line 22: struct lb_gpio chromeos_gpios[] = { : {EC_IN_RW.id, ACTIVE_HIGH, -1, "EC in RW"}, : {EC_IRQ.id, ACTIVE_LOW, -1, "EC interrupt"}, : {CR50_IRQ.id, ACTIVE_HIGH, -1, "TPM interrupt"}, : #if !CONFIG(RT1015_I2C_MODE) : {GPIO_EN_SPK_AMP.id, ACTIVE_HIGH, -1, "speaker enable"}, : #endif : }; : : lb_add_gpios(gpios, chromeos_gpios, ARRAY_SIZE(chromeos_gpios)); we can revise this better:
struct lb_gpio common_gpios[] = { ... };
struct lb_gpio speaker_gpios[] = { };
lb_add_gpios(gpios, common_gpios, ...); if (!CONFIG(RT1015_I2C_MODE)) lb_add_gpios(gpios,speaker_gios, ...);
https://review.coreboot.org/c/coreboot/+/47586/9/src/mainboard/google/kukui/... File src/mainboard/google/kukui/mainboard.c:
https://review.coreboot.org/c/coreboot/+/47586/9/src/mainboard/google/kukui/... PS9, Line 98: 15 this should be in another patch.
Hello Hung-Te Lin, Jianbo Zhang, build bot (Jenkins), Patrick Georgi, Xuxin Xiong, Yu-Ping Wu, Zhuohao Lee,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47586
to look at the new patch set (#10).
Change subject: mb/google/kukui: Fix no firmware beep issue ......................................................................
mb/google/kukui: Fix no firmware beep issue
There are no two beeps during the developer screen after changing from the normal mode to the developer mode. The RT1015 amplifier works with I2C mode on Kakadu. So the SCL6/SDA6 should be configured as I2C function instead of GPIO function. And the RT1015 amplifier initialization should be done through I2C6 interface.
BUG=b:171763469 BRANCH=kukui TEST=There are two beeps during the developer screen after changing from the normal mode to the developer mode.
Signed-off-by: Tao Xia xiatao5@huaqin.corp-partner.google.com Change-Id: If07674d94a0b63ac3174d16d11bf371e0bd8c8cf --- M src/mainboard/google/kukui/Kconfig M src/mainboard/google/kukui/chromeos.c M src/mainboard/google/kukui/mainboard.c 3 files changed, 20 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/47586/10
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47586 )
Change subject: mb/google/kukui: Fix no firmware beep issue ......................................................................
Patch Set 10:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47586/10/src/mainboard/google/kukui... File src/mainboard/google/kukui/chromeos.c:
https://review.coreboot.org/c/coreboot/+/47586/10/src/mainboard/google/kukui... PS10, Line 34: if(!CONFIG(RT1015_I2C_MODE)) space required before the open parenthesis '('
Hello Hung-Te Lin, Jianbo Zhang, build bot (Jenkins), Patrick Georgi, Xuxin Xiong, Yu-Ping Wu, Zhuohao Lee,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47586
to look at the new patch set (#11).
Change subject: mb/google/kukui: Fix no firmware beep issue ......................................................................
mb/google/kukui: Fix no firmware beep issue
There are no two beeps during the developer screen after changing from the normal mode to the developer mode. The RT1015 amplifier works with I2C mode on Kakadu. So the SCL6/SDA6 should be configured as I2C function instead of GPIO function. And the RT1015 amplifier initialization should be done through I2C6 interface.
BUG=b:171763469 BRANCH=kukui TEST=There are two beeps during the developer screen after changing from the normal mode to the developer mode.
Signed-off-by: Tao Xia xiatao5@huaqin.corp-partner.google.com Change-Id: If07674d94a0b63ac3174d16d11bf371e0bd8c8cf --- M src/mainboard/google/kukui/Kconfig M src/mainboard/google/kukui/chromeos.c M src/mainboard/google/kukui/mainboard.c 3 files changed, 20 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/47586/11
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47586 )
Change subject: mb/google/kukui: Fix no firmware beep issue ......................................................................
Patch Set 11:
Please hold this. We do want all projects migrate to RT1015 auto mode so this may be not needed.
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47586 )
Change subject: mb/google/kukui: Fix no firmware beep issue ......................................................................
Patch Set 11: Code-Review-1
this should be abandoned by https://review.coreboot.org/c/coreboot/+/48558
Tao Xia has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/47586 )
Change subject: mb/google/kukui: Fix no firmware beep issue ......................................................................
Abandoned
Use RT1015Q/automode
-
build bot (Jenkins) (Code Review) -
Hung-Te Lin (Code Review)
-
Tao Xia (Code Review)