Chen Wisley has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47018 )
Change subject: mb/google/variant/elemi: Select USE_CAR_NEM_ENHANCED_V2 for elemi ......................................................................
mb/google/variant/elemi: Select USE_CAR_NEM_ENHANCED_V2 for elemi
BUG=b:170604353 TEST=emerge-volteer coreboot
Signed-off-by: Wisley Chen wisley.chen@quantatw.com Change-Id: I1a1ab6f3d57d5023523b85bfb00d48d8b70a6c1f --- M src/mainboard/google/volteer/Kconfig.name 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/47018/1
diff --git a/src/mainboard/google/volteer/Kconfig.name b/src/mainboard/google/volteer/Kconfig.name index f59d82b..23e27ca 100644 --- a/src/mainboard/google/volteer/Kconfig.name +++ b/src/mainboard/google/volteer/Kconfig.name @@ -71,3 +71,4 @@ config BOARD_GOOGLE_ELEMI bool "-> Elemi" select BOARD_GOOGLE_BASEBOARD_VOLTEER + select USE_CAR_NEM_ENHANCED_V2
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47018 )
Change subject: mb/google/variant/elemi: Select USE_CAR_NEM_ENHANCED_V2 for elemi ......................................................................
Patch Set 1: Code-Review+2
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47018 )
Change subject: mb/google/variant/elemi: Select USE_CAR_NEM_ENHANCED_V2 for elemi ......................................................................
Patch Set 1:
needs a rebase
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47018 )
Change subject: mb/google/variant/elemi: Select USE_CAR_NEM_ENHANCED_V2 for elemi ......................................................................
Patch Set 1:
Why is CAR code board variant specific?
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47018 )
Change subject: mb/google/variant/elemi: Select USE_CAR_NEM_ENHANCED_V2 for elemi ......................................................................
Patch Set 1:
Patch Set 1:
Why is CAR code board variant specific?
Si revision + its associated ucode
Hello build bot (Jenkins), Tim Wawrzynczak, Nick Vaccaro,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47018
to look at the new patch set (#2).
Change subject: mb/google/variant/elemi: Select USE_CAR_NEM_ENHANCED_V2 for elemi ......................................................................
mb/google/variant/elemi: Select USE_CAR_NEM_ENHANCED_V2 for elemi
BUG=b:170604353 TEST=emerge-volteer coreboot
Signed-off-by: Wisley Chen wisley.chen@quantatw.com Change-Id: I1a1ab6f3d57d5023523b85bfb00d48d8b70a6c1f --- M src/mainboard/google/volteer/Kconfig.name 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/47018/2
Chen Wisley has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47018 )
Change subject: mb/google/variant/elemi: Select USE_CAR_NEM_ENHANCED_V2 for elemi ......................................................................
Patch Set 2:
Patch Set 1:
needs a rebase
done
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47018 )
Change subject: mb/google/variant/elemi: Select USE_CAR_NEM_ENHANCED_V2 for elemi ......................................................................
Patch Set 2: Code-Review+2
Chen Wisley has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47018 )
Change subject: mb/google/variant/elemi: Select USE_CAR_NEM_ENHANCED_V2 for elemi ......................................................................
Patch Set 2:
Hi Tim,
Could you help to merge and cherry-pick to chromeos-2016.05?
Thanks
Tim Wawrzynczak has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47018 )
Change subject: mb/google/variant/elemi: Select USE_CAR_NEM_ENHANCED_V2 for elemi ......................................................................
mb/google/variant/elemi: Select USE_CAR_NEM_ENHANCED_V2 for elemi
BUG=b:170604353 TEST=emerge-volteer coreboot
Signed-off-by: Wisley Chen wisley.chen@quantatw.com Change-Id: I1a1ab6f3d57d5023523b85bfb00d48d8b70a6c1f Reviewed-on: https://review.coreboot.org/c/coreboot/+/47018 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/mainboard/google/volteer/Kconfig.name 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Tim Wawrzynczak: Looks good to me, approved
diff --git a/src/mainboard/google/volteer/Kconfig.name b/src/mainboard/google/volteer/Kconfig.name index d8f1b44..8f966ee 100644 --- a/src/mainboard/google/volteer/Kconfig.name +++ b/src/mainboard/google/volteer/Kconfig.name @@ -80,6 +80,7 @@ config BOARD_GOOGLE_ELEMI bool "-> Elemi" select BOARD_GOOGLE_BASEBOARD_VOLTEER + select USE_CAR_NEM_ENHANCED_V2
config BOARD_GOOGLE_VOEMA bool "-> Voema"