Attention is currently required from: Frans Hendriks, Julius Werner. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49960 )
Change subject: console/vtxprintf.c: Correct code style ......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2: I'm not a fan of changing existing code style unless there is a strong rule about it. Yes, braces are not necessary, but we have discussed multiple times in the community that they can help the reader and maintenance etc. Maybe checkpatch should be updated in that regard?
The switch/case statement looks like a nice, easy to read table and I guess that's what the author intended. So why apply any rule if it decreases readability?
-
Nico Huber (Code Review)