Attention is currently required from: Frans Hendriks, Julius Werner.
View Change
1 comment:
Patchset:
Patch Set #2:
I'm not a fan of changing existing code style unless there is
a strong rule about it. Yes, braces are not necessary, but we
have discussed multiple times in the community that they can
help the reader and maintenance etc. Maybe checkpatch should
be updated in that regard?
The switch/case statement looks like a nice, easy to read table
and I guess that's what the author intended. So why apply any
rule if it decreases readability?
To view, visit change 49960. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibb200bf7dd1ef7632aa4e1213bce72d9165560c9
Gerrit-Change-Number: 49960
Gerrit-PatchSet: 2
Gerrit-Owner: Frans Hendriks <fhendriks@eltan.com>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Julius Werner <jwerner@chromium.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Attention: Frans Hendriks <fhendriks@eltan.com>
Gerrit-Attention: Julius Werner <jwerner@chromium.org>
Gerrit-Comment-Date: Wed, 03 Feb 2021 19:44:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment