Andy Yeh has posted comments on this change. ( https://review.coreboot.org/27350 )
Change subject: [Atlas] MIPI camera ASL files for Atlas ......................................................................
Patch Set 1: Code-Review-1
(3 comments)
please also change comment per the original patch. https://review.coreboot.org/#/c/coreboot/+/25536/
and please open a ticket to track this CL.
https://partnerissuetracker.corp.google.com/
https://review.coreboot.org/#/c/27350/1/src/mainboard/google/poppy/variants/... File src/mainboard/google/poppy/variants/atlas/include/variant/acpi/mipi_camera.asl:
https://review.coreboot.org/#/c/27350/1/src/mainboard/google/poppy/variants/... PS1, Line 115: Package() { 384000000, 96000000 } should be slower for imx208 as the current settings are for nautilus/nocturne.
https://review.coreboot.org/#/c/27350/1/src/mainboard/google/poppy/variants/... PS1, Line 122: remove the blanks
https://review.coreboot.org/#/c/27350/1/src/mainboard/google/poppy/variants/... File src/mainboard/google/poppy/variants/atlas/include/variant/gpio.h:
https://review.coreboot.org/#/c/27350/1/src/mainboard/google/poppy/variants/... PS1, Line 27: #define EN_CAM_CLOCK GPP_D18 suggest to add one more tab to align in gerrit review.
-
Andy Yeh (Code Review)