please also change comment per the original patch.
https://review.coreboot.org/#/c/coreboot/+/25536/

and please open a ticket to track this CL.

https://partnerissuetracker.corp.google.com/

Patch set 1:Code-Review -1

View Change

3 comments:

• File src/mainboard/google/poppy/variants/atlas/include/variant/acpi/mipi_camera.asl:

  • Patch Set #1, Line 115: Package() { 384000000, 96000000 }

    should be slower for imx208 as the current settings are for nautilus/nocturne.

  • Patch Set #1, Line 122:

    remove the blanks

• File src/mainboard/google/poppy/variants/atlas/include/variant/gpio.h:

  • Patch Set #1, Line 27: #define EN_CAM_CLOCK GPP_D18

    suggest to add one more tab to align in gerrit review.

To view, visit change 27350. To unsubscribe, or for help writing mail filters, visit settings.