Change in ...coreboot[master]: nb/intel/x4x: Remove variable set but not used

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32939

Change subject: nb/intel/x4x: Remove variable set but not used
......................................................................

nb/intel/x4x: Remove variable set but not used

Change-Id: I142ae6f7806b3f57b98a158e8f26592aed8fa452
Signed-off-by: Elyes HAOUAS 
---
M src/northbridge/intel/x4x/raminit_ddr23.c
1 file changed, 1 insertion(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/32939/1

diff --git a/src/northbridge/intel/x4x/raminit_ddr23.c b/src/northbridge/intel/x4x/raminit_ddr23.c
index f172623..422b0ff 100644
--- a/src/northbridge/intel/x4x/raminit_ddr23.c
+++ b/src/northbridge/intel/x4x/raminit_ddr23.c
@@ -1317,7 +1317,6 @@
 void send_jedec_cmd(const struct sysinfo *s, u8 r, u8 ch, u8 cmd, u32 val)
 {
    u32 addr = test_address(ch, r);
-	volatile u32 rubbish;
    u8 data8 = cmd;
    u32 data32;

@@ -1337,7 +1336,7 @@
    }
    data32 <<= 3;

-	rubbish = read32((void *)((data32 | addr)));
+	read32((void *)((data32 | addr)));
    udelay(10);
    MCHBAR8_AND_OR(0x271, ~0x3e, NORMALOP_CMD);
    MCHBAR8_AND_OR(0x671, ~0x3e, NORMALOP_CMD);

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32939 )

Change subject: nb/intel/x4x: Remove variable set but not used
......................................................................

Patch Set 1: Code-Review-1

The resulting assembly is not the same, you'd want to test it on hardware if it is functionally equivalent. That the variable is not used is normal, since sending jedec command is simply done by reading a certain address on the DIMM. You obviously don't care about the result since the ram is not yet initialized.

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/32939 )

Change subject: nb/intel/x4x: Remove variable set but not used
......................................................................

Abandoned

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32939 )

Change subject: nb/intel/x4x: Remove variable set but not used
......................................................................

Patch Set 1:
> Patch Set 1: Code-Review-1
>
> The resulting assembly is not the same, you'd want to test it on hardware if it is functionally equivalent. That the variable is not used is normal, since sending jedec command is simply done by reading a certain address on the DIMM. You obviously don't care about the result since the ram is not yet initialized.

See new commentary on CB:32948.

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has restored this change. ( https://review.coreboot.org/c/coreboot/+/32939 )

Change subject: nb/intel/x4x: Remove variable set but not used
......................................................................

Restored

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32939 )

Change subject: nb/intel/x4x: Remove variable set but not used
......................................................................

Patch Set 1: -Code-Review

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32939 )

Change subject: nb/intel/x4x: Remove variable set but not used
......................................................................

Patch Set 1: Code-Review+1

[Felix Held (Code Review)]

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32939 )

Change subject: nb/intel/x4x: Remove variable set but not used
......................................................................

Patch Set 3: Code-Review+2

[Felix Held (Code Review)]

Felix Held has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32939 )

Change subject: nb/intel/x4x: Remove variable set but not used
......................................................................

nb/intel/x4x: Remove variable set but not used

Change-Id: I142ae6f7806b3f57b98a158e8f26592aed8fa452
Signed-off-by: Elyes HAOUAS 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/32939
Reviewed-by: Felix Held 
Reviewed-by: Kyösti Mälkki 
Tested-by: build bot (Jenkins) 
---
M src/northbridge/intel/x4x/raminit_ddr23.c
1 file changed, 1 insertion(+), 2 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Kyösti Mälkki: Looks good to me, but someone else must approve
  Felix Held: Looks good to me, approved

diff --git a/src/northbridge/intel/x4x/raminit_ddr23.c b/src/northbridge/intel/x4x/raminit_ddr23.c
index f172623..422b0ff 100644
--- a/src/northbridge/intel/x4x/raminit_ddr23.c
+++ b/src/northbridge/intel/x4x/raminit_ddr23.c
@@ -1317,7 +1317,6 @@
 void send_jedec_cmd(const struct sysinfo *s, u8 r, u8 ch, u8 cmd, u32 val)
 {
    u32 addr = test_address(ch, r);
-	volatile u32 rubbish;
    u8 data8 = cmd;
    u32 data32;

@@ -1337,7 +1336,7 @@
    }
    data32 <<= 3;

-	rubbish = read32((void *)((data32 | addr)));
+	read32((void *)((data32 | addr)));
    udelay(10);
    MCHBAR8_AND_OR(0x271, ~0x3e, NORMALOP_CMD);
    MCHBAR8_AND_OR(0x671, ~0x3e, NORMALOP_CMD);