Felix Held merged this change.

View Change

Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, but someone else must approve Felix Held: Looks good to me, approved
nb/intel/x4x: Remove variable set but not used

Change-Id: I142ae6f7806b3f57b98a158e8f26592aed8fa452
Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/32939
Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
---
M src/northbridge/intel/x4x/raminit_ddr23.c
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/northbridge/intel/x4x/raminit_ddr23.c b/src/northbridge/intel/x4x/raminit_ddr23.c
index f172623..422b0ff 100644
--- a/src/northbridge/intel/x4x/raminit_ddr23.c
+++ b/src/northbridge/intel/x4x/raminit_ddr23.c
@@ -1317,7 +1317,6 @@
void send_jedec_cmd(const struct sysinfo *s, u8 r, u8 ch, u8 cmd, u32 val)
{
u32 addr = test_address(ch, r);
- volatile u32 rubbish;
u8 data8 = cmd;
u32 data32;

@@ -1337,7 +1336,7 @@
}
data32 <<= 3;

- rubbish = read32((void *)((data32 | addr)));
+ read32((void *)((data32 | addr)));
udelay(10);
MCHBAR8_AND_OR(0x271, ~0x3e, NORMALOP_CMD);
MCHBAR8_AND_OR(0x671, ~0x3e, NORMALOP_CMD);

To view, visit change 32939. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I142ae6f7806b3f57b98a158e8f26592aed8fa452
Gerrit-Change-Number: 32939
Gerrit-PatchSet: 4
Gerrit-Owner: HAOUAS Elyes <ehaouas@noos.fr>
Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki@gmail.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-MessageType: merged