Change in coreboot[master]: vc/eltan/security/verified_boot/vboot_check.c: Increase wb_buffer size

List overview All Threads
Download

newer

older

Change in coreboot[master]: acpi:...

Change in coreboot[master]: tests:...

Frans Hendriks (Code Review)

20 Apr 2020 20 Apr '20

1:50 p.m.

Frans Hendriks has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40526 )

Change subject: vc/eltan/security/verified_boot/vboot_check.c: Increase wb_buffer size ......................................................................

vc/eltan/security/verified_boot/vboot_check.c: Increase wb_buffer size

Commit aee0baf0690681fae85d24e6887d6cbb9209de83 results in error: VB2:vb2_rsa_verify_digest() ERROR - vboot2 work buffer too small! ERROR: HASH table verification failed!

The actual vboot structures require more space. Workbuffer size needs to be increased.

BUG=N/A TEST=Build and boot Facebook fbg1701

Change-Id: I5caebc643eb493f4285c2f2fc164ff3a5d35e24e Signed-off-by: Frans Hendriks fhendriks@eltan.com --- M src/vendorcode/eltan/security/verified_boot/vboot_check.c 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/40526/1

diff --git a/src/vendorcode/eltan/security/verified_boot/vboot_check.c b/src/vendorcode/eltan/security/verified_boot/vboot_check.c index 174a378..bba7e89 100644 --- a/src/vendorcode/eltan/security/verified_boot/vboot_check.c +++ b/src/vendorcode/eltan/security/verified_boot/vboot_check.c @@ -26,7 +26,7 @@ struct vb2_kernel_preamble *pre; static struct vb2_shared_data *sd; size_t size; - uint8_t wb_buffer[2800]; + uint8_t wb_buffer[3000];

if (vb2api_init(&wb_buffer, sizeof(wb_buffer), &ctx)) { goto fail;

Attachments:

attachment.htm (text/html — 2.8 KB)

Show replies by date

Wim Vervoorn (Code Review)

23 Apr 23 Apr

11:07 a.m.

Wim Vervoorn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40526 )

Change subject: vc/eltan/security/verified_boot/vboot_check.c: Increase wb_buffer size ......................................................................

Patch Set 1: Code-Review+2

Stefan Reinauer (Code Review)

24 Apr 24 Apr

3:08 a.m.

Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40526 )

Change subject: vc/eltan/security/verified_boot/vboot_check.c: Increase wb_buffer size ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/40526/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/40526/1//COMMIT_MSG@9 PS1, Line 9: aee0baf0690681fae85d24e6887d6cbb9209de83 Are you sure that's the root cause for the error? CB:40323 (which matches above git hash) looks benign wrt vboot

-- To view, visit https://review.coreboot.org/c/coreboot/+/40526 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5caebc643eb493f4285c2f2fc164ff3a5d35e24e Gerrit-Change-Number: 40526 Gerrit-PatchSet: 1 Gerrit-Owner: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Wim Vervoorn wvervoorn@eltan.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Comment-Date: Fri, 24 Apr 2020 01:08:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Frans Hendriks (Code Review)

28 Apr 28 Apr

2:24 p.m.

Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40526 )

Change subject: vc/eltan/security/verified_boot/vboot_check.c: Increase wb_buffer size ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/40526/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/40526/1//COMMIT_MSG@9 PS1, Line 9: aee0baf0690681fae85d24e6887d6cbb9209de83

...

Are you sure that's the root cause for the error? CB:40323 (which matches above git hash) looks beni […]

Not this specific commit is causing the issue. After a while we built and verify the actual sources on the real system. Using this particual commit does not boot.

Did not investigate the root cause, since we have a solution.

-- To view, visit https://review.coreboot.org/c/coreboot/+/40526 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5caebc643eb493f4285c2f2fc164ff3a5d35e24e Gerrit-Change-Number: 40526 Gerrit-PatchSet: 1 Gerrit-Owner: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Wim Vervoorn wvervoorn@eltan.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Comment-Date: Tue, 28 Apr 2020 12:24:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-MessageType: comment

Patrick Georgi (Code Review)

1 May 1 May

8:37 a.m.

Patrick Georgi has uploaded a new patch set (#2) to the change originally created by Frans Hendriks. ( https://review.coreboot.org/c/coreboot/+/40526 )

Change subject: vc/eltan/security/verified_boot/vboot_check.c: Increase wb_buffer size ......................................................................

vc/eltan/security/verified_boot/vboot_check.c: Increase wb_buffer size

Running commit aee0baf0690681fae85d24e6887d6cbb9209de83 on Facebook fbg1701 results in an error: VB2:vb2_rsa_verify_digest() ERROR - vboot2 work buffer too small! ERROR: HASH table verification failed!

The actual vboot structures require more space. Workbuffer size needs to be increased.

We didn't determine the commit causing the issue because this change fixes the issue.

BUG=N/A TEST=Build and boot Facebook fbg1701

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/40526/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/40526 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5caebc643eb493f4285c2f2fc164ff3a5d35e24e Gerrit-Change-Number: 40526 Gerrit-PatchSet: 2 Gerrit-Owner: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Wim Vervoorn wvervoorn@eltan.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-MessageType: newpatchset

Patrick Georgi (Code Review)

8:38 a.m.

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40526 )

Change subject: vc/eltan/security/verified_boot/vboot_check.c: Increase wb_buffer size ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/40526/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/40526/1//COMMIT_MSG@9 PS1, Line 9: aee0baf0690681fae85d24e6887d6cbb9209de83

...

Not this specific commit is causing the issue. […]

I clarified the commit message

-- To view, visit https://review.coreboot.org/c/coreboot/+/40526 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5caebc643eb493f4285c2f2fc164ff3a5d35e24e Gerrit-Change-Number: 40526 Gerrit-PatchSet: 2 Gerrit-Owner: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Wim Vervoorn wvervoorn@eltan.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Georgi pgeorgi@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Comment-Date: Fri, 01 May 2020 06:38:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Frans Hendriks fhendriks@eltan.com Comment-In-Reply-To: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-MessageType: comment

Patrick Georgi (Code Review)

8:38 a.m.

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40526 )

Change subject: vc/eltan/security/verified_boot/vboot_check.c: Increase wb_buffer size ......................................................................

vc/eltan/security/verified_boot/vboot_check.c: Increase wb_buffer size

The actual vboot structures require more space. Workbuffer size needs to be increased.

We didn't determine the commit causing the issue because this change fixes the issue.

BUG=N/A TEST=Build and boot Facebook fbg1701

Change-Id: I5caebc643eb493f4285c2f2fc164ff3a5d35e24e Signed-off-by: Frans Hendriks fhendriks@eltan.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/40526 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Wim Vervoorn wvervoorn@eltan.com --- M src/vendorcode/eltan/security/verified_boot/vboot_check.c 1 file changed, 1 insertion(+), 1 deletion(-)

Approvals: build bot (Jenkins): Verified Wim Vervoorn: Looks good to me, approved

diff --git a/src/vendorcode/eltan/security/verified_boot/vboot_check.c b/src/vendorcode/eltan/security/verified_boot/vboot_check.c index ac9d73b..a07b470 100644 --- a/src/vendorcode/eltan/security/verified_boot/vboot_check.c +++ b/src/vendorcode/eltan/security/verified_boot/vboot_check.c @@ -26,7 +26,7 @@ struct vb2_kernel_preamble *pre; static struct vb2_shared_data *sd; size_t size; - uint8_t wb_buffer[2800]; + uint8_t wb_buffer[3000];

if (vb2api_init(&wb_buffer, sizeof(wb_buffer), &ctx)) { goto fail;

-- To view, visit https://review.coreboot.org/c/coreboot/+/40526 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5caebc643eb493f4285c2f2fc164ff3a5d35e24e Gerrit-Change-Number: 40526 Gerrit-PatchSet: 3 Gerrit-Owner: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Wim Vervoorn wvervoorn@eltan.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-MessageType: merged

1659

days inactive

1670

days old

coreboot-gerrit@coreboot.org

6 comments

4 participants

tags (0)

participants (4)

Frans Hendriks (Code Review)
Patrick Georgi (Code Review)
Stefan Reinauer (Code Review)
Wim Vervoorn (Code Review)