Patrick Georgi submitted this change.

View Change

Approvals: build bot (Jenkins): Verified Wim Vervoorn: Looks good to me, approved
vc/eltan/security/verified_boot/vboot_check.c: Increase wb_buffer size

Running commit aee0baf0690681fae85d24e6887d6cbb9209de83 on
Facebook fbg1701 results in an error:
VB2:vb2_rsa_verify_digest() ERROR - vboot2 work buffer too small!
ERROR: HASH table verification failed!

The actual vboot structures require more space.
Workbuffer size needs to be increased.

We didn't determine the commit causing the issue because this change
fixes the issue.

BUG=N/A
TEST=Build and boot Facebook fbg1701

Change-Id: I5caebc643eb493f4285c2f2fc164ff3a5d35e24e
Signed-off-by: Frans Hendriks <fhendriks@eltan.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/40526
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Wim Vervoorn <wvervoorn@eltan.com>
---
M src/vendorcode/eltan/security/verified_boot/vboot_check.c
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/vendorcode/eltan/security/verified_boot/vboot_check.c b/src/vendorcode/eltan/security/verified_boot/vboot_check.c
index ac9d73b..a07b470 100644
--- a/src/vendorcode/eltan/security/verified_boot/vboot_check.c
+++ b/src/vendorcode/eltan/security/verified_boot/vboot_check.c
@@ -26,7 +26,7 @@
struct vb2_kernel_preamble *pre;
static struct vb2_shared_data *sd;
size_t size;
- uint8_t wb_buffer[2800];
+ uint8_t wb_buffer[3000];

if (vb2api_init(&wb_buffer, sizeof(wb_buffer), &ctx)) {
goto fail;

To view, visit change 40526. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5caebc643eb493f4285c2f2fc164ff3a5d35e24e
Gerrit-Change-Number: 40526
Gerrit-PatchSet: 3
Gerrit-Owner: Frans Hendriks <fhendriks@eltan.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Wim Vervoorn <wvervoorn@eltan.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-CC: Stefan Reinauer <stefan.reinauer@coreboot.org>
Gerrit-MessageType: merged