Lean Sheng Tan has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48116 )
Change subject: mb/intel/ehlcrb: Add missing 'include <console/console.h>' ......................................................................
mb/intel/ehlcrb: Add missing 'include <console/console.h>'
"Die()" needs <console/console.h>, as per this patch: https://review.coreboot.org/c/coreboot/+/45540
Signed-off-by: Tan, Lean Sheng lean.sheng.tan@intel.com Change-Id: I0f9fae4a1e43477ca8e78ebbebd8c0729f8b7668 --- M src/mainboard/intel/elkhartlake_crb/variants/ehlcrb/memory.c 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/48116/1
diff --git a/src/mainboard/intel/elkhartlake_crb/variants/ehlcrb/memory.c b/src/mainboard/intel/elkhartlake_crb/variants/ehlcrb/memory.c index e764fdc..cca208e 100644 --- a/src/mainboard/intel/elkhartlake_crb/variants/ehlcrb/memory.c +++ b/src/mainboard/intel/elkhartlake_crb/variants/ehlcrb/memory.c @@ -2,6 +2,7 @@
#include <baseboard/variants.h> #include <baseboard/gpio.h> +#include <console/console.h> #include <gpio.h> #include <soc/meminit.h> #include <soc/romstage.h>
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48116 )
Change subject: mb/intel/ehlcrb: Add missing 'include <console/console.h>' ......................................................................
Patch Set 2: Code-Review+2
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48116 )
Change subject: mb/intel/ehlcrb: Add missing 'include <console/console.h>' ......................................................................
Patch Set 3: Code-Review+1
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48116 )
Change subject: mb/intel/ehlcrb: Add missing 'include <console/console.h>' ......................................................................
mb/intel/ehlcrb: Add missing 'include <console/console.h>'
"Die()" needs <console/console.h>, as per this patch: https://review.coreboot.org/c/coreboot/+/45540
Signed-off-by: Tan, Lean Sheng lean.sheng.tan@intel.com Change-Id: I0f9fae4a1e43477ca8e78ebbebd8c0729f8b7668 Reviewed-on: https://review.coreboot.org/c/coreboot/+/48116 Reviewed-by: Frans Hendriks fhendriks@eltan.com Reviewed-by: Werner Zeh werner.zeh@siemens.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/intel/elkhartlake_crb/variants/ehlcrb/memory.c 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Werner Zeh: Looks good to me, approved Frans Hendriks: Looks good to me, but someone else must approve
diff --git a/src/mainboard/intel/elkhartlake_crb/variants/ehlcrb/memory.c b/src/mainboard/intel/elkhartlake_crb/variants/ehlcrb/memory.c index e764fdc..cca208e 100644 --- a/src/mainboard/intel/elkhartlake_crb/variants/ehlcrb/memory.c +++ b/src/mainboard/intel/elkhartlake_crb/variants/ehlcrb/memory.c @@ -2,6 +2,7 @@
#include <baseboard/variants.h> #include <baseboard/gpio.h> +#include <console/console.h> #include <gpio.h> #include <soc/meminit.h> #include <soc/romstage.h>
-
Frans Hendriks (Code Review) -
Lean Sheng Tan (Code Review)
-
Patrick Georgi (Code Review)
-
Werner Zeh (Code Review)