Change in coreboot[master]: soc/intel/jasperlake: Enable CAR NEM enhanced mode

[Aamir Bohra (Code Review)]

Aamir Bohra has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43705 )

Change subject: soc/intel/jasperlake: Enable CAR NEM enhanced mode
......................................................................

soc/intel/jasperlake: Enable CAR NEM enhanced mode

Signed-off-by: Aamir Bohra 
Change-Id: I067b13acfcea940e2e4ae6fc99b5d77458de35a7
---
M src/soc/intel/jasperlake/Kconfig
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/43705/1

diff --git a/src/soc/intel/jasperlake/Kconfig b/src/soc/intel/jasperlake/Kconfig
index 89bbdd3..05543ea 100644
--- a/src/soc/intel/jasperlake/Kconfig
+++ b/src/soc/intel/jasperlake/Kconfig
@@ -24,7 +24,7 @@
    select INTEL_DESCRIPTOR_MODE_CAPABLE
    select HAVE_SMI_HANDLER
    select IDT_IN_EVERY_STAGE
-	select INTEL_CAR_NEM #TODO - Enable INTEL_CAR_NEM_ENHANCED
+	select INTEL_CAR_NEM_ENHANCED
    select INTEL_GMA_ACPI
    select INTEL_GMA_ADD_VBT if RUN_FSP_GOP
    select IOAPIC

[Aamir Bohra (Code Review)]

Hello build bot (Jenkins), Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43705

to look at the new patch set (#2).

Change subject: soc/intel/jasperlake: Enable CAR NEM enhanced mode
......................................................................

soc/intel/jasperlake: Enable CAR NEM enhanced mode

Signed-off-by: Aamir Bohra 
Change-Id: I067b13acfcea940e2e4ae6fc99b5d77458de35a7
---
M src/soc/intel/jasperlake/Kconfig
1 file changed, 2 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/43705/2

[Aamir Bohra (Code Review)]

Hello build bot (Jenkins), Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43705

to look at the new patch set (#3).

Change subject: soc/intel/jasperlake: Enable CAR NEM enhanced mode
......................................................................

soc/intel/jasperlake: Enable CAR NEM enhanced mode

Signed-off-by: Aamir Bohra 
Change-Id: I067b13acfcea940e2e4ae6fc99b5d77458de35a7
---
M src/soc/intel/jasperlake/Kconfig
1 file changed, 2 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/43705/3

[Aamir Bohra (Code Review)]

Hello build bot (Jenkins), Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43705

to look at the new patch set (#4).

Change subject: soc/intel/jasperlake: Enable CAR NEM enhanced mode
......................................................................

soc/intel/jasperlake: Enable CAR NEM enhanced mode

TEST=Build and boot waddledoo board

Signed-off-by: Aamir Bohra 
Change-Id: I067b13acfcea940e2e4ae6fc99b5d77458de35a7
---
M src/soc/intel/jasperlake/Kconfig
1 file changed, 2 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/43705/4

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43705 )

Change subject: soc/intel/jasperlake: Enable CAR NEM enhanced mode
......................................................................

Patch Set 4: Code-Review+2

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43705 )

Change subject: soc/intel/jasperlake: Enable CAR NEM enhanced mode
......................................................................

soc/intel/jasperlake: Enable CAR NEM enhanced mode

TEST=Build and boot waddledoo board

Signed-off-by: Aamir Bohra 
Change-Id: I067b13acfcea940e2e4ae6fc99b5d77458de35a7
Reviewed-on: https://review.coreboot.org/c/coreboot/+/43705
Reviewed-by: Angel Pons 
Tested-by: build bot (Jenkins) 
---
M src/soc/intel/jasperlake/Kconfig
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Angel Pons: Looks good to me, approved

diff --git a/src/soc/intel/jasperlake/Kconfig b/src/soc/intel/jasperlake/Kconfig
index 2da4284..8efa361 100644
--- a/src/soc/intel/jasperlake/Kconfig
+++ b/src/soc/intel/jasperlake/Kconfig
@@ -13,6 +13,7 @@
    select CACHE_MRC_SETTINGS
    select CPU_INTEL_COMMON
    select CPU_INTEL_FIRMWARE_INTERFACE_TABLE
+	select COS_MAPPED_TO_MSB
    select FSP_COMPRESS_FSP_S_LZ4
    select FSP_M_XIP
    select GENERIC_GPIO_LIB
@@ -20,7 +21,6 @@
    select INTEL_DESCRIPTOR_MODE_CAPABLE
    select HAVE_SMI_HANDLER
    select IDT_IN_EVERY_STAGE
-	select INTEL_CAR_NEM #TODO - Enable INTEL_CAR_NEM_ENHANCED
    select INTEL_GMA_ACPI
    select INTEL_GMA_ADD_VBT if RUN_FSP_GOP
    select IOAPIC
@@ -56,6 +56,7 @@
    select TSC_MONOTONIC_TIMER
    select UDELAY_TSC
    select UDK_202005_BINDING
+	select USE_CAR_NEM_ENHANCED_V1
    select DISPLAY_FSP_VERSION_INFO
    select HECI_DISABLE_USING_SMM