Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46534 )
Change subject: libpayload/storage: Enable STORAGE_64BIT_LBA ......................................................................
libpayload/storage: Enable STORAGE_64BIT_LBA
Change-Id: I663029a2137c5af3c77d576fe27db0b8fa7488a9 Signed-off-by: Felix Singer felixsinger@posteo.net --- M payloads/libpayload/drivers/storage/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/46534/1
diff --git a/payloads/libpayload/drivers/storage/Kconfig b/payloads/libpayload/drivers/storage/Kconfig index 268aa50..568282b 100644 --- a/payloads/libpayload/drivers/storage/Kconfig +++ b/payloads/libpayload/drivers/storage/Kconfig @@ -12,7 +12,7 @@ config STORAGE_64BIT_LBA bool "Use 64-bit integers to address sectors" depends on STORAGE - default n + default y help If this is selected, sectors will be addressed by an 64-bit integer. Select this to support LBA-48 for ATA drives.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46534 )
Change subject: libpayload/storage: Enable STORAGE_64BIT_LBA ......................................................................
Patch Set 2:
(1 comment)
This change is ready for review.
https://review.coreboot.org/c/coreboot/+/46534/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46534/1//COMMIT_MSG@8 PS1, Line 8:
Please mention the reason, e.g. […]
Done
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46534 )
Change subject: libpayload/storage: Enable STORAGE_64BIT_LBA ......................................................................
Patch Set 2: Code-Review+1
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46534 )
Change subject: libpayload/storage: Enable STORAGE_64BIT_LBA ......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/46534/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46534/2//COMMIT_MSG@9 PS2, Line 9: 512B sectors, to 2TiB : capacity. Therefore nit: Since nowadays such drives are more common, enable 64-bit LBA to support modern hard drives.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46534 )
Change subject: libpayload/storage: Enable STORAGE_64BIT_LBA ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46534/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46534/2//COMMIT_MSG@9 PS2, Line 9: 512B sectors, to 2TiB : capacity. Therefore
nit: Since nowadays such drives are more common, enable 64-bit LBA to support modern hard drives.
Done
Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46534 )
Change subject: libpayload/storage: Enable STORAGE_64BIT_LBA ......................................................................
libpayload/storage: Enable STORAGE_64BIT_LBA
32-bit LBA limits drives, that have or emulate 512B sectors, to 2TiB capacity. Therefore, enable the 64-bit support.
Change-Id: I663029a2137c5af3c77d576fe27db0b8fa7488a9 Signed-off-by: Felix Singer felixsinger@posteo.net Reviewed-on: https://review.coreboot.org/c/coreboot/+/46534 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Michael Niewöhner foss@mniewoehner.de --- M payloads/libpayload/drivers/storage/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Michael Niewöhner: Looks good to me, approved
diff --git a/payloads/libpayload/drivers/storage/Kconfig b/payloads/libpayload/drivers/storage/Kconfig index 8dffd3b..0c2cc8a 100644 --- a/payloads/libpayload/drivers/storage/Kconfig +++ b/payloads/libpayload/drivers/storage/Kconfig @@ -12,7 +12,7 @@ config STORAGE_64BIT_LBA bool "Use 64-bit integers to address sectors" depends on STORAGE - default n + default y help If this is selected, sectors will be addressed by an 64-bit integer. Select this to support LBA-48 for ATA drives.
-
Felix Singer (Code Review) -
Michael Niewöhner (Code Review)
-
Nico Huber (Code Review)
-
Paul Menzel (Code Review)