Change in coreboot[master]: libpayload/storage: Enable all AHCI controllers by default

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Felix Singer (Code Review)

17 Oct 2020 17 Oct '20

6:07 p.m.

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46533 )

Change subject: libpayload/storage: Enable all AHCI controllers by default ......................................................................

libpayload/storage: Enable all AHCI controllers by default

Change-Id: If30f58f8380ab599f8985e85c64510dc88e96268 Signed-off-by: Felix Singer felixsinger@posteo.net --- M payloads/libpayload/drivers/storage/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/46533/1

diff --git a/payloads/libpayload/drivers/storage/Kconfig b/payloads/libpayload/drivers/storage/Kconfig index fea52c8..268aa50 100644 --- a/payloads/libpayload/drivers/storage/Kconfig +++ b/payloads/libpayload/drivers/storage/Kconfig @@ -45,7 +45,7 @@ config STORAGE_AHCI_ONLY_TESTED bool "Only enable tested controllers" depends on STORAGE_AHCI - default y + default n help If this option is selected only AHCI controllers which are known to work will be used.

Attachments:

attachment.htm (text/html — 2.4 KB)

Show replies by date

Idwer Vollering (Code Review)

17 Oct 17 Oct

6:23 p.m.

Idwer Vollering has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46533 )

Change subject: libpayload/storage: Enable all AHCI controllers by default ......................................................................

Patch Set 1: Code-Review+1

(1 comment)

https://review.coreboot.org/c/coreboot/+/46533/1/payloads/libpayload/drivers... File payloads/libpayload/drivers/storage/Kconfig:

https://review.coreboot.org/c/coreboot/+/46533/1/payloads/libpayload/drivers... PS1, Line 50: selected only This sentence could benefit from having an Oxford commma too.

-- To view, visit https://review.coreboot.org/c/coreboot/+/46533 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If30f58f8380ab599f8985e85c64510dc88e96268 Gerrit-Change-Number: 46533 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sat, 17 Oct 2020 21:23:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Nico Huber (Code Review)

6:33 p.m.

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46533 )

Change subject: libpayload/storage: Enable all AHCI controllers by default ......................................................................

Patch Set 1: Code-Review+2

(1 comment)

https://review.coreboot.org/c/coreboot/+/46533/1/payloads/libpayload/drivers... File payloads/libpayload/drivers/storage/Kconfig:

https://review.coreboot.org/c/coreboot/+/46533/1/payloads/libpayload/drivers... PS1, Line 50: selected only

...

This sentence could benefit from having an Oxford commma too.

Yes, please patch.

-- To view, visit https://review.coreboot.org/c/coreboot/+/46533 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If30f58f8380ab599f8985e85c64510dc88e96268 Gerrit-Change-Number: 46533 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sat, 17 Oct 2020 21:33:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Idwer Vollering vidwer@gmail.com Gerrit-MessageType: comment

Paul Menzel (Code Review)

6:54 p.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46533 )

Change subject: libpayload/storage: Enable all AHCI controllers by default ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/46533/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/46533/1//COMMIT_MSG@8 PS1, Line 8: A short justification would be nice.

...

Default to the option with a higher chance to support your system.

(Though I do not really understand the purpose of this option.)

-- To view, visit https://review.coreboot.org/c/coreboot/+/46533 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If30f58f8380ab599f8985e85c64510dc88e96268 Gerrit-Change-Number: 46533 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sat, 17 Oct 2020 21:54:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Felix Singer (Code Review)

18 Oct 18 Oct

5:31 p.m.

Hello build bot (Jenkins), Nico Huber, Idwer Vollering,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46533

to look at the new patch set (#2).

Change subject: libpayload/storage: Enable all AHCI controllers by default ......................................................................

libpayload/storage: Enable all AHCI controllers by default

Since the list of tested controllers is not actively maintained, enable all AHCI controllers by default. Also, improve the readability of its help text by adding a comma to it.

Change-Id: If30f58f8380ab599f8985e85c64510dc88e96268 Signed-off-by: Felix Singer felixsinger@posteo.net --- M payloads/libpayload/drivers/storage/Kconfig 1 file changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/46533/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/46533 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If30f58f8380ab599f8985e85c64510dc88e96268 Gerrit-Change-Number: 46533 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Felix Singer (Code Review)

5:32 p.m.

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46533 )

Change subject: libpayload/storage: Enable all AHCI controllers by default ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/46533/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/46533/1//COMMIT_MSG@8 PS1, Line 8:

...

A short justification would be nice. […]

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/46533 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If30f58f8380ab599f8985e85c64510dc88e96268 Gerrit-Change-Number: 46533 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sun, 18 Oct 2020 20:32:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Paul Menzel (Code Review)

19 Oct 19 Oct

8:33 a.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46533 )

Change subject: libpayload/storage: Enable all AHCI controllers by default ......................................................................

Patch Set 2: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/46533 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If30f58f8380ab599f8985e85c64510dc88e96268 Gerrit-Change-Number: 46533 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 19 Oct 2020 11:33:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Michael Niewöhner (Code Review)

11:39 a.m.

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46533 )

Change subject: libpayload/storage: Enable all AHCI controllers by default ......................................................................

Patch Set 2: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/46533 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If30f58f8380ab599f8985e85c64510dc88e96268 Gerrit-Change-Number: 46533 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Michael Niewöhner foss@mniewoehner.de Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 19 Oct 2020 14:39:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Nico Huber (Code Review)

1:07 p.m.

Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46533 )

Change subject: libpayload/storage: Enable all AHCI controllers by default ......................................................................

libpayload/storage: Enable all AHCI controllers by default

Since the list of tested controllers is not actively maintained, enable all AHCI controllers by default. Also, improve the readability of its help text by adding a comma to it.

Change-Id: If30f58f8380ab599f8985e85c64510dc88e96268 Signed-off-by: Felix Singer felixsinger@posteo.net Reviewed-on: https://review.coreboot.org/c/coreboot/+/46533 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Michael Niewöhner foss@mniewoehner.de --- M payloads/libpayload/drivers/storage/Kconfig 1 file changed, 2 insertions(+), 2 deletions(-)

Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Michael Niewöhner: Looks good to me, approved

diff --git a/payloads/libpayload/drivers/storage/Kconfig b/payloads/libpayload/drivers/storage/Kconfig index fea52c8..8dffd3b 100644 --- a/payloads/libpayload/drivers/storage/Kconfig +++ b/payloads/libpayload/drivers/storage/Kconfig @@ -45,7 +45,7 @@ config STORAGE_AHCI_ONLY_TESTED bool "Only enable tested controllers" depends on STORAGE_AHCI - default y + default n help - If this option is selected only AHCI controllers which are known + If this option is selected, only AHCI controllers which are known to work will be used.

-- To view, visit https://review.coreboot.org/c/coreboot/+/46533 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If30f58f8380ab599f8985e85c64510dc88e96268 Gerrit-Change-Number: 46533 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Michael Niewöhner foss@mniewoehner.de Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

1321

days inactive

1323

days old

coreboot-gerrit@coreboot.org

8 comments

5 participants

tags (0)

participants (5)

Felix Singer (Code Review)
Idwer Vollering (Code Review)
Michael Niewöhner (Code Review)
Nico Huber (Code Review)
Paul Menzel (Code Review)