Attention is currently required from: Selma Bensaid, Paul Menzel, Bernardo Perez Priego, Andy Yeh, kiran2.kumar@intel.com. ShawnX Tu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58374 )
Change subject: mb/google/brya: Update camera NVM parameters ......................................................................
Patch Set 5: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/58374/comment/a9759f9b_f8307669 PS2, Line 13: should be ocrrect.
Adding verification contact to code review.
It verified by below commands to dump the nvm data on brya device.
# cat /sys/bus/i2c/devices/i2c-PRP0001:02/eeprom > ./brya_imx208_eeprom.bin # hexdump -C ./brya_imx208_eeprom.bin > brya_imx208_eeprom_dump.log
You should see the result be same as module nvm file by vendor provided or meet the Intel nvm calibration format. (e.g. first 4 bytes be 0x01, 0x03, 0x01, 0x00)
More detail see the Jira ticket - https://jira.devtools.intel.com/browse/SYSCROS-67048.
Commit Message:
https://review.coreboot.org/c/coreboot/+/58374/comment/5ee9ca4e_4a3efe69 PS5, Line 13: Test=Boot board, camera nvm parameters should be as expected.
# cat /sys/bus/i2c/devices/i2c-PRP0001:01/eeprom > ./ov8856_eeprom_test.bin […]
Correct the commands to dump the nvm data on brya device.
# cat /sys/bus/i2c/devices/i2c-PRP0001:02/eeprom > ./brya_imx208_eeprom.bin # hexdump -C ./brya_imx208_eeprom.bin > brya_imx208_eeprom_dump.log
-
ShawnX Tu (Code Review)