HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37842 )
Change subject: southbridge: Add missing include <device/pci_def.h> ......................................................................
southbridge: Add missing include <device/pci_def.h>
Change-Id: Ie7295b87ddbbf7a44f099e48a93f40d682b2a888 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/southbridge/intel/common/rcba_pirq.c M src/southbridge/intel/i82801dx/i82801dx.c M src/southbridge/intel/i82801gx/i82801gx.c M src/southbridge/intel/i82801ix/i82801ix.c M src/southbridge/intel/i82801jx/i82801jx.c 5 files changed, 5 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/37842/1
diff --git a/src/southbridge/intel/common/rcba_pirq.c b/src/southbridge/intel/common/rcba_pirq.c index 366fe08..a9be125 100644 --- a/src/southbridge/intel/common/rcba_pirq.c +++ b/src/southbridge/intel/common/rcba_pirq.c @@ -15,6 +15,7 @@
#include <console/console.h> #include <device/device.h> +#include <device/pci_def.h> #include <device/pci.h> #include <southbridge/intel/common/acpi_pirq_gen.h> #include <southbridge/intel/common/rcba_pirq.h> diff --git a/src/southbridge/intel/i82801dx/i82801dx.c b/src/southbridge/intel/i82801dx/i82801dx.c index 765bcb2..c6a6cb6 100644 --- a/src/southbridge/intel/i82801dx/i82801dx.c +++ b/src/southbridge/intel/i82801dx/i82801dx.c @@ -16,6 +16,7 @@
#include <device/device.h> #include <device/pci.h> +#include <device/pci_def.h> #include <device/pci_ops.h> #include "i82801dx.h"
diff --git a/src/southbridge/intel/i82801gx/i82801gx.c b/src/southbridge/intel/i82801gx/i82801gx.c index 6aab741..58c350e 100644 --- a/src/southbridge/intel/i82801gx/i82801gx.c +++ b/src/southbridge/intel/i82801gx/i82801gx.c @@ -17,6 +17,7 @@ #include <console/console.h> #include <device/device.h> #include <device/pci.h> +#include <device/pci_def.h> #include <device/pci_ops.h> #include "i82801gx.h" #include "sata.h" diff --git a/src/southbridge/intel/i82801ix/i82801ix.c b/src/southbridge/intel/i82801ix/i82801ix.c index 753c336a..edcb9f2 100644 --- a/src/southbridge/intel/i82801ix/i82801ix.c +++ b/src/southbridge/intel/i82801ix/i82801ix.c @@ -17,6 +17,7 @@ */
#include <arch/io.h> +#include <device/pci_def.h> #include <device/pci_ops.h> #include <device/device.h> #include <device/pci.h> diff --git a/src/southbridge/intel/i82801jx/i82801jx.c b/src/southbridge/intel/i82801jx/i82801jx.c index ebd427f..f1f0e44 100644 --- a/src/southbridge/intel/i82801jx/i82801jx.c +++ b/src/southbridge/intel/i82801jx/i82801jx.c @@ -17,6 +17,7 @@ */
#include <arch/io.h> +#include <device/pci_def.h> #include <device/pci_ops.h> #include <device/device.h> #include <device/pci.h>
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37842 )
Change subject: southbridge: Add missing include <device/pci_def.h> ......................................................................
Patch Set 1: Code-Review-2
We have some bigger plans around this topic, the -2 is to get the discussion done first so we do not go back-and-forth with this specific header.
This is technically correct, but I would disagree on having PCI_SLOT() and PCI_DEVFN() et.al. defined in <device/pci_def.h>. IMHO that file should be strictly about definitions dictated by the various PCI standard papers.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37842 )
Change subject: southbridge: Add missing include <device/pci_def.h> ......................................................................
Patch Set 1: -Code-Review
(2 comments)
Well on second look, lots of PCI_COMMAND uses there. But for now, let's not add pci_def.h for PCI_SLOT() or PCI_DEVFN().
https://review.coreboot.org/c/coreboot/+/37842/1/src/southbridge/intel/commo... File src/southbridge/intel/common/rcba_pirq.c:
https://review.coreboot.org/c/coreboot/+/37842/1/src/southbridge/intel/commo... PS1, Line 18: #include <device/pci_def.h> don't add
https://review.coreboot.org/c/coreboot/+/37842/1/src/southbridge/intel/i8280... File src/southbridge/intel/i82801dx/i82801dx.c:
https://review.coreboot.org/c/coreboot/+/37842/1/src/southbridge/intel/i8280... PS1, Line 19: #include <device/pci_def.h> don't add
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37842 )
Change subject: southbridge: Add missing include <device/pci_def.h> ......................................................................
Patch Set 1: Code-Review-1
HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/37842 )
Change subject: southbridge: Add missing include <device/pci_def.h> ......................................................................
Abandoned
-
HAOUAS Elyes (Code Review) -
Kyösti Mälkki (Code Review)